Revision 7a3b9500f2ff6778ec2fc1219c5ffef3da8938fa authored by Josh Rosen on 23 August 2023, 05:54:21 UTC, committed by Kent Yao on 23 August 2023, 05:55:01 UTC
### What changes were proposed in this pull request? https://github.com/apache/spark/pull/41785 / SPARK-44241 introduced a new `awaitUninterruptibly()` call in one branch of `TrasportClientFactory.createClient()` (executed when the connection create timeout is non-positive). This PR replaces that call with an interruptible `await()` call. Note that the other pre-existing branches in this method were already using `await()`. ### Why are the changes needed? Uninterruptible waiting can cause problems when cancelling tasks. For details, see https://github.com/apache/spark/pull/16866 / SPARK-19529, an older PR fixing a similar issue in this same `TransportClientFactory.createClient()` method. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #42619 from JoshRosen/remove-awaitUninterruptibly. Authored-by: Josh Rosen <joshrosen@databricks.com> Signed-off-by: Kent Yao <yao@apache.org> (cherry picked from commit 2137606a6686b33bed57800c6b166059b134a089) Signed-off-by: Kent Yao <yao@apache.org>
1 parent 70624e6
| File | Mode | Size |
|---|---|---|
| fairscheduler.xml.template | -rw-r--r-- | 1.1 KB |
| log4j2.properties.template | -rw-r--r-- | 3.3 KB |
| metrics.properties.template | -rw-r--r-- | 8.9 KB |
| spark-defaults.conf.template | -rw-r--r-- | 1.3 KB |
| spark-env.sh.template | -rwxr-xr-x | 4.6 KB |
| workers.template | -rw-r--r-- | 865 bytes |
Computing file changes ...
