https://github.com/torvalds/linux
Revision 7ba1b689038726d34e3244c1ac9e2e18c2ea4787 authored by Ralf Baechle on 09 February 2017, 13:12:11 UTC, committed by David S. Miller on 10 February 2017, 18:41:13 UTC
If a USB-to-serial adapter is unplugged, the driver re-initializes, with dev->hard_header_len and dev->addr_len set to zero, instead of the correct values. If then a packet is sent through the half-dead interface, the kernel will panic due to running out of headroom in the skb when pushing for the AX.25 headers resulting in this panic: [<c0595468>] (skb_panic) from [<c0401f70>] (skb_push+0x4c/0x50) [<c0401f70>] (skb_push) from [<bf0bdad4>] (ax25_hard_header+0x34/0xf4 [ax25]) [<bf0bdad4>] (ax25_hard_header [ax25]) from [<bf0d05d4>] (ax_header+0x38/0x40 [mkiss]) [<bf0d05d4>] (ax_header [mkiss]) from [<c041b584>] (neigh_compat_output+0x8c/0xd8) [<c041b584>] (neigh_compat_output) from [<c043e7a8>] (ip_finish_output+0x2a0/0x914) [<c043e7a8>] (ip_finish_output) from [<c043f948>] (ip_output+0xd8/0xf0) [<c043f948>] (ip_output) from [<c043f04c>] (ip_local_out_sk+0x44/0x48) This patch makes mkiss behave like the 6pack driver. 6pack does not panic. In 6pack.c sp_setup() (same function name here) the values for dev->hard_header_len and dev->addr_len are set to the same values as in my mkiss patch. [ralf@linux-mips.org: Massages original submission to conform to the usual standards for patch submissions.] Signed-off-by: Thomas Osterried <thomas@osterried.de> Signed-off-by: Ralf Baechle <ralf@linux-mips.org> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent b85ea00
Tip revision: 7ba1b689038726d34e3244c1ac9e2e18c2ea4787 authored by Ralf Baechle on 09 February 2017, 13:12:11 UTC
NET: mkiss: Fix panic
NET: mkiss: Fix panic
Tip revision: 7ba1b68
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 442 bytes |
Makefile | -rw-r--r-- | 251 bytes |
attr.c | -rw-r--r-- | 3.0 KB |
bfind.c | -rw-r--r-- | 4.5 KB |
bitmap.c | -rw-r--r-- | 5.8 KB |
bnode.c | -rw-r--r-- | 11.2 KB |
brec.c | -rw-r--r-- | 13.5 KB |
btree.c | -rw-r--r-- | 8.6 KB |
btree.h | -rw-r--r-- | 5.1 KB |
catalog.c | -rw-r--r-- | 9.4 KB |
dir.c | -rw-r--r-- | 8.0 KB |
extent.c | -rw-r--r-- | 13.8 KB |
hfs.h | -rw-r--r-- | 9.1 KB |
hfs_fs.h | -rw-r--r-- | 8.7 KB |
inode.c | -rw-r--r-- | 18.3 KB |
mdb.c | -rw-r--r-- | 10.1 KB |
part_tbl.c | -rw-r--r-- | 2.9 KB |
string.c | -rw-r--r-- | 3.7 KB |
super.c | -rw-r--r-- | 12.3 KB |
sysdep.c | -rw-r--r-- | 1.0 KB |
trans.c | -rw-r--r-- | 3.4 KB |
Computing file changes ...