https://github.com/torvalds/linux
Revision 7ba1b689038726d34e3244c1ac9e2e18c2ea4787 authored by Ralf Baechle on 09 February 2017, 13:12:11 UTC, committed by David S. Miller on 10 February 2017, 18:41:13 UTC
If a USB-to-serial adapter is unplugged, the driver re-initializes, with dev->hard_header_len and dev->addr_len set to zero, instead of the correct values. If then a packet is sent through the half-dead interface, the kernel will panic due to running out of headroom in the skb when pushing for the AX.25 headers resulting in this panic: [<c0595468>] (skb_panic) from [<c0401f70>] (skb_push+0x4c/0x50) [<c0401f70>] (skb_push) from [<bf0bdad4>] (ax25_hard_header+0x34/0xf4 [ax25]) [<bf0bdad4>] (ax25_hard_header [ax25]) from [<bf0d05d4>] (ax_header+0x38/0x40 [mkiss]) [<bf0d05d4>] (ax_header [mkiss]) from [<c041b584>] (neigh_compat_output+0x8c/0xd8) [<c041b584>] (neigh_compat_output) from [<c043e7a8>] (ip_finish_output+0x2a0/0x914) [<c043e7a8>] (ip_finish_output) from [<c043f948>] (ip_output+0xd8/0xf0) [<c043f948>] (ip_output) from [<c043f04c>] (ip_local_out_sk+0x44/0x48) This patch makes mkiss behave like the 6pack driver. 6pack does not panic. In 6pack.c sp_setup() (same function name here) the values for dev->hard_header_len and dev->addr_len are set to the same values as in my mkiss patch. [ralf@linux-mips.org: Massages original submission to conform to the usual standards for patch submissions.] Signed-off-by: Thomas Osterried <thomas@osterried.de> Signed-off-by: Ralf Baechle <ralf@linux-mips.org> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent b85ea00
Tip revision: 7ba1b689038726d34e3244c1ac9e2e18c2ea4787 authored by Ralf Baechle on 09 February 2017, 13:12:11 UTC
NET: mkiss: Fix panic
NET: mkiss: Fix panic
Tip revision: 7ba1b68
File | Mode | Size |
---|---|---|
9p | ||
adfs | ||
affs | ||
afs | ||
autofs4 | ||
befs | ||
bfs | ||
btrfs | ||
cachefiles | ||
ceph | ||
cifs | ||
coda | ||
configfs | ||
cramfs | ||
crypto | ||
debugfs | ||
devpts | ||
dlm | ||
ecryptfs | ||
efivarfs | ||
efs | ||
exofs | ||
exportfs | ||
ext2 | ||
ext4 | ||
f2fs | ||
fat | ||
freevxfs | ||
fscache | ||
fuse | ||
gfs2 | ||
hfs | ||
hfsplus | ||
hostfs | ||
hpfs | ||
hugetlbfs | ||
isofs | ||
jbd2 | ||
jffs2 | ||
jfs | ||
kernfs | ||
lockd | ||
minix | ||
ncpfs | ||
nfs | ||
nfs_common | ||
nfsd | ||
nilfs2 | ||
nls | ||
notify | ||
ntfs | ||
ocfs2 | ||
omfs | ||
openpromfs | ||
orangefs | ||
overlayfs | ||
proc | ||
pstore | ||
qnx4 | ||
qnx6 | ||
quota | ||
ramfs | ||
reiserfs | ||
romfs | ||
squashfs | ||
sysfs | ||
sysv | ||
tracefs | ||
ubifs | ||
udf | ||
ufs | ||
xfs | ||
Kconfig | -rw-r--r-- | 7.2 KB |
Kconfig.binfmt | -rw-r--r-- | 7.2 KB |
Makefile | -rw-r--r-- | 4.2 KB |
aio.c | -rw-r--r-- | 45.9 KB |
anon_inodes.c | -rw-r--r-- | 4.9 KB |
attr.c | -rw-r--r-- | 9.1 KB |
bad_inode.c | -rw-r--r-- | 5.3 KB |
binfmt_aout.c | -rw-r--r-- | 10.7 KB |
binfmt_elf.c | -rw-r--r-- | 60.9 KB |
binfmt_elf_fdpic.c | -rw-r--r-- | 46.9 KB |
binfmt_em86.c | -rw-r--r-- | 2.8 KB |
binfmt_flat.c | -rw-r--r-- | 27.8 KB |
binfmt_misc.c | -rw-r--r-- | 18.3 KB |
binfmt_script.c | -rw-r--r-- | 3.0 KB |
block_dev.c | -rw-r--r-- | 55.3 KB |
buffer.c | -rw-r--r-- | 91.5 KB |
char_dev.c | -rw-r--r-- | 13.5 KB |
compat.c | -rw-r--r-- | 35.3 KB |
compat_binfmt_elf.c | -rw-r--r-- | 3.7 KB |
compat_ioctl.c | -rw-r--r-- | 45.8 KB |
coredump.c | -rw-r--r-- | 21.2 KB |
dax.c | -rw-r--r-- | 39.6 KB |
dcache.c | -rw-r--r-- | 93.8 KB |
dcookies.c | -rw-r--r-- | 6.9 KB |
direct-io.c | -rw-r--r-- | 38.3 KB |
drop_caches.c | -rw-r--r-- | 1.6 KB |
eventfd.c | -rw-r--r-- | 12.9 KB |
eventpoll.c | -rw-r--r-- | 60.1 KB |
exec.c | -rw-r--r-- | 44.4 KB |
fcntl.c | -rw-r--r-- | 16.7 KB |
fhandle.c | -rw-r--r-- | 6.5 KB |
file.c | -rw-r--r-- | 23.6 KB |
file_table.c | -rw-r--r-- | 8.5 KB |
filesystems.c | -rw-r--r-- | 6.4 KB |
fs-writeback.c | -rw-r--r-- | 70.4 KB |
fs_pin.c | -rw-r--r-- | 2.0 KB |
fs_struct.c | -rw-r--r-- | 3.3 KB |
inode.c | -rw-r--r-- | 55.0 KB |
internal.h | -rw-r--r-- | 4.7 KB |
ioctl.c | -rw-r--r-- | 17.2 KB |
iomap.c | -rw-r--r-- | 22.8 KB |
libfs.c | -rw-r--r-- | 30.4 KB |
locks.c | -rw-r--r-- | 73.3 KB |
mbcache.c | -rw-r--r-- | 11.9 KB |
mount.h | -rw-r--r-- | 3.8 KB |
mpage.c | -rw-r--r-- | 20.5 KB |
namei.c | -rw-r--r-- | 119.6 KB |
namespace.c | -rw-r--r-- | 84.5 KB |
no-block.c | -rw-r--r-- | 688 bytes |
nsfs.c | -rw-r--r-- | 5.1 KB |
open.c | -rw-r--r-- | 27.6 KB |
pipe.c | -rw-r--r-- | 27.3 KB |
pnode.c | -rw-r--r-- | 11.3 KB |
pnode.h | -rw-r--r-- | 1.9 KB |
posix_acl.c | -rw-r--r-- | 21.4 KB |
proc_namespace.c | -rw-r--r-- | 7.8 KB |
read_write.c | -rw-r--r-- | 45.8 KB |
readdir.c | -rw-r--r-- | 7.3 KB |
select.c | -rw-r--r-- | 25.7 KB |
seq_file.c | -rw-r--r-- | 23.1 KB |
signalfd.c | -rw-r--r-- | 9.2 KB |
splice.c | -rw-r--r-- | 39.9 KB |
stack.c | -rw-r--r-- | 2.5 KB |
stat.c | -rw-r--r-- | 11.9 KB |
statfs.c | -rw-r--r-- | 5.3 KB |
super.c | -rw-r--r-- | 37.8 KB |
sync.c | -rw-r--r-- | 9.9 KB |
timerfd.c | -rw-r--r-- | 13.1 KB |
userfaultfd.c | -rw-r--r-- | 36.3 KB |
utimes.c | -rw-r--r-- | 5.6 KB |
xattr.c | -rw-r--r-- | 23.5 KB |
Computing file changes ...