Revision 7db37c5e6575b229a5051be1d3ef15257ae0ba5d authored by Dave Chinner on 27 January 2011, 01:02:00 UTC, committed by Dave Chinner on 27 January 2011, 01:02:00 UTC
The kmemleak detector shows this after test 139:
unreferenced object 0xffff880079b88bb0 (size 264):
comm "xfs_io", pid 4904, jiffies 4294909382 (age 276.824s)
hex dump (first 32 bytes):
00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00 .....N..........
ff ff ff ff ff ff ff ff 48 7b c9 82 ff ff ff ff ........H{......
backtrace:
[<ffffffff81afb04d>] kmemleak_alloc+0x2d/0x60
[<ffffffff8115c6cf>] kmem_cache_alloc+0x13f/0x2b0
[<ffffffff814aaa97>] kmem_zone_alloc+0x77/0xf0
[<ffffffff814aab2e>] kmem_zone_zalloc+0x1e/0x50
[<ffffffff8148f394>] xlog_ticket_alloc+0x34/0x170
[<ffffffff81494444>] xlog_cil_push+0xa4/0x3f0
[<ffffffff81494eca>] xlog_cil_force_lsn+0x15a/0x160
[<ffffffff814933a5>] _xfs_log_force_lsn+0x75/0x2d0
[<ffffffff814a264d>] _xfs_trans_commit+0x2bd/0x2f0
[<ffffffff8148bfdd>] xfs_iomap_write_allocate+0x1ad/0x350
[<ffffffff814ac17f>] xfs_map_blocks+0x21f/0x370
[<ffffffff814ad1b7>] xfs_vm_writepage+0x1c7/0x550
[<ffffffff8112200a>] __writepage+0x1a/0x50
[<ffffffff81122df2>] write_cache_pages+0x1c2/0x4c0
[<ffffffff81123117>] generic_writepages+0x27/0x30
[<ffffffff814aba5d>] xfs_vm_writepages+0x5d/0x80
By inspection, the leak occurs when xlog_write() returns and error
and we jump to the abort path without dropping the reference on the
active ticket.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Alex Elder <aelder@sgi.com>
1 parent c56eb8f
| File | Mode | Size |
|---|---|---|
| 9p | ||
| adfs | ||
| affs | ||
| afs | ||
| autofs4 | ||
| befs | ||
| bfs | ||
| btrfs | ||
| cachefiles | ||
| ceph | ||
| cifs | ||
| coda | ||
| configfs | ||
| cramfs | ||
| debugfs | ||
| devpts | ||
| dlm | ||
| ecryptfs | ||
| efs | ||
| exofs | ||
| exportfs | ||
| ext2 | ||
| ext3 | ||
| ext4 | ||
| fat | ||
| freevxfs | ||
| fscache | ||
| fuse | ||
| gfs2 | ||
| hfs | ||
| hfsplus | ||
| hostfs | ||
| hpfs | ||
| hppfs | ||
| hugetlbfs | ||
| isofs | ||
| jbd | ||
| jbd2 | ||
| jffs2 | ||
| jfs | ||
| lockd | ||
| logfs | ||
| minix | ||
| ncpfs | ||
| nfs | ||
| nfs_common | ||
| nfsd | ||
| nilfs2 | ||
| nls | ||
| notify | ||
| ntfs | ||
| ocfs2 | ||
| omfs | ||
| openpromfs | ||
| partitions | ||
| proc | ||
| qnx4 | ||
| quota | ||
| ramfs | ||
| reiserfs | ||
| romfs | ||
| squashfs | ||
| sysfs | ||
| sysv | ||
| ubifs | ||
| udf | ||
| ufs | ||
| xfs | ||
| Kconfig | -rw-r--r-- | 5.3 KB |
| Kconfig.binfmt | -rw-r--r-- | 6.4 KB |
| Makefile | -rw-r--r-- | 4.0 KB |
| aio.c | -rw-r--r-- | 46.6 KB |
| anon_inodes.c | -rw-r--r-- | 6.3 KB |
| attr.c | -rw-r--r-- | 6.6 KB |
| bad_inode.c | -rw-r--r-- | 7.8 KB |
| binfmt_aout.c | -rw-r--r-- | 12.4 KB |
| binfmt_elf.c | -rw-r--r-- | 53.7 KB |
| binfmt_elf_fdpic.c | -rw-r--r-- | 48.7 KB |
| binfmt_em86.c | -rw-r--r-- | 2.8 KB |
| binfmt_flat.c | -rw-r--r-- | 26.8 KB |
| binfmt_misc.c | -rw-r--r-- | 15.2 KB |
| binfmt_script.c | -rw-r--r-- | 2.8 KB |
| binfmt_som.c | -rw-r--r-- | 7.4 KB |
| bio-integrity.c | -rw-r--r-- | 21.2 KB |
| bio.c | -rw-r--r-- | 39.5 KB |
| block_dev.c | -rw-r--r-- | 39.1 KB |
| buffer.c | -rw-r--r-- | 87.2 KB |
| char_dev.c | -rw-r--r-- | 13.8 KB |
| compat.c | -rw-r--r-- | 55.6 KB |
| compat_binfmt_elf.c | -rw-r--r-- | 3.5 KB |
| compat_ioctl.c | -rw-r--r-- | 45.8 KB |
| dcache.c | -rw-r--r-- | 78.0 KB |
| dcookies.c | -rw-r--r-- | 6.8 KB |
| direct-io.c | -rw-r--r-- | 35.0 KB |
| drop_caches.c | -rw-r--r-- | 1.3 KB |
| eventfd.c | -rw-r--r-- | 11.0 KB |
| eventpoll.c | -rw-r--r-- | 38.9 KB |
| exec.c | -rw-r--r-- | 48.6 KB |
| fcntl.c | -rw-r--r-- | 18.3 KB |
| fifo.c | -rw-r--r-- | 3.2 KB |
| file.c | -rw-r--r-- | 11.7 KB |
| file_table.c | -rw-r--r-- | 12.1 KB |
| filesystems.c | -rw-r--r-- | 6.4 KB |
| fs-writeback.c | -rw-r--r-- | 34.2 KB |
| fs_struct.c | -rw-r--r-- | 3.9 KB |
| generic_acl.c | -rw-r--r-- | 4.7 KB |
| inode.c | -rw-r--r-- | 44.1 KB |
| internal.h | -rw-r--r-- | 2.8 KB |
| ioctl.c | -rw-r--r-- | 15.7 KB |
| ioprio.c | -rw-r--r-- | 5.0 KB |
| libfs.c | -rw-r--r-- | 25.3 KB |
| locks.c | -rw-r--r-- | 58.4 KB |
| mbcache.c | -rw-r--r-- | 16.3 KB |
| mpage.c | -rw-r--r-- | 19.7 KB |
| namei.c | -rw-r--r-- | 88.3 KB |
| namespace.c | -rw-r--r-- | 63.1 KB |
| nfsctl.c | -rw-r--r-- | 2.4 KB |
| no-block.c | -rw-r--r-- | 688 bytes |
| open.c | -rw-r--r-- | 23.9 KB |
| pipe.c | -rw-r--r-- | 28.3 KB |
| pnode.c | -rw-r--r-- | 9.3 KB |
| pnode.h | -rw-r--r-- | 1.1 KB |
| posix_acl.c | -rw-r--r-- | 8.4 KB |
| read_write.c | -rw-r--r-- | 20.8 KB |
| read_write.h | -rw-r--r-- | 542 bytes |
| readdir.c | -rw-r--r-- | 6.9 KB |
| select.c | -rw-r--r-- | 24.3 KB |
| seq_file.c | -rw-r--r-- | 17.8 KB |
| signalfd.c | -rw-r--r-- | 7.5 KB |
| splice.c | -rw-r--r-- | 46.5 KB |
| stack.c | -rw-r--r-- | 2.7 KB |
| stat.c | -rw-r--r-- | 10.5 KB |
| statfs.c | -rw-r--r-- | 5.2 KB |
| super.c | -rw-r--r-- | 26.8 KB |
| sync.c | -rw-r--r-- | 9.9 KB |
| timerfd.c | -rw-r--r-- | 6.5 KB |
| utimes.c | -rw-r--r-- | 5.6 KB |
| xattr.c | -rw-r--r-- | 15.6 KB |
| xattr_acl.c | -rw-r--r-- | 2.3 KB |
Computing file changes ...
