Revision 7db37c5e6575b229a5051be1d3ef15257ae0ba5d authored by Dave Chinner on 27 January 2011, 01:02:00 UTC, committed by Dave Chinner on 27 January 2011, 01:02:00 UTC
The kmemleak detector shows this after test 139: unreferenced object 0xffff880079b88bb0 (size 264): comm "xfs_io", pid 4904, jiffies 4294909382 (age 276.824s) hex dump (first 32 bytes): 00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00 .....N.......... ff ff ff ff ff ff ff ff 48 7b c9 82 ff ff ff ff ........H{...... backtrace: [<ffffffff81afb04d>] kmemleak_alloc+0x2d/0x60 [<ffffffff8115c6cf>] kmem_cache_alloc+0x13f/0x2b0 [<ffffffff814aaa97>] kmem_zone_alloc+0x77/0xf0 [<ffffffff814aab2e>] kmem_zone_zalloc+0x1e/0x50 [<ffffffff8148f394>] xlog_ticket_alloc+0x34/0x170 [<ffffffff81494444>] xlog_cil_push+0xa4/0x3f0 [<ffffffff81494eca>] xlog_cil_force_lsn+0x15a/0x160 [<ffffffff814933a5>] _xfs_log_force_lsn+0x75/0x2d0 [<ffffffff814a264d>] _xfs_trans_commit+0x2bd/0x2f0 [<ffffffff8148bfdd>] xfs_iomap_write_allocate+0x1ad/0x350 [<ffffffff814ac17f>] xfs_map_blocks+0x21f/0x370 [<ffffffff814ad1b7>] xfs_vm_writepage+0x1c7/0x550 [<ffffffff8112200a>] __writepage+0x1a/0x50 [<ffffffff81122df2>] write_cache_pages+0x1c2/0x4c0 [<ffffffff81123117>] generic_writepages+0x27/0x30 [<ffffffff814aba5d>] xfs_vm_writepages+0x5d/0x80 By inspection, the leak occurs when xlog_write() returns and error and we jump to the abort path without dropping the reference on the active ticket. Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Alex Elder <aelder@sgi.com>
1 parent c56eb8f
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 1.7 KB |
Makefile | -rw-r--r-- | 380 bytes |
acl.c | -rw-r--r-- | 9.8 KB |
acl.h | -rw-r--r-- | 1.5 KB |
balloc.c | -rw-r--r-- | 44.8 KB |
dir.c | -rw-r--r-- | 17.8 KB |
ext2.h | -rw-r--r-- | 6.1 KB |
file.c | -rw-r--r-- | 2.7 KB |
ialloc.c | -rw-r--r-- | 18.2 KB |
inode.c | -rw-r--r-- | 44.5 KB |
ioctl.c | -rw-r--r-- | 4.3 KB |
namei.c | -rw-r--r-- | 9.7 KB |
super.c | -rw-r--r-- | 40.8 KB |
symlink.c | -rw-r--r-- | 1.3 KB |
xattr.c | -rw-r--r-- | 28.0 KB |
xattr.h | -rw-r--r-- | 3.4 KB |
xattr_security.c | -rw-r--r-- | 1.8 KB |
xattr_trusted.c | -rw-r--r-- | 1.5 KB |
xattr_user.c | -rw-r--r-- | 1.6 KB |
xip.c | -rw-r--r-- | 2.0 KB |
xip.h | -rw-r--r-- | 759 bytes |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...