Revision 7db37c5e6575b229a5051be1d3ef15257ae0ba5d authored by Dave Chinner on 27 January 2011, 01:02:00 UTC, committed by Dave Chinner on 27 January 2011, 01:02:00 UTC
The kmemleak detector shows this after test 139: unreferenced object 0xffff880079b88bb0 (size 264): comm "xfs_io", pid 4904, jiffies 4294909382 (age 276.824s) hex dump (first 32 bytes): 00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00 .....N.......... ff ff ff ff ff ff ff ff 48 7b c9 82 ff ff ff ff ........H{...... backtrace: [<ffffffff81afb04d>] kmemleak_alloc+0x2d/0x60 [<ffffffff8115c6cf>] kmem_cache_alloc+0x13f/0x2b0 [<ffffffff814aaa97>] kmem_zone_alloc+0x77/0xf0 [<ffffffff814aab2e>] kmem_zone_zalloc+0x1e/0x50 [<ffffffff8148f394>] xlog_ticket_alloc+0x34/0x170 [<ffffffff81494444>] xlog_cil_push+0xa4/0x3f0 [<ffffffff81494eca>] xlog_cil_force_lsn+0x15a/0x160 [<ffffffff814933a5>] _xfs_log_force_lsn+0x75/0x2d0 [<ffffffff814a264d>] _xfs_trans_commit+0x2bd/0x2f0 [<ffffffff8148bfdd>] xfs_iomap_write_allocate+0x1ad/0x350 [<ffffffff814ac17f>] xfs_map_blocks+0x21f/0x370 [<ffffffff814ad1b7>] xfs_vm_writepage+0x1c7/0x550 [<ffffffff8112200a>] __writepage+0x1a/0x50 [<ffffffff81122df2>] write_cache_pages+0x1c2/0x4c0 [<ffffffff81123117>] generic_writepages+0x27/0x30 [<ffffffff814aba5d>] xfs_vm_writepages+0x5d/0x80 By inspection, the leak occurs when xlog_write() returns and error and we jump to the abort path without dropping the reference on the active ticket. Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Alex Elder <aelder@sgi.com>
1 parent c56eb8f
File | Mode | Size |
---|---|---|
cluster | ||
dlm | ||
dlmfs | ||
Kconfig | -rw-r--r-- | 2.4 KB |
Makefile | -rw-r--r-- | 1011 bytes |
acl.c | -rw-r--r-- | 11.8 KB |
acl.h | -rw-r--r-- | 1.0 KB |
alloc.c | -rw-r--r-- | 184.1 KB |
alloc.h | -rw-r--r-- | 11.7 KB |
aops.c | -rw-r--r-- | 51.6 KB |
aops.h | -rw-r--r-- | 3.3 KB |
blockcheck.c | -rw-r--r-- | 16.4 KB |
blockcheck.h | -rw-r--r-- | 3.8 KB |
buffer_head_io.c | -rw-r--r-- | 10.8 KB |
buffer_head_io.h | -rw-r--r-- | 2.4 KB |
dcache.c | -rw-r--r-- | 14.6 KB |
dcache.h | -rw-r--r-- | 2.1 KB |
dir.c | -rw-r--r-- | 116.2 KB |
dir.h | -rw-r--r-- | 3.9 KB |
dlmglue.c | -rw-r--r-- | 114.8 KB |
dlmglue.h | -rw-r--r-- | 5.8 KB |
export.c | -rw-r--r-- | 6.4 KB |
export.h | -rw-r--r-- | 1.0 KB |
extent_map.c | -rw-r--r-- | 21.4 KB |
extent_map.h | -rw-r--r-- | 2.7 KB |
file.c | -rw-r--r-- | 65.0 KB |
file.h | -rw-r--r-- | 2.6 KB |
heartbeat.c | -rw-r--r-- | 3.4 KB |
heartbeat.h | -rw-r--r-- | 1.5 KB |
inode.c | -rw-r--r-- | 40.4 KB |
inode.h | -rw-r--r-- | 6.0 KB |
ioctl.c | -rw-r--r-- | 13.0 KB |
ioctl.h | -rw-r--r-- | 330 bytes |
journal.c | -rw-r--r-- | 57.6 KB |
journal.h | -rw-r--r-- | 22.0 KB |
localalloc.c | -rw-r--r-- | 33.9 KB |
localalloc.h | -rw-r--r-- | 2.0 KB |
locks.c | -rw-r--r-- | 3.4 KB |
locks.h | -rw-r--r-- | 1.1 KB |
mmap.c | -rw-r--r-- | 5.0 KB |
mmap.h | -rw-r--r-- | 134 bytes |
namei.c | -rw-r--r-- | 60.1 KB |
namei.h | -rw-r--r-- | 1.5 KB |
ocfs1_fs_compat.h | -rw-r--r-- | 2.9 KB |
ocfs2.h | -rw-r--r-- | 22.7 KB |
ocfs2_fs.h | -rw-r--r-- | 50.6 KB |
ocfs2_ioctl.h | -rw-r--r-- | 4.9 KB |
ocfs2_lockid.h | -rw-r--r-- | 3.2 KB |
ocfs2_lockingver.h | -rw-r--r-- | 959 bytes |
quota.h | -rw-r--r-- | 4.4 KB |
quota_global.c | -rw-r--r-- | 27.1 KB |
quota_local.c | -rw-r--r-- | 35.6 KB |
refcounttree.c | -rw-r--r-- | 114.2 KB |
refcounttree.h | -rw-r--r-- | 3.7 KB |
reservations.c | -rw-r--r-- | 20.6 KB |
reservations.h | -rw-r--r-- | 5.3 KB |
resize.c | -rw-r--r-- | 16.1 KB |
resize.h | -rw-r--r-- | 1.1 KB |
slot_map.c | -rw-r--r-- | 12.3 KB |
slot_map.h | -rw-r--r-- | 1.4 KB |
stack_o2cb.c | -rw-r--r-- | 9.9 KB |
stack_user.c | -rw-r--r-- | 23.2 KB |
stackglue.c | -rw-r--r-- | 16.8 KB |
stackglue.h | -rw-r--r-- | 8.9 KB |
suballoc.c | -rw-r--r-- | 77.1 KB |
suballoc.h | -rw-r--r-- | 7.1 KB |
super.c | -rw-r--r-- | 69.1 KB |
super.h | -rw-r--r-- | 1.7 KB |
symlink.c | -rw-r--r-- | 4.2 KB |
symlink.h | -rw-r--r-- | 1.3 KB |
sysfile.c | -rw-r--r-- | 4.7 KB |
sysfile.h | -rw-r--r-- | 1.1 KB |
uptodate.c | -rw-r--r-- | 17.9 KB |
uptodate.h | -rw-r--r-- | 3.0 KB |
ver.c | -rw-r--r-- | 1.2 KB |
ver.h | -rw-r--r-- | 1000 bytes |
xattr.c | -rw-r--r-- | 194.4 KB |
xattr.h | -rw-r--r-- | 3.5 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...