Revision 7f453c24b95a085fc7bd35d53b33abc4dc5a048b authored by Peter Zijlstra on 21 July 2009, 11:19:40 UTC, committed by Peter Zijlstra on 22 July 2009, 16:05:56 UTC
Anton noted that for inherited counters the counter-id as provided by
PERF_SAMPLE_ID isn't mappable to the id found through PERF_RECORD_ID
because each inherited counter gets its own id.

His suggestion was to always return the parent counter id, since that
is the primary counter id as exposed. However, these inherited
counters have a unique identifier so that events like
PERF_EVENT_PERIOD and PERF_EVENT_THROTTLE can be specific about which
counter gets modified, which is important when trying to normalize the
sample streams.

This patch removes PERF_EVENT_PERIOD in favour of PERF_SAMPLE_PERIOD,
which is more useful anyway, since changing periods became a lot more
common than initially thought -- rendering PERF_EVENT_PERIOD the less
useful solution (also, PERF_SAMPLE_PERIOD reports the more accurate
value, since it reports the value used to trigger the overflow,
whereas PERF_EVENT_PERIOD simply reports the requested period changed,
which might only take effect on the next cycle).

This still leaves us PERF_EVENT_THROTTLE to consider, but since that
_should_ be a rare occurrence, and linking it to a primary id is the
most useful bit to diagnose the problem, we introduce a
PERF_SAMPLE_STREAM_ID, for those few cases where the full
reconstruction is important.

[Does change the ABI a little, but I see no other way out]

Suggested-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1248095846.15751.8781.camel@twins>
1 parent 573402d
History
File Mode Size
lzo
reed_solomon
zlib_deflate
zlib_inflate
.gitignore -rw-r--r-- 51 bytes
Kconfig -rw-r--r-- 4.0 KB
Kconfig.debug -rw-r--r-- 34.9 KB
Kconfig.kgdb -rw-r--r-- 1.8 KB
Kconfig.kmemcheck -rw-r--r-- 2.9 KB
Makefile -rw-r--r-- 3.2 KB
argv_split.c -rw-r--r-- 1.8 KB
atomic64.c -rw-r--r-- 3.8 KB
audit.c -rw-r--r-- 1.2 KB
bcd.c -rw-r--r-- 257 bytes
bitmap.c -rw-r--r-- 30.5 KB
bitrev.c -rw-r--r-- 2.1 KB
bug.c -rw-r--r-- 4.6 KB
bust_spinlocks.c -rw-r--r-- 636 bytes
check_signature.c -rw-r--r-- 599 bytes
checksum.c -rw-r--r-- 4.9 KB
cmdline.c -rw-r--r-- 3.6 KB
cpumask.c -rw-r--r-- 4.5 KB
crc-ccitt.c -rw-r--r-- 3.0 KB
crc-itu-t.c -rw-r--r-- 2.8 KB
crc-t10dif.c -rw-r--r-- 2.9 KB
crc16.c -rw-r--r-- 2.8 KB
crc32.c -rw-r--r-- 14.9 KB
crc32defs.h -rw-r--r-- 1.0 KB
crc7.c -rw-r--r-- 2.3 KB
ctype.c -rw-r--r-- 1.3 KB
debug_locks.c -rw-r--r-- 1.1 KB
debugobjects.c -rw-r--r-- 23.8 KB
dec_and_lock.c -rw-r--r-- 782 bytes
decompress.c -rw-r--r-- 1.1 KB
decompress_bunzip2.c -rw-r--r-- 23.0 KB
decompress_inflate.c -rw-r--r-- 3.5 KB
decompress_unlzma.c -rw-r--r-- 15.2 KB
devres.c -rw-r--r-- 7.7 KB
div64.c -rw-r--r-- 2.3 KB
dma-debug.c -rw-r--r-- 31.2 KB
dump_stack.c -rw-r--r-- 290 bytes
dynamic_debug.c -rw-r--r-- 18.0 KB
extable.c -rw-r--r-- 2.4 KB
fault-inject.c -rw-r--r-- 7.9 KB
find_last_bit.c -rw-r--r-- 1.1 KB
find_next_bit.c -rw-r--r-- 6.4 KB
gcd.c -rw-r--r-- 291 bytes
gen_crc32table.c -rw-r--r-- 1.8 KB
genalloc.c -rw-r--r-- 5.3 KB
halfmd4.c -rw-r--r-- 2.0 KB
hexdump.c -rw-r--r-- 6.1 KB
hweight.c -rw-r--r-- 1.6 KB
idr.c -rw-r--r-- 21.3 KB
inflate.c -rw-r--r-- 38.6 KB
int_sqrt.c -rw-r--r-- 533 bytes
iomap.c -rw-r--r-- 7.4 KB
iomap_copy.c -rw-r--r-- 2.1 KB
iommu-helper.c -rw-r--r-- 2.0 KB
ioremap.c -rw-r--r-- 2.1 KB
irq_regs.c -rw-r--r-- 578 bytes
is_single_threaded.c -rw-r--r-- 1.2 KB
kasprintf.c -rw-r--r-- 680 bytes
kernel_lock.c -rw-r--r-- 2.9 KB
klist.c -rw-r--r-- 9.3 KB
kobject.c -rw-r--r-- 20.8 KB
kobject_uevent.c -rw-r--r-- 8.4 KB
kref.c -rw-r--r-- 1.9 KB
libcrc32c.c -rw-r--r-- 2.1 KB
list_debug.c -rw-r--r-- 1.5 KB
lmb.c -rw-r--r-- 11.4 KB
locking-selftest-hardirq.h -rw-r--r-- 207 bytes
locking-selftest-mutex.h -rw-r--r-- 120 bytes
locking-selftest-rlock-hardirq.h -rw-r--r-- 74 bytes
locking-selftest-rlock-softirq.h -rw-r--r-- 74 bytes
locking-selftest-rlock.h -rw-r--r-- 158 bytes
locking-selftest-rsem.h -rw-r--r-- 163 bytes
locking-selftest-softirq.h -rw-r--r-- 207 bytes
locking-selftest-spin-hardirq.h -rw-r--r-- 73 bytes
locking-selftest-spin-softirq.h -rw-r--r-- 73 bytes
locking-selftest-spin.h -rw-r--r-- 118 bytes
locking-selftest-wlock-hardirq.h -rw-r--r-- 74 bytes
locking-selftest-wlock-softirq.h -rw-r--r-- 74 bytes
locking-selftest-wlock.h -rw-r--r-- 158 bytes
locking-selftest-wsem.h -rw-r--r-- 163 bytes
locking-selftest.c -rw-r--r-- 28.6 KB
nlattr.c -rw-r--r-- 12.2 KB
parser.c -rw-r--r-- 6.0 KB
percpu_counter.c -rw-r--r-- 3.2 KB
plist.c -rw-r--r-- 2.8 KB
prio_heap.c -rw-r--r-- 1.4 KB
prio_tree.c -rw-r--r-- 12.2 KB
proportions.c -rw-r--r-- 9.3 KB
radix-tree.c -rw-r--r-- 31.8 KB
random32.c -rw-r--r-- 3.8 KB
ratelimit.c -rw-r--r-- 1.3 KB
rational.c -rw-r--r-- 1.5 KB
rbtree.c -rw-r--r-- 8.5 KB
reciprocal_div.c -rw-r--r-- 159 bytes
rwsem-spinlock.c -rw-r--r-- 6.8 KB
rwsem.c -rw-r--r-- 6.4 KB
scatterlist.c -rw-r--r-- 11.8 KB
sha1.c -rw-r--r-- 2.4 KB
show_mem.c -rw-r--r-- 1.4 KB
smp_processor_id.c -rw-r--r-- 1.1 KB
sort.c -rw-r--r-- 2.5 KB
spinlock_debug.c -rw-r--r-- 6.8 KB
string.c -rw-r--r-- 13.6 KB
string_helpers.c -rw-r--r-- 1.7 KB
swiotlb.c -rw-r--r-- 25.3 KB
syscall.c -rw-r--r-- 2.4 KB
textsearch.c -rw-r--r-- 9.5 KB
ts_bm.c -rw-r--r-- 5.3 KB
ts_fsm.c -rw-r--r-- 10.6 KB
ts_kmp.c -rw-r--r-- 4.3 KB
vsprintf.c -rw-r--r-- 43.3 KB

back to top