Revision 7f850b889dbd484d7dc082b9adc46a82764a840d authored by Yanqin Jin on 28 June 2018, 03:55:07 UTC, committed by Facebook Github Bot on 28 June 2018, 03:59:45 UTC
Summary: Remove over-alignment on `StatisticsImpl` whose benefit is vague and causes UBSAN check to fail due to `std::make_shared` not respecting the over-alignment requirement. Test plan ``` $ make clean && COMPILE_WITH_UBSAN=1 OPT=-g make -j16 ubsan_check ``` Closes https://github.com/facebook/rocksdb/pull/4061 Differential Revision: D8656506 Pulled By: riversand963 fbshipit-source-id: db355ae9c7bdd2c9e9c5e63cabba13d8d82cc5f9
1 parent 14f409c
| File | Mode | Size |
|---|---|---|
| cf_options.cc | -rw-r--r-- | 8.6 KB |
| cf_options.h | -rw-r--r-- | 8.2 KB |
| db_options.cc | -rw-r--r-- | 13.5 KB |
| db_options.h | -rw-r--r-- | 3.1 KB |
| options.cc | -rw-r--r-- | 23.9 KB |
| options_helper.cc | -rw-r--r-- | 83.5 KB |
| options_helper.h | -rw-r--r-- | 8.3 KB |
| options_parser.cc | -rw-r--r-- | 30.1 KB |
| options_parser.h | -rw-r--r-- | 5.1 KB |
| options_sanity_check.cc | -rw-r--r-- | 1.1 KB |
| options_sanity_check.h | -rw-r--r-- | 1.7 KB |
| options_settable_test.cc | -rw-r--r-- | 20.6 KB |
| options_test.cc | -rw-r--r-- | 74.7 KB |
Computing file changes ...
