Revision 80bc35927c0707c49044a06818e4893468d5fc27 authored by Zhongyi Xie on 16 June 2018, 02:24:21 UTC, committed by Facebook Github Bot on 16 June 2018, 02:26:58 UTC
Summary: The Block object assumes contents are uncompressed. Block's constructor tries to read the number of restarts, but does not get an accurate number when its contents are compressed, which is causing issues like https://github.com/facebook/rocksdb/issues/3843. This PR address this issue by skipping reconstruction of restart points when blocks are known to be compressed. Somehow the restart points can be read directly when Snappy is used and some tests (for example https://github.com/facebook/rocksdb/blob/master/db/db_block_cache_test.cc#L196) expects blocks to be fully constructed even when Snappy compression is used, so here we keep the restart point logic for Snappy. Closes https://github.com/facebook/rocksdb/pull/3996 Differential Revision: D8416186 Pulled By: miasantreble fbshipit-source-id: 002c0b62b9e5d89fb7736563d354ce0023c8cb28
1 parent c48764b
| File | Mode | Size |
|---|---|---|
| README | -rw-r--r-- | 946 bytes |
| env_hdfs.h | -rw-r--r-- | 11.5 KB |
| setup.sh | -rw-r--r-- | 436 bytes |
Computing file changes ...
