Revision 81fcb698e03543d35c93ec6726a830aa6b9c5167 authored by Mathias Rav on 18 January 2018, 13:38:41 UTC, committed by Junio C Hamano on 19 January 2018, 22:16:56 UTC
Running git clone --single-branch --mirror -b TAGNAME previously
triggered the following error message:

	fatal: multiple updates for ref 'refs/tags/TAGNAME' not allowed.

This error condition is handled in files_initial_transaction_commit().

42c7f7ff9 ("commit_packed_refs(): remove call to `packed_refs_unlock()`", 2017-06-23)
introduced incorrect unlocking in the error path of this function,
which changes the error message to

	fatal: BUG: packed_refs_unlock() called when not locked

Move the call to packed_refs_unlock() above the "cleanup:" label
since the unlocking should only be done in the last error path.

Signed-off-by: Mathias Rav <m@git.strova.dk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 3013dff
History
File Mode Size
install-dependencies.sh -rwxr-xr-x 1.2 KB
lib-travisci.sh -rwxr-xr-x 1.1 KB
print-test-failures.sh -rwxr-xr-x 437 bytes
run-build.sh -rwxr-xr-x 68 bytes
run-linux32-build.sh -rwxr-xr-x 875 bytes
run-linux32-docker.sh -rwxr-xr-x 611 bytes
run-static-analysis.sh -rwxr-xr-x 104 bytes
run-tests.sh -rwxr-xr-x 140 bytes
run-windows-build.sh -rwxr-xr-x 2.6 KB
test-documentation.sh -rwxr-xr-x 728 bytes

back to top