Revision 87a927c715789853cc8331d76039a2fd657a832a authored by David Woodhouse on 05 July 2007, 01:26:44 UTC, committed by Linus Torvalds on 05 July 2007, 22:54:13 UTC
Commit b46b8f19c9cd435ecac4d9d12b39d78c137ecd66 fixed a couple of bugs by switching the redzone to 64 bits. Unfortunately, it neglected to ensure that the _second_ redzone, after the slab object, is aligned correctly. This caused illegal instruction faults on sparc32, which for some reason not entirely clear to me are not trapped and fixed up. Two things need to be done to fix this: - increase the object size, rounding up to alignof(long long) so that the second redzone can be aligned correctly. - If SLAB_STORE_USER is set but alignof(long long)==8, allow a full 64 bits of space for the user word at the end of the buffer, even though we may not _use_ the whole 64 bits. This patch should be a no-op on any 64-bit architecture or any 32-bit architecture where alignof(long long) == 4. Of the others, it's tested on ppc32 by myself and a very similar patch was tested on sparc32 by Mark Fortescue, who reported the new problem. Also, fix the conditions for FORCED_DEBUG, which hadn't been adjusted to the new sizes. Again noticed by Mark. Signed-off-by: David Woodhouse <dwmw2@infradead.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 2bcb1b7
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 1.5 KB |
Kconfig.iosched | -rw-r--r-- | 1.9 KB |
Makefile | -rw-r--r-- | 347 bytes |
as-iosched.c | -rw-r--r-- | 37.7 KB |
blktrace.c | -rw-r--r-- | 12.4 KB |
cfq-iosched.c | -rw-r--r-- | 52.6 KB |
deadline-iosched.c | -rw-r--r-- | 11.6 KB |
elevator.c | -rw-r--r-- | 25.0 KB |
genhd.c | -rw-r--r-- | 19.7 KB |
ioctl.c | -rw-r--r-- | 7.4 KB |
ll_rw_blk.c | -rw-r--r-- | 104.7 KB |
noop-iosched.c | -rw-r--r-- | 2.5 KB |
scsi_ioctl.c | -rw-r--r-- | 16.4 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...