https://github.com/Kitware/CMake
Revision 87f44b7525ebc9761b32b98f0c9e1276431e6ec1 authored by Brad King on 17 February 2016, 18:34:15 UTC, committed by Brad King on 17 February 2016, 19:01:11 UTC
In commit v3.5.0-rc1~43^2 (Fix export of STATIC library PRIVATE
dependencies with CMP0022 NEW, 2016-01-15) we taught
target_link_libraries to generate `$<LINK_ONLY:$<TARGET_NAME:dep>>` in
INTERFACE_LINK_LIBRARIES instead of `$<LINK_ONLY:dep>` so that `dep` can
be recognized as a target name and updated during export.  However, this
approach does not work when `dep` is just a plain library name and not a
target because `$<TARGET_NAME:...>` requires the name of a reachable
target.

Since we do not know during target_link_libraries whether the name will
correspond to a reachable target or not, we cannot inject the
`$<TARGET_NAME:...>` expression.  Revert this change and solve the
original problem instead by teaching the export logic to recognize and
update target names directly in `$<LINK_ONLY:...>` expressions.

Reported-by: Ben Boeckel <ben.boeckel@kitware.com>
1 parent a5a5a68
History
Tip revision: 87f44b7525ebc9761b32b98f0c9e1276431e6ec1 authored by Brad King on 17 February 2016, 18:34:15 UTC
Fix export of STATIC library PRIVATE non-target dependencies
Tip revision: 87f44b7
File Mode Size
Auxiliary
Help
Licenses
Modules
Packaging
Source
Templates
Tests
Utilities
.gitattributes -rw-r--r-- 613 bytes
.hooks-config.bash -rw-r--r-- 866 bytes
CMakeCPack.cmake -rw-r--r-- 8.5 KB
CMakeCPackOptions.cmake.in -rw-r--r-- 10.2 KB
CMakeGraphVizOptions.cmake -rw-r--r-- 153 bytes
CMakeLists.txt -rw-r--r-- 26.2 KB
CMakeLogo.gif -rw-r--r-- 4.4 KB
CONTRIBUTING.rst -rw-r--r-- 1005 bytes
CTestConfig.cmake -rw-r--r-- 870 bytes
CTestCustom.cmake.in -rw-r--r-- 5.1 KB
CompileFlags.cmake -rw-r--r-- 3.1 KB
Copyright.txt -rw-r--r-- 2.6 KB
DartConfig.cmake -rw-r--r-- 804 bytes
README.rst -rw-r--r-- 2.9 KB
bootstrap -rwxr-xr-x 45.5 KB
cmake_uninstall.cmake.in -rw-r--r-- 790 bytes
configure -rwxr-xr-x 99 bytes
doxygen.config -rw-r--r-- 27.4 KB

README.rst

back to top