https://github.com/Kitware/CMake
Revision 87f44b7525ebc9761b32b98f0c9e1276431e6ec1 authored by Brad King on 17 February 2016, 18:34:15 UTC, committed by Brad King on 17 February 2016, 19:01:11 UTC
In commit v3.5.0-rc1~43^2 (Fix export of STATIC library PRIVATE dependencies with CMP0022 NEW, 2016-01-15) we taught target_link_libraries to generate `$<LINK_ONLY:$<TARGET_NAME:dep>>` in INTERFACE_LINK_LIBRARIES instead of `$<LINK_ONLY:dep>` so that `dep` can be recognized as a target name and updated during export. However, this approach does not work when `dep` is just a plain library name and not a target because `$<TARGET_NAME:...>` requires the name of a reachable target. Since we do not know during target_link_libraries whether the name will correspond to a reachable target or not, we cannot inject the `$<TARGET_NAME:...>` expression. Revert this change and solve the original problem instead by teaching the export logic to recognize and update target names directly in `$<LINK_ONLY:...>` expressions. Reported-by: Ben Boeckel <ben.boeckel@kitware.com>
1 parent a5a5a68
Tip revision: 87f44b7525ebc9761b32b98f0c9e1276431e6ec1 authored by Brad King on 17 February 2016, 18:34:15 UTC
Fix export of STATIC library PRIVATE non-target dependencies
Fix export of STATIC library PRIVATE non-target dependencies
Tip revision: 87f44b7
| File | Mode | Size |
|---|---|---|
| Windows | ||
| AppleInfo.plist | -rw-r--r-- | 1.2 KB |
| CMakeVSMacros1.vsmacros | -rw-r--r-- | 86.0 KB |
| CMakeVSMacros2.vsmacros | -rw-r--r-- | 62.0 KB |
| CMakeVisualStudio6Configurations.cmake | -rw-r--r-- | 181 bytes |
| CPack.GenericDescription.txt | -rw-r--r-- | 138 bytes |
| CPack.GenericLicense.txt | -rw-r--r-- | 101 bytes |
| CPack.GenericWelcome.txt | -rw-r--r-- | 96 bytes |
| CPackConfig.cmake.in | -rw-r--r-- | 751 bytes |
| CTestScript.cmake.in | -rw-r--r-- | 1.4 KB |
| DLLFooter.dsptemplate | -rw-r--r-- | 116 bytes |
| DLLHeader.dsptemplate | -rw-r--r-- | 7.3 KB |
| EXEFooter.dsptemplate | -rw-r--r-- | 116 bytes |
| EXEHeader.dsptemplate | -rw-r--r-- | 7.0 KB |
| EXEWinHeader.dsptemplate | -rw-r--r-- | 7.1 KB |
| TestDriver.cxx.in | -rw-r--r-- | 3.5 KB |
| UtilityFooter.dsptemplate | -rw-r--r-- | 29 bytes |
| UtilityHeader.dsptemplate | -rw-r--r-- | 2.8 KB |
| cygwin-package.sh.in | -rwxr-xr-x | 2.0 KB |
| staticLibFooter.dsptemplate | -rw-r--r-- | 116 bytes |
| staticLibHeader.dsptemplate | -rw-r--r-- | 6.1 KB |
Computing file changes ...
