Revision 8c7eb59838086b4c368b3d39daa91dcec57ea55e authored by Maysam Yabandeh on 27 April 2019, 00:26:29 UTC, committed by Facebook Github Bot on 27 April 2019, 00:30:30 UTC
Summary: The newly added test CompactionJobTest.SnapshotRefresh sets the snapshot refresh period to 0 to stress the feature. This results into large number of refresh events, which in turn results into an UBSAN failure when a bitwise shift operand goes beyond the uint64_t size. The patch fixes that by simplifying the shift logic to be done only by 2 bits after each refresh. Furthermore it verifies that the shift operation does not result in decreasing the refresh period. Testing: COMPILE_WITH_UBSAN=1 make -j32 compaction_job_test ./compaction_job_test --gtest_filter=CompactionJobTest.SnapshotRefresh Pull Request resolved: https://github.com/facebook/rocksdb/pull/5257 Differential Revision: D15106463 Pulled By: maysamyabandeh fbshipit-source-id: f2718898ea7ba4fa9f7e87b70cf98fe647c0de80
1 parent 506e844
| File | Mode | Size |
|---|---|---|
| RocksDBCommonHelper.php | -rw-r--r-- | 11.8 KB |
| amalgamate.py | -rwxr-xr-x | 4.7 KB |
| build_detect_platform | -rwxr-xr-x | 22.1 KB |
| cont_integration.sh | -rwxr-xr-x | 3.4 KB |
| dependencies.sh | -rw-r--r-- | 2.1 KB |
| dependencies_4.8.1.sh | -rw-r--r-- | 2.2 KB |
| dependencies_platform007.sh | -rw-r--r-- | 2.0 KB |
| dockerbuild.sh | -rwxr-xr-x | 148 bytes |
| error_filter.py | -rw-r--r-- | 6.4 KB |
| fb_compile_mongo.sh | -rwxr-xr-x | 1.5 KB |
| fbcode_config.sh | -rw-r--r-- | 4.6 KB |
| fbcode_config4.8.1.sh | -rw-r--r-- | 3.6 KB |
| fbcode_config_platform007.sh | -rw-r--r-- | 4.6 KB |
| format-diff.sh | -rwxr-xr-x | 3.9 KB |
| gnu_parallel | -rwxr-xr-x | 238.6 KB |
| make_package.sh | -rwxr-xr-x | 3.1 KB |
| precommit_checker.py | -rwxr-xr-x | 5.6 KB |
| regression_build_test.sh | -rwxr-xr-x | 11.3 KB |
| rocksdb-lego-determinator | -rwxr-xr-x | 23.2 KB |
| run_ci_db_test.ps1 | -rw-r--r-- | 14.5 KB |
| setup_centos7.sh | -rwxr-xr-x | 1.1 KB |
| update_dependencies.sh | -rwxr-xr-x | 5.2 KB |
| version.sh | -rwxr-xr-x | 769 bytes |
Computing file changes ...
