Revision 8cf66504210d308a35cca35fe9c310b1241f9fa7 authored by Qian Cai on 11 July 2019, 16:17:45 UTC, committed by Linus Torvalds on 21 July 2019, 16:57:13 UTC
The commit b3aa14f02254 ("iommu: remove the mapping_error dma_map_ops
method") incorrectly changed the checking from dma_ops_alloc_iova() in
map_sg() causes a crash under memory pressure as dma_ops_alloc_iova()
never return DMA_MAPPING_ERROR on failure but 0, so the error handling
is all wrong.
kernel BUG at drivers/iommu/iova.c:801!
Workqueue: kblockd blk_mq_run_work_fn
RIP: 0010:iova_magazine_free_pfns+0x7d/0xc0
Call Trace:
free_cpu_cached_iovas+0xbd/0x150
alloc_iova_fast+0x8c/0xba
dma_ops_alloc_iova.isra.6+0x65/0xa0
map_sg+0x8c/0x2a0
scsi_dma_map+0xc6/0x160
pqi_aio_submit_io+0x1f6/0x440 [smartpqi]
pqi_scsi_queue_command+0x90c/0xdd0 [smartpqi]
scsi_queue_rq+0x79c/0x1200
blk_mq_dispatch_rq_list+0x4dc/0xb70
blk_mq_sched_dispatch_requests+0x249/0x310
__blk_mq_run_hw_queue+0x128/0x200
blk_mq_run_work_fn+0x27/0x30
process_one_work+0x522/0xa10
worker_thread+0x63/0x5b0
kthread+0x1d2/0x1f0
ret_from_fork+0x22/0x40
Fixes: b3aa14f02254 ("iommu: remove the mapping_error dma_map_ops method")
Signed-off-by: Qian Cai <cai@lca.pw>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 618381f
| File | Mode | Size |
|---|---|---|
| 9p | ||
| adfs | ||
| affs | ||
| afs | ||
| autofs | ||
| befs | ||
| bfs | ||
| btrfs | ||
| cachefiles | ||
| ceph | ||
| cifs | ||
| coda | ||
| configfs | ||
| cramfs | ||
| crypto | ||
| debugfs | ||
| devpts | ||
| dlm | ||
| ecryptfs | ||
| efivarfs | ||
| efs | ||
| exportfs | ||
| ext2 | ||
| ext4 | ||
| f2fs | ||
| fat | ||
| freevxfs | ||
| fscache | ||
| fuse | ||
| gfs2 | ||
| hfs | ||
| hfsplus | ||
| hostfs | ||
| hpfs | ||
| hugetlbfs | ||
| iomap | ||
| isofs | ||
| jbd2 | ||
| jffs2 | ||
| jfs | ||
| kernfs | ||
| lockd | ||
| minix | ||
| nfs | ||
| nfs_common | ||
| nfsd | ||
| nilfs2 | ||
| nls | ||
| notify | ||
| ntfs | ||
| ocfs2 | ||
| omfs | ||
| openpromfs | ||
| orangefs | ||
| overlayfs | ||
| proc | ||
| pstore | ||
| qnx4 | ||
| qnx6 | ||
| quota | ||
| ramfs | ||
| reiserfs | ||
| romfs | ||
| squashfs | ||
| sysfs | ||
| sysv | ||
| tracefs | ||
| ubifs | ||
| udf | ||
| ufs | ||
| unicode | ||
| xfs | ||
| Kconfig | -rw-r--r-- | 7.6 KB |
| Kconfig.binfmt | -rw-r--r-- | 7.6 KB |
| Makefile | -rw-r--r-- | 4.3 KB |
| aio.c | -rw-r--r-- | 56.0 KB |
| anon_inodes.c | -rw-r--r-- | 4.6 KB |
| attr.c | -rw-r--r-- | 9.7 KB |
| bad_inode.c | -rw-r--r-- | 5.3 KB |
| binfmt_aout.c | -rw-r--r-- | 8.3 KB |
| binfmt_elf.c | -rw-r--r-- | 63.7 KB |
| binfmt_elf_fdpic.c | -rw-r--r-- | 47.1 KB |
| binfmt_em86.c | -rw-r--r-- | 2.8 KB |
| binfmt_flat.c | -rw-r--r-- | 28.0 KB |
| binfmt_misc.c | -rw-r--r-- | 18.5 KB |
| binfmt_script.c | -rw-r--r-- | 4.4 KB |
| block_dev.c | -rw-r--r-- | 54.5 KB |
| buffer.c | -rw-r--r-- | 90.2 KB |
| char_dev.c | -rw-r--r-- | 16.5 KB |
| compat.c | -rw-r--r-- | 3.2 KB |
| compat_binfmt_elf.c | -rw-r--r-- | 3.2 KB |
| compat_ioctl.c | -rw-r--r-- | 31.0 KB |
| coredump.c | -rw-r--r-- | 21.2 KB |
| d_path.c | -rw-r--r-- | 11.2 KB |
| dax.c | -rw-r--r-- | 45.8 KB |
| dcache.c | -rw-r--r-- | 83.9 KB |
| dcookies.c | -rw-r--r-- | 7.1 KB |
| direct-io.c | -rw-r--r-- | 40.8 KB |
| drop_caches.c | -rw-r--r-- | 1.8 KB |
| eventfd.c | -rw-r--r-- | 11.1 KB |
| eventpoll.c | -rw-r--r-- | 64.5 KB |
| exec.c | -rw-r--r-- | 46.9 KB |
| fcntl.c | -rw-r--r-- | 23.3 KB |
| fhandle.c | -rw-r--r-- | 6.8 KB |
| file.c | -rw-r--r-- | 24.2 KB |
| file_table.c | -rw-r--r-- | 10.2 KB |
| filesystems.c | -rw-r--r-- | 6.4 KB |
| fs-writeback.c | -rw-r--r-- | 72.1 KB |
| fs_context.c | -rw-r--r-- | 18.5 KB |
| fs_parser.c | -rw-r--r-- | 10.8 KB |
| fs_pin.c | -rw-r--r-- | 1.9 KB |
| fs_struct.c | -rw-r--r-- | 3.3 KB |
| fs_types.c | -rw-r--r-- | 2.5 KB |
| fsopen.c | -rw-r--r-- | 11.2 KB |
| inode.c | -rw-r--r-- | 59.7 KB |
| internal.h | -rw-r--r-- | 5.1 KB |
| io_uring.c | -rw-r--r-- | 81.6 KB |
| ioctl.c | -rw-r--r-- | 17.7 KB |
| libfs.c | -rw-r--r-- | 32.7 KB |
| locks.c | -rw-r--r-- | 77.5 KB |
| mbcache.c | -rw-r--r-- | 12.0 KB |
| mount.h | -rw-r--r-- | 4.0 KB |
| mpage.c | -rw-r--r-- | 21.1 KB |
| namei.c | -rw-r--r-- | 123.0 KB |
| namespace.c | -rw-r--r-- | 96.0 KB |
| no-block.c | -rw-r--r-- | 478 bytes |
| nsfs.c | -rw-r--r-- | 6.1 KB |
| open.c | -rw-r--r-- | 29.3 KB |
| pipe.c | -rw-r--r-- | 27.7 KB |
| pnode.c | -rw-r--r-- | 15.1 KB |
| pnode.h | -rw-r--r-- | 1.9 KB |
| posix_acl.c | -rw-r--r-- | 21.5 KB |
| proc_namespace.c | -rw-r--r-- | 7.8 KB |
| read_write.c | -rw-r--r-- | 50.7 KB |
| readdir.c | -rw-r--r-- | 11.3 KB |
| select.c | -rw-r--r-- | 34.2 KB |
| seq_file.c | -rw-r--r-- | 24.7 KB |
| signalfd.c | -rw-r--r-- | 9.0 KB |
| splice.c | -rw-r--r-- | 40.2 KB |
| stack.c | -rw-r--r-- | 2.5 KB |
| stat.c | -rw-r--r-- | 19.4 KB |
| statfs.c | -rw-r--r-- | 9.9 KB |
| super.c | -rw-r--r-- | 44.8 KB |
| sync.c | -rw-r--r-- | 10.4 KB |
| timerfd.c | -rw-r--r-- | 13.4 KB |
| userfaultfd.c | -rw-r--r-- | 51.1 KB |
| utimes.c | -rw-r--r-- | 7.4 KB |
| xattr.c | -rw-r--r-- | 23.5 KB |
Computing file changes ...
