Revision 8cf66504210d308a35cca35fe9c310b1241f9fa7 authored by Qian Cai on 11 July 2019, 16:17:45 UTC, committed by Linus Torvalds on 21 July 2019, 16:57:13 UTC
The commit b3aa14f02254 ("iommu: remove the mapping_error dma_map_ops method") incorrectly changed the checking from dma_ops_alloc_iova() in map_sg() causes a crash under memory pressure as dma_ops_alloc_iova() never return DMA_MAPPING_ERROR on failure but 0, so the error handling is all wrong. kernel BUG at drivers/iommu/iova.c:801! Workqueue: kblockd blk_mq_run_work_fn RIP: 0010:iova_magazine_free_pfns+0x7d/0xc0 Call Trace: free_cpu_cached_iovas+0xbd/0x150 alloc_iova_fast+0x8c/0xba dma_ops_alloc_iova.isra.6+0x65/0xa0 map_sg+0x8c/0x2a0 scsi_dma_map+0xc6/0x160 pqi_aio_submit_io+0x1f6/0x440 [smartpqi] pqi_scsi_queue_command+0x90c/0xdd0 [smartpqi] scsi_queue_rq+0x79c/0x1200 blk_mq_dispatch_rq_list+0x4dc/0xb70 blk_mq_sched_dispatch_requests+0x249/0x310 __blk_mq_run_hw_queue+0x128/0x200 blk_mq_run_work_fn+0x27/0x30 process_one_work+0x522/0xa10 worker_thread+0x63/0x5b0 kthread+0x1d2/0x1f0 ret_from_fork+0x22/0x40 Fixes: b3aa14f02254 ("iommu: remove the mapping_error dma_map_ops method") Signed-off-by: Qian Cai <cai@lca.pw> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 618381f
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 2.8 KB |
Makefile | -rw-r--r-- | 402 bytes |
acl.c | -rw-r--r-- | 8.9 KB |
acl.h | -rw-r--r-- | 1.0 KB |
checkpoint.c | -rw-r--r-- | 40.7 KB |
data.c | -rw-r--r-- | 74.4 KB |
debug.c | -rw-r--r-- | 18.5 KB |
dir.c | -rw-r--r-- | 22.8 KB |
extent_cache.c | -rw-r--r-- | 19.7 KB |
f2fs.h | -rw-r--r-- | 115.8 KB |
file.c | -rw-r--r-- | 76.7 KB |
gc.c | -rw-r--r-- | 37.9 KB |
gc.h | -rw-r--r-- | 2.9 KB |
hash.c | -rw-r--r-- | 2.0 KB |
inline.c | -rw-r--r-- | 17.2 KB |
inode.c | -rw-r--r-- | 21.6 KB |
namei.c | -rw-r--r-- | 28.9 KB |
node.c | -rw-r--r-- | 75.3 KB |
node.h | -rw-r--r-- | 12.2 KB |
recovery.c | -rw-r--r-- | 19.2 KB |
segment.c | -rw-r--r-- | 115.9 KB |
segment.h | -rw-r--r-- | 25.9 KB |
shrinker.c | -rw-r--r-- | 3.1 KB |
super.c | -rw-r--r-- | 93.5 KB |
sysfs.c | -rw-r--r-- | 20.8 KB |
trace.c | -rw-r--r-- | 3.4 KB |
trace.h | -rw-r--r-- | 859 bytes |
xattr.c | -rw-r--r-- | 18.3 KB |
xattr.h | -rw-r--r-- | 4.9 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...