Revision 8cf66504210d308a35cca35fe9c310b1241f9fa7 authored by Qian Cai on 11 July 2019, 16:17:45 UTC, committed by Linus Torvalds on 21 July 2019, 16:57:13 UTC
The commit b3aa14f02254 ("iommu: remove the mapping_error dma_map_ops method") incorrectly changed the checking from dma_ops_alloc_iova() in map_sg() causes a crash under memory pressure as dma_ops_alloc_iova() never return DMA_MAPPING_ERROR on failure but 0, so the error handling is all wrong. kernel BUG at drivers/iommu/iova.c:801! Workqueue: kblockd blk_mq_run_work_fn RIP: 0010:iova_magazine_free_pfns+0x7d/0xc0 Call Trace: free_cpu_cached_iovas+0xbd/0x150 alloc_iova_fast+0x8c/0xba dma_ops_alloc_iova.isra.6+0x65/0xa0 map_sg+0x8c/0x2a0 scsi_dma_map+0xc6/0x160 pqi_aio_submit_io+0x1f6/0x440 [smartpqi] pqi_scsi_queue_command+0x90c/0xdd0 [smartpqi] scsi_queue_rq+0x79c/0x1200 blk_mq_dispatch_rq_list+0x4dc/0xb70 blk_mq_sched_dispatch_requests+0x249/0x310 __blk_mq_run_hw_queue+0x128/0x200 blk_mq_run_work_fn+0x27/0x30 process_one_work+0x522/0xa10 worker_thread+0x63/0x5b0 kthread+0x1d2/0x1f0 ret_from_fork+0x22/0x40 Fixes: b3aa14f02254 ("iommu: remove the mapping_error dma_map_ops method") Signed-off-by: Qian Cai <cai@lca.pw> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 618381f
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 3.2 KB |
Makefile | -rw-r--r-- | 701 bytes |
README | -rw-r--r-- | 7.9 KB |
acl.h | -rw-r--r-- | 1.8 KB |
bitmap.c | -rw-r--r-- | 39.6 KB |
dir.c | -rw-r--r-- | 9.0 KB |
do_balan.c | -rw-r--r-- | 54.3 KB |
file.c | -rw-r--r-- | 7.5 KB |
fix_node.c | -rw-r--r-- | 77.4 KB |
hashes.c | -rw-r--r-- | 3.5 KB |
ibalance.c | -rw-r--r-- | 34.3 KB |
inode.c | -rw-r--r-- | 92.3 KB |
ioctl.c | -rw-r--r-- | 5.3 KB |
item_ops.c | -rw-r--r-- | 18.1 KB |
journal.c | -rw-r--r-- | 120.4 KB |
lbalance.c | -rw-r--r-- | 41.3 KB |
lock.c | -rw-r--r-- | 2.6 KB |
namei.c | -rw-r--r-- | 43.8 KB |
objectid.c | -rw-r--r-- | 6.8 KB |
prints.c | -rw-r--r-- | 21.4 KB |
procfs.c | -rw-r--r-- | 13.2 KB |
reiserfs.h | -rw-r--r-- | 116.6 KB |
resize.c | -rw-r--r-- | 6.3 KB |
stree.c | -rw-r--r-- | 64.0 KB |
super.c | -rw-r--r-- | 69.8 KB |
tail_conversion.c | -rw-r--r-- | 9.2 KB |
xattr.c | -rw-r--r-- | 24.8 KB |
xattr.h | -rw-r--r-- | 3.7 KB |
xattr_acl.c | -rw-r--r-- | 9.6 KB |
xattr_security.c | -rw-r--r-- | 2.7 KB |
xattr_trusted.c | -rw-r--r-- | 1.2 KB |
xattr_user.c | -rw-r--r-- | 1.1 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...