Revision 8e12638f3d0d91791cf06253493b8b15827f4b6c authored by sdong on 19 August 2019, 17:50:25 UTC, committed by Facebook Github Bot on 19 August 2019, 17:51:59 UTC
Summary: Atomic white box test's kill odd is the same as normal test. However, in the scenario that only WritableFileWriter::Append() is blacklisted, WritableFileWriter::Flush() dominates the killing odds. Normally, most of WritableFileWriter::Flush() are called in WAL writes, where every write triggers a WAL flush. In atomic test, WAL is disabled, so the kill happens less frequently than we antipated. In some rare cases, the kill didn't end up with happening (for reasons I still don't fully understand) and cause the stress test timeout. If WAL is disabled, make the odds 5x likely to trigger. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5717 Test Plan: Run whitebox_crash_test_with_atomic_flush and whitebox_crash_test and observe the kill odds printed out. Differential Revision: D16897237 fbshipit-source-id: cbf5d96f6fc0e980523d0f1f94bf4e72cdb82d1c
1 parent e1c468d
| File | Mode | Size |
|---|---|---|
| cf_options.cc | -rw-r--r-- | 10.4 KB |
| cf_options.h | -rw-r--r-- | 8.9 KB |
| db_options.cc | -rw-r--r-- | 15.0 KB |
| db_options.h | -rw-r--r-- | 3.3 KB |
| options.cc | -rw-r--r-- | 25.5 KB |
| options_helper.cc | -rw-r--r-- | 91.3 KB |
| options_helper.h | -rw-r--r-- | 9.0 KB |
| options_parser.cc | -rw-r--r-- | 29.9 KB |
| options_parser.h | -rw-r--r-- | 5.1 KB |
| options_sanity_check.cc | -rw-r--r-- | 1.1 KB |
| options_sanity_check.h | -rw-r--r-- | 1.7 KB |
| options_settable_test.cc | -rw-r--r-- | 21.4 KB |
| options_test.cc | -rw-r--r-- | 77.9 KB |
Computing file changes ...
