Revision 8e12638f3d0d91791cf06253493b8b15827f4b6c authored by sdong on 19 August 2019, 17:50:25 UTC, committed by Facebook Github Bot on 19 August 2019, 17:51:59 UTC
Summary: Atomic white box test's kill odd is the same as normal test. However, in the scenario that only WritableFileWriter::Append() is blacklisted, WritableFileWriter::Flush() dominates the killing odds. Normally, most of WritableFileWriter::Flush() are called in WAL writes, where every write triggers a WAL flush. In atomic test, WAL is disabled, so the kill happens less frequently than we antipated. In some rare cases, the kill didn't end up with happening (for reasons I still don't fully understand) and cause the stress test timeout. If WAL is disabled, make the odds 5x likely to trigger. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5717 Test Plan: Run whitebox_crash_test_with_atomic_flush and whitebox_crash_test and observe the kill odds printed out. Differential Revision: D16897237 fbshipit-source-id: cbf5d96f6fc0e980523d0f1f94bf4e72cdb82d1c
1 parent e1c468d
File | Mode | Size |
---|---|---|
backupable | ||
blob_db | ||
cassandra | ||
checkpoint | ||
compaction_filters | ||
convenience | ||
leveldb_options | ||
memory | ||
merge_operators | ||
option_change_migration | ||
options | ||
persistent_cache | ||
simulator_cache | ||
table_properties_collectors | ||
trace | ||
transactions | ||
ttl | ||
write_batch_with_index | ||
debug.cc | -rw-r--r-- | 2.6 KB |
env_librados.cc | -rw-r--r-- | 36.3 KB |
env_librados.md | -rw-r--r-- | 4.6 KB |
env_librados_test.cc | -rw-r--r-- | 34.6 KB |
env_mirror.cc | -rw-r--r-- | 7.9 KB |
env_mirror_test.cc | -rw-r--r-- | 7.1 KB |
env_timed.cc | -rw-r--r-- | 5.1 KB |
env_timed_test.cc | -rw-r--r-- | 1.2 KB |
merge_operators.h | -rw-r--r-- | 2.0 KB |
object_registry.cc | -rw-r--r-- | 2.8 KB |
object_registry_test.cc | -rw-r--r-- | 5.8 KB |
util_merge_operators_test.cc | -rw-r--r-- | 3.3 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...