Revision 8e13c351acb8087f5a101d70bd7f9f9aebbdc1bc authored by JoostK on 21 September 2021, 21:39:11 UTC, committed by Jessica Janiuk on 26 October 2021, 18:22:33 UTC
The `ErrorCode` enum in the `error_code.ts` file is governed by public api guards but the other top-level exports from that file are exempt from public api documentation and are therefore marked as `@internal`. However, TypeScript is configured with the `stripInternal` compiler option such that declarations with `@internal` markers are not emitted into the `.d.ts` files, but this means that the reexports in the barrel file end up referring to missing declarations. The `stripInternal` option is considered internal and its documentation states to use at your own risk (as per https://github.com/microsoft/TypeScript/issues/45307). Having the option enabled is desirable for us as it works well for hiding class fields that are marked `@internal`, which is an effective way to hide members from the .d.ts file. As a workaround for the issue with top-level symbols, the declarations with `@internal` markers are moved to dedicated files for which no public api guard is setup, therefore allowing their `@internal` markers to be dropped. Fixes #43097 PR Close #43527
1 parent 59e56e7
File | Mode | Size |
---|---|---|
animations | ||
bazel | ||
benchpress | ||
common | ||
compiler | ||
compiler-cli | ||
core | ||
docs | ||
elements | ||
examples | ||
forms | ||
language-service | ||
localize | ||
misc | ||
platform-browser | ||
platform-browser-dynamic | ||
platform-server | ||
private | ||
router | ||
service-worker | ||
upgrade | ||
zone.js | ||
BUILD.bazel | -rw-r--r-- | 673 bytes |
README.md | -rw-r--r-- | 291 bytes |
circular-deps-test.conf.js | -rw-r--r-- | 867 bytes |
empty.ts | -rw-r--r-- | 388 bytes |
goog.d.ts | -rw-r--r-- | 659 bytes |
license-banner.txt | -rw-r--r-- | 112 bytes |
system.d.ts | -rw-r--r-- | 263 bytes |
tsconfig-build.json | -rw-r--r-- | 1.3 KB |
tsconfig-legacy-saucelabs.json | -rw-r--r-- | 583 bytes |
tsconfig-test.json | -rw-r--r-- | 366 bytes |
tsconfig-tsec-base.json | -rw-r--r-- | 264 bytes |
tsconfig.json | -rw-r--r-- | 1.9 KB |
tsec-exemption.json | -rw-r--r-- | 1.1 KB |
types.d.ts | -rw-r--r-- | 1.2 KB |
Computing file changes ...