Revision 8e13c351acb8087f5a101d70bd7f9f9aebbdc1bc authored by JoostK on 21 September 2021, 21:39:11 UTC, committed by Jessica Janiuk on 26 October 2021, 18:22:33 UTC
The `ErrorCode` enum in the `error_code.ts` file is governed by public api guards but the other top-level exports from that file are exempt from public api documentation and are therefore marked as `@internal`. However, TypeScript is configured with the `stripInternal` compiler option such that declarations with `@internal` markers are not emitted into the `.d.ts` files, but this means that the reexports in the barrel file end up referring to missing declarations. The `stripInternal` option is considered internal and its documentation states to use at your own risk (as per https://github.com/microsoft/TypeScript/issues/45307). Having the option enabled is desirable for us as it works well for hiding class fields that are marked `@internal`, which is an effective way to hide members from the .d.ts file. As a workaround for the issue with top-level symbols, the declarations with `@internal` markers are moved to dedicated files for which no public api guard is setup, therefore allowing their `@internal` markers to be dropped. Fixes #43097 PR Close #43527
1 parent 59e56e7
File | Mode | Size |
---|---|---|
build | ||
circular_dependency_test | ||
contributing-stats | ||
gulp-tasks | ||
npm | ||
npm_integration_test | ||
rxjs | ||
saucelabs | ||
size-tracking | ||
source-map-test | ||
symbol-extractor | ||
testing | ||
tslint | ||
BUILD.bazel | -rw-r--r-- | 891 bytes |
defaults.bzl | -rw-r--r-- | 24.5 KB |
extract_typings_rule.bzl | -rw-r--r-- | 955 bytes |
inline-package-json-deps.js | -rw-r--r-- | 2.7 KB |
jasmine-seed-generator.js | -rw-r--r-- | 567 bytes |
jsconfig.json | -rw-r--r-- | 78 bytes |
ng_benchmark.bzl | -rw-r--r-- | 1.1 KB |
postinstall-patches.js | -rw-r--r-- | 4.3 KB |
tsconfig-test.json | -rw-r--r-- | 114 bytes |
tsconfig.json | -rw-r--r-- | 726 bytes |
tsec.bzl | -rw-r--r-- | 5.3 KB |
types.d.ts | -rw-r--r-- | 385 bytes |
utils.bzl | -rw-r--r-- | 1.2 KB |
utils.inc | -rw-r--r-- | 7.1 KB |
Computing file changes ...