Revision 8f1ef70886a1443ccd9980448031c88a44c3faea authored by Ben Pastene on 13 April 2018, 17:03:33 UTC, committed by Chromium WPT Sync on 13 April 2018, 17:03:33 UTC
This reverts commit 7c3d1d13f940e88ef6706fd8b5c257a81d340ed9.

Reason for revert: WebviewLoginTest.Basic is still flaky on linux-chromeos-rel
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6886
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6887

Original change's description:
> Reland: Use PostTask to schedule cross-process postMessage forwarding.
>
> Changes from original attempt at https://crrev.com/c/999182:
> - fix flakiness in two additional ChromeOS login tests
> - fix CSP WPT tests to not depend on ordering between iframe's onload
>   and postMessage - see https://crbug.com/832319.
>
> Previously, we sent the IPC to forward a cross-process postMessage
> immediately.  This caused a behavioral difference from the
> same-process case where the postMessage is always scheduled.  Namely,
> in a scenario like this:
>
>   frame.postMessage(...);
>   doSomethingThatSendsIPCsToFrame(frame);
>
> the IPCs from JS following the postMessage would've been ordered
> incorrectly, causing |frame| to see their side effects after the
> postMessage dispatch in the cross-process case, whereas they would be
> seen before the postMessage dispatch in the same-process case.  One
> example of this is frame.focus(), and another is a frame element
> onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after
> a postMessage dispatched from an inline script while the frame was
> still loading.
>
> To resolve these ordering concerns, this CL changes cross-process
> postMessage to do a PostTask on the sender side before sending the
> message to the browser process.  This improves the current state of
> the world, but does not yet achieve a perfect match for the IPC
> ordering in the same-process case - see discussion on the bug.
>
> Bug: 828529
> Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07
> Reviewed-on: https://chromium-review.googlesource.com/999182
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#550284}
> Reviewed-on: https://chromium-review.googlesource.com/1011287
> Cr-Commit-Position: refs/heads/master@{#550621}

TBR=xiyuan@chromium.org,dcheng@chromium.org,alexmos@chromium.org

Change-Id: Ic0637a6038bed6e5334a26e1934bee81faad3b9e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 828529
Reviewed-on: https://chromium-review.googlesource.com/1012138
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550649}
1 parent 1e5a5fe
History
File Mode Size
cache-storage
service-worker
tools
OWNERS -rw-r--r-- 58 bytes
specgen.json -rw-r--r-- 25.1 KB
stub-3.1-service-worker-obj.html -rw-r--r-- 1.9 KB
stub-3.1.1-service-worker-scope.html -rw-r--r-- 1.3 KB
stub-3.1.2-service-worker-url.html -rw-r--r-- 1.1 KB
stub-3.1.3-service-worker-state.html -rw-r--r-- 2.8 KB
stub-3.1.4-service-worker-on-state-change.html -rw-r--r-- 886 bytes
stub-3.2-navigator-service-worker.html -rw-r--r-- 2.9 KB
stub-3.2.1-navigator-service-worker-installing.html -rw-r--r-- 1.2 KB
stub-3.2.10-navigator-service-worker-oncontrollerchange.html -rw-r--r-- 1.4 KB
stub-3.2.11-navigator-service-worker-onreloadpage.html -rw-r--r-- 1.2 KB
stub-3.2.12-navigator-service-worker-onerror.html -rw-r--r-- 954 bytes
stub-3.2.2-navigator-service-worker-waiting.html -rw-r--r-- 848 bytes
stub-3.2.3-navigator-service-worker-active.html -rw-r--r-- 1.1 KB
stub-3.2.4-navigator-service-worker-controller.html -rw-r--r-- 995 bytes
stub-3.2.5-navigator-service-worker-ready.html -rw-r--r-- 2.2 KB
stub-3.2.6-navigator-service-worker-getAll.html -rw-r--r-- 699 bytes
stub-3.2.7-navigator-service-worker-register.html -rw-r--r-- 697 bytes
stub-3.2.8-navigator-service-worker-unregister.html -rw-r--r-- 681 bytes
stub-3.2.9-navigator-service-worker-onupdatefound.html -rw-r--r-- 1.2 KB
stub-4.1-service-worker-global-scope.html -rw-r--r-- 2.5 KB
stub-4.1.1-service-worker-global-scope-caches.html -rw-r--r-- 933 bytes
stub-4.1.2-service-worker-global-scope-clients.html -rw-r--r-- 785 bytes
stub-4.1.3-service-worker-global-scope-scope.html -rw-r--r-- 938 bytes
stub-4.1.4-service-worker-global-scope-fetch.html -rw-r--r-- 1.5 KB
stub-4.1.5-service-worker-global-scope-update.html -rw-r--r-- 982 bytes
stub-4.1.6-service-worker-global-scope-unregister.html -rw-r--r-- 676 bytes
stub-4.1.7-service-worker-global-scope-onmessage.html -rw-r--r-- 1.3 KB
stub-4.2-client.html -rw-r--r-- 1.9 KB
stub-4.3-service-worker-clients.html -rw-r--r-- 1.4 KB
stub-4.3.1-get-serviced-method.html -rw-r--r-- 777 bytes
stub-4.3.2-reloadall-method.html -rw-r--r-- 997 bytes
stub-4.4-request-objects.html -rw-r--r-- 2.0 KB
stub-4.5-response-objects.html -rw-r--r-- 2.2 KB
stub-4.5.2-response.html -rw-r--r-- 1017 bytes
stub-4.5.4-opaque-response.html -rw-r--r-- 942 bytes
stub-4.6-cache-objects.html -rw-r--r-- 1.0 KB
stub-4.6.1-cache-lifetimes.html -rw-r--r-- 1.2 KB
stub-4.6.2-cache.html -rw-r--r-- 2.1 KB
stub-4.6.3-cache-storage.html -rw-r--r-- 2.0 KB
stub-4.7.1-install-phase-event.html -rw-r--r-- 1.5 KB
stub-4.7.1.1-wait-until-method.html -rw-r--r-- 1.2 KB
stub-4.7.2-install-event.html -rw-r--r-- 832 bytes
stub-4.7.2.1-install-event-section.html -rw-r--r-- 1.3 KB
stub-4.7.2.2-replace-method.html -rw-r--r-- 921 bytes
stub-4.7.3-activate-event.html -rw-r--r-- 959 bytes
stub-4.7.4.1-fetch-event-section.html -rw-r--r-- 1.8 KB
stub-4.7.4.2-respond-with-method.html -rw-r--r-- 1.3 KB
stub-4.7.4.3-default-method.html -rw-r--r-- 1.3 KB
stub-4.7.4.4-is-reload-attribute.html -rw-r--r-- 824 bytes
stub-5.1-origin-relativity.html -rw-r--r-- 970 bytes
stub-5.2-cross-origin-resources.html -rw-r--r-- 1.7 KB

back to top