Revision 8f1ef70886a1443ccd9980448031c88a44c3faea authored by Ben Pastene on 13 April 2018, 17:03:33 UTC, committed by Chromium WPT Sync on 13 April 2018, 17:03:33 UTC
This reverts commit 7c3d1d13f940e88ef6706fd8b5c257a81d340ed9.

Reason for revert: WebviewLoginTest.Basic is still flaky on linux-chromeos-rel
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6886
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6887

Original change's description:
> Reland: Use PostTask to schedule cross-process postMessage forwarding.
>
> Changes from original attempt at https://crrev.com/c/999182:
> - fix flakiness in two additional ChromeOS login tests
> - fix CSP WPT tests to not depend on ordering between iframe's onload
>   and postMessage - see https://crbug.com/832319.
>
> Previously, we sent the IPC to forward a cross-process postMessage
> immediately.  This caused a behavioral difference from the
> same-process case where the postMessage is always scheduled.  Namely,
> in a scenario like this:
>
>   frame.postMessage(...);
>   doSomethingThatSendsIPCsToFrame(frame);
>
> the IPCs from JS following the postMessage would've been ordered
> incorrectly, causing |frame| to see their side effects after the
> postMessage dispatch in the cross-process case, whereas they would be
> seen before the postMessage dispatch in the same-process case.  One
> example of this is frame.focus(), and another is a frame element
> onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after
> a postMessage dispatched from an inline script while the frame was
> still loading.
>
> To resolve these ordering concerns, this CL changes cross-process
> postMessage to do a PostTask on the sender side before sending the
> message to the browser process.  This improves the current state of
> the world, but does not yet achieve a perfect match for the IPC
> ordering in the same-process case - see discussion on the bug.
>
> Bug: 828529
> Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07
> Reviewed-on: https://chromium-review.googlesource.com/999182
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#550284}
> Reviewed-on: https://chromium-review.googlesource.com/1011287
> Cr-Commit-Position: refs/heads/master@{#550621}

TBR=xiyuan@chromium.org,dcheng@chromium.org,alexmos@chromium.org

Change-Id: Ic0637a6038bed6e5334a26e1934bee81faad3b9e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 828529
Reviewed-on: https://chromium-review.googlesource.com/1012138
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550649}
1 parent 1e5a5fe
History
File Mode Size
coverage
tools
OWNERS -rw-r--r-- 93 bytes
RTCCertificate.html -rw-r--r-- 10.5 KB
RTCConfiguration-bundlePolicy.html -rw-r--r-- 4.7 KB
RTCConfiguration-helper.js -rw-r--r-- 890 bytes
RTCConfiguration-iceCandidatePoolSize.html -rw-r--r-- 3.6 KB
RTCConfiguration-iceServers.html -rw-r--r-- 17.7 KB
RTCConfiguration-iceTransportPolicy.html -rw-r--r-- 4.7 KB
RTCConfiguration-rtcpMuxPolicy.html -rw-r--r-- 4.6 KB
RTCDTMFSender-helper.js -rw-r--r-- 4.9 KB
RTCDTMFSender-insertDTMF.https.html -rw-r--r-- 5.8 KB
RTCDTMFSender-ontonechange-long.https.html -rw-r--r-- 1.6 KB
RTCDTMFSender-ontonechange.https.html -rw-r--r-- 9.8 KB
RTCDataChannel-bufferedAmount.html -rw-r--r-- 6.1 KB
RTCDataChannel-id.html -rw-r--r-- 2.2 KB
RTCDataChannel-send.html -rw-r--r-- 10.6 KB
RTCDataChannelEvent-constructor.html -rw-r--r-- 1.2 KB
RTCDtlsTransport-getRemoteCertificates.html -rw-r--r-- 3.5 KB
RTCIceCandidate-constructor.html -rw-r--r-- 6.6 KB
RTCIceTransport.html -rw-r--r-- 7.4 KB
RTCPeerConnection-addIceCandidate.html -rw-r--r-- 17.6 KB
RTCPeerConnection-addTrack.https.html -rw-r--r-- 10.7 KB
RTCPeerConnection-addTransceiver.html -rw-r--r-- 17.8 KB
RTCPeerConnection-canTrickleIceCandidates.html -rw-r--r-- 2.3 KB
RTCPeerConnection-connectionState.html -rw-r--r-- 7.1 KB
RTCPeerConnection-constructor.html -rw-r--r-- 2.2 KB
RTCPeerConnection-createAnswer.html -rw-r--r-- 3.9 KB
RTCPeerConnection-createDataChannel.html -rw-r--r-- 14.7 KB
RTCPeerConnection-createOffer-offerToReceive.html -rw-r--r-- 6.1 KB
RTCPeerConnection-createOffer.html -rw-r--r-- 7.1 KB
RTCPeerConnection-generateCertificate.html -rw-r--r-- 4.7 KB
RTCPeerConnection-getDefaultIceServers.html -rw-r--r-- 3.1 KB
RTCPeerConnection-getIdentityAssertion.html -rw-r--r-- 15.0 KB
RTCPeerConnection-getStats.https.html -rw-r--r-- 11.8 KB
RTCPeerConnection-getTransceivers.html -rw-r--r-- 1.3 KB
RTCPeerConnection-helper.js -rw-r--r-- 13.4 KB
RTCPeerConnection-iceConnectionState.html -rw-r--r-- 6.6 KB
RTCPeerConnection-iceGatheringState.html -rw-r--r-- 4.4 KB
RTCPeerConnection-ondatachannel.html -rw-r--r-- 6.7 KB
RTCPeerConnection-onnegotiationneeded.html -rw-r--r-- 9.6 KB
RTCPeerConnection-ontrack.https.html -rw-r--r-- 8.8 KB
RTCPeerConnection-peerIdentity.html -rw-r--r-- 12.1 KB
RTCPeerConnection-removeTrack.https.html -rw-r--r-- 10.9 KB
RTCPeerConnection-setDescription-transceiver.html -rw-r--r-- 10.0 KB
RTCPeerConnection-setLocalDescription-answer.html -rw-r--r-- 5.8 KB
RTCPeerConnection-setLocalDescription-offer.html -rw-r--r-- 5.5 KB
RTCPeerConnection-setLocalDescription-pranswer.html -rw-r--r-- 5.5 KB
RTCPeerConnection-setLocalDescription-rollback.html -rw-r--r-- 4.5 KB
RTCPeerConnection-setLocalDescription.html -rw-r--r-- 3.7 KB
RTCPeerConnection-setRemoteDescription-answer.html -rw-r--r-- 4.0 KB
RTCPeerConnection-setRemoteDescription-offer.html -rw-r--r-- 5.8 KB
RTCPeerConnection-setRemoteDescription-pranswer.html -rw-r--r-- 5.4 KB
RTCPeerConnection-setRemoteDescription-replaceTrack.https.html -rw-r--r-- 5.0 KB
RTCPeerConnection-setRemoteDescription-rollback.html -rw-r--r-- 4.0 KB
RTCPeerConnection-setRemoteDescription-tracks.https.html -rw-r--r-- 16.9 KB
RTCPeerConnection-setRemoteDescription.html -rw-r--r-- 4.3 KB
RTCPeerConnection-track-stats.https.html -rw-r--r-- 23.9 KB
RTCPeerConnectionIceEvent-constructor.html -rw-r--r-- 4.3 KB
RTCRtpCapabilities-helper.js -rw-r--r-- 1.5 KB
RTCRtpParameters-codecs.html -rw-r--r-- 7.2 KB
RTCRtpParameters-degradationPreference.html -rw-r--r-- 2.8 KB
RTCRtpParameters-encodings.html -rw-r--r-- 12.9 KB
RTCRtpParameters-headerExtensions.html -rw-r--r-- 2.5 KB
RTCRtpParameters-helper.js -rw-r--r-- 7.7 KB
RTCRtpParameters-rtcp.html -rw-r--r-- 3.2 KB
RTCRtpParameters-transactionId.html -rw-r--r-- 5.2 KB
RTCRtpReceiver-getCapabilities.html -rw-r--r-- 1.1 KB
RTCRtpReceiver-getContributingSources.https.html -rw-r--r-- 3.2 KB
RTCRtpReceiver-getParameters.html -rw-r--r-- 1.8 KB
RTCRtpReceiver-getStats.https.html -rw-r--r-- 2.7 KB
RTCRtpReceiver-getSynchronizationSources.https.html -rw-r--r-- 2.6 KB
RTCRtpSender-getCapabilities.html -rw-r--r-- 1.5 KB
RTCRtpSender-getStats.https.html -rw-r--r-- 2.5 KB
RTCRtpSender-replaceTrack.html -rw-r--r-- 8.5 KB
RTCRtpSender-setParameters.html -rw-r--r-- 925 bytes
RTCRtpTransceiver-setCodecPreferences.html -rw-r--r-- 4.8 KB
RTCRtpTransceiver-setDirection.html -rw-r--r-- 3.2 KB
RTCSctpTransport-constructor.html -rw-r--r-- 3.0 KB
RTCSctpTransport-maxMessageSize.html -rw-r--r-- 6.7 KB
RTCStats-helper.js -rw-r--r-- 28.4 KB
RTCTrackEvent-constructor.html -rw-r--r-- 4.9 KB
datachannel-emptystring.html -rw-r--r-- 3.4 KB
dictionary-helper.js -rw-r--r-- 2.7 KB
getstats.html -rw-r--r-- 4.3 KB
historical.html -rw-r--r-- 933 bytes
identity-helper.js -rw-r--r-- 2.3 KB
interfaces.https.html -rw-r--r-- 5.7 KB
no-media-call.html -rw-r--r-- 4.9 KB
promises-call.html -rw-r--r-- 3.9 KB
simplecall.https.html -rw-r--r-- 3.8 KB

back to top