Revision 8f1ef70886a1443ccd9980448031c88a44c3faea authored by Ben Pastene on 13 April 2018, 17:03:33 UTC, committed by Chromium WPT Sync on 13 April 2018, 17:03:33 UTC
This reverts commit 7c3d1d13f940e88ef6706fd8b5c257a81d340ed9.
Reason for revert: WebviewLoginTest.Basic is still flaky on linux-chromeos-rel
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6886
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6887
Original change's description:
> Reland: Use PostTask to schedule cross-process postMessage forwarding.
>
> Changes from original attempt at https://crrev.com/c/999182:
> - fix flakiness in two additional ChromeOS login tests
> - fix CSP WPT tests to not depend on ordering between iframe's onload
> and postMessage - see https://crbug.com/832319.
>
> Previously, we sent the IPC to forward a cross-process postMessage
> immediately. This caused a behavioral difference from the
> same-process case where the postMessage is always scheduled. Namely,
> in a scenario like this:
>
> frame.postMessage(...);
> doSomethingThatSendsIPCsToFrame(frame);
>
> the IPCs from JS following the postMessage would've been ordered
> incorrectly, causing |frame| to see their side effects after the
> postMessage dispatch in the cross-process case, whereas they would be
> seen before the postMessage dispatch in the same-process case. One
> example of this is frame.focus(), and another is a frame element
> onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after
> a postMessage dispatched from an inline script while the frame was
> still loading.
>
> To resolve these ordering concerns, this CL changes cross-process
> postMessage to do a PostTask on the sender side before sending the
> message to the browser process. This improves the current state of
> the world, but does not yet achieve a perfect match for the IPC
> ordering in the same-process case - see discussion on the bug.
>
> Bug: 828529
> Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07
> Reviewed-on: https://chromium-review.googlesource.com/999182
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#550284}
> Reviewed-on: https://chromium-review.googlesource.com/1011287
> Cr-Commit-Position: refs/heads/master@{#550621}
TBR=xiyuan@chromium.org,dcheng@chromium.org,alexmos@chromium.org
Change-Id: Ic0637a6038bed6e5334a26e1934bee81faad3b9e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 828529
Reviewed-on: https://chromium-review.googlesource.com/1012138
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550649}
1 parent 1e5a5fe
RTCPeerConnection-iceGatheringState.html
<!doctype html>
<meta charset=utf-8>
<title>RTCPeerConnection.prototype.iceGatheringState</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="RTCPeerConnection-helper.js"></script>
<script>
'use strict';
// Test is based on the following editor draft:
// https://w3c.github.io/webrtc-pc/archives/20170605/webrtc.html
// The following helper functions are called from RTCPeerConnection-helper.js:
// exchangeIceCandidates
// doSignalingHandshake
/*
4.3.2. Interface Definition
interface RTCPeerConnection : EventTarget {
...
readonly attribute RTCIceGatheringState iceGatheringState;
attribute EventHandler onicegatheringstatechange;
};
4.4.2. RTCIceGatheringState Enum
enum RTCIceGatheringState {
"new",
"gathering",
"complete"
};
5.6. RTCIceTransport Interface
interface RTCIceTransport {
readonly attribute RTCIceGathererState gatheringState;
...
};
enum RTCIceGathererState {
"new",
"gathering",
"complete"
};
*/
/*
4.4.2. RTCIceGatheringState Enum
new
Any of the RTCIceTransport s are in the new gathering state and
none of the transports are in the gathering state, or there are
no transports.
*/
test(t => {
const pc = new RTCPeerConnection();
assert_equals(pc.iceGatheringState, 'new');
}, 'Initial iceGatheringState should be new');
async_test(t => {
const pc = new RTCPeerConnection();
const onIceGatheringStateChange = t.step_func(() => {
const { iceGatheringState } = pc;
if(iceGatheringState === 'complete') {
t.done();
}
});
assert_equals(pc.onicegatheringstatechange, null,
'Expect connection to have icegatheringstatechange event');
pc.addEventListener('icegatheringstatechange', onIceGatheringStateChange);
pc.createOffer({ offerToReceiveAudio: true })
.then(offer => pc.setLocalDescription(offer))
.then(err => t.step_func(err =>
assert_unreached(`Unhandled rejection ${err.name}: ${err.message}`)));
}, 'iceGatheringState should eventually become complete after setLocalDescription');
/*
4.4.2. RTCIceGatheringState Enum
gathering
Any of the RTCIceTransport s are in the gathering state.
complete
At least one RTCIceTransport exists, and all RTCIceTransports are
in the completed gathering state.
5.6. RTCIceGathererState
gathering
The RTCIceTransport is in the process of gathering candidates.
complete
The RTCIceTransport has completed gathering and the end-of-candidates
indication for this transport has been sent. It will not gather candidates
again until an ICE restart causes it to restart.
*/
async_test(t => {
const pc1 = new RTCPeerConnection();
const pc2 = new RTCPeerConnection();
const onIceGatheringStateChange = t.step_func(() => {
const { iceGatheringState } = pc2;
if(iceGatheringState === 'gathering') {
const iceTransport = pc2.sctp.transport.transport;
assert_equals(iceTransport.gatheringState, 'gathering',
'Expect ICE transport to be in checking gatheringState when iceGatheringState is checking');
} else if(iceGatheringState === 'complete') {
const iceTransport = pc2.sctp.transport.transport;
assert_equals(iceTransport.gatheringState, 'complete',
'Expect ICE transport to be in complete gatheringState when iceGatheringState is complete');
t.done();
}
});
pc1.createDataChannel('test');
assert_equals(pc2.onicegatheringstatechange, null,
'Expect connection to have icegatheringstatechange event');
// Spec bug w3c/webrtc-pc#1382
// Because sctp is only defined when answer is set, we listen
// to pc2 so that we can be confident that sctp is defined
// when icegatheringstatechange event is fired.
pc2.addEventListener('icegatheringstatechange', onIceGatheringStateChange);
exchangeIceCandidates(pc1, pc2);
doSignalingHandshake(pc1, pc2);
}, 'connection with one data channel should eventually have connected connection state');
/*
TODO
5.6. RTCIceTransport Interface
new
The RTCIceTransport was just created, and has not started gathering
candidates yet.
*/
</script>
Computing file changes ...
