Revision 9046bdc5d3a4e8774e08e4b12784d37c2b001c9f authored by anand76 on 21 August 2019, 17:21:41 UTC, committed by Facebook Github Bot on 21 August 2019, 17:23:23 UTC
Summary: The batched MultiGet() implementation was not correctly handling bloom filter lookups when whole_key_filtering is disabled. It was incorrectly skipping keys not in the prefix_extractor domain, and not calling transform for keys in domain. This PR fixes both problems by moving the domain check and transformation to the FilterBlockReader. Tests: Unit test (confirmed failed before the fix) make check Pull Request resolved: https://github.com/facebook/rocksdb/pull/5665 Differential Revision: D16902380 Pulled By: anand1976 fbshipit-source-id: a6be81ad68a6e37134a65246aec7a2c590eccf00
1 parent 7bc18e2
| File | Mode | Size |
|---|---|---|
| cf_options.cc | -rw-r--r-- | 10.4 KB |
| cf_options.h | -rw-r--r-- | 8.9 KB |
| db_options.cc | -rw-r--r-- | 15.0 KB |
| db_options.h | -rw-r--r-- | 3.3 KB |
| options.cc | -rw-r--r-- | 25.5 KB |
| options_helper.cc | -rw-r--r-- | 91.3 KB |
| options_helper.h | -rw-r--r-- | 9.0 KB |
| options_parser.cc | -rw-r--r-- | 29.9 KB |
| options_parser.h | -rw-r--r-- | 5.1 KB |
| options_sanity_check.cc | -rw-r--r-- | 1.1 KB |
| options_sanity_check.h | -rw-r--r-- | 1.7 KB |
| options_settable_test.cc | -rw-r--r-- | 21.4 KB |
| options_test.cc | -rw-r--r-- | 77.9 KB |
Computing file changes ...
