Revision 91ddd587cc658b2899a4fe2b2b734e71e41c29a6 authored by Igor Canadi on 03 June 2014, 00:23:55 UTC, committed by Igor Canadi on 03 June 2014, 00:23:55 UTC
Summary:
At the end of BackgroundCallCompaction(), we call SignalAll(), even though we don't need to. If compaction hasn't done anything and there's another compaction running, there is no need to signal on the condition variable. Doing so creates a tight feedback loop which results in log files like:

   wait for memtable flush
   compaction nothing to do
   wait for memtable flush
   compaction nothing to do

This change eliminates that

Test Plan:
make check
Also:

    icanadi@dev1440 ~ $ grep "nothing to do" /fast-rocksdb-tmp/rocksdb_test/column_family_test/LOG | wc -l
    7435
    icanadi@dev1440 ~ $ grep "nothing to do" /fast-rocksdb-tmp/rocksdb_test/column_family_test/LOG | wc -l
    372

First version is before the change, second version is after the change.

Reviewers: dhruba, ljin, haobo, yhchiang, sdong

Reviewed By: sdong

Subscribers: leveldb

Differential Revision: https://reviews.facebook.net/D18855
1 parent 8cb7ad8
History
File Mode Size
doc.css -rw-r--r-- 1.1 KB
index.html -rw-r--r-- 35.1 KB
log_format.txt -rw-r--r-- 2.7 KB
rockslogo.jpg -rw-r--r-- 134.0 KB
rockslogo.png -rw-r--r-- 60.3 KB

back to top