swh:1:snp:5115096b921df712aeb2a08114fede57fb3331fb
Revision 91ddd587cc658b2899a4fe2b2b734e71e41c29a6 authored by Igor Canadi on 03 June 2014, 00:23:55 UTC, committed by Igor Canadi on 03 June 2014, 00:23:55 UTC
Summary:
At the end of BackgroundCallCompaction(), we call SignalAll(), even though we don't need to. If compaction hasn't done anything and there's another compaction running, there is no need to signal on the condition variable. Doing so creates a tight feedback loop which results in log files like:

   wait for memtable flush
   compaction nothing to do
   wait for memtable flush
   compaction nothing to do

This change eliminates that

Test Plan:
make check
Also:

    icanadi@dev1440 ~ $ grep "nothing to do" /fast-rocksdb-tmp/rocksdb_test/column_family_test/LOG | wc -l
    7435
    icanadi@dev1440 ~ $ grep "nothing to do" /fast-rocksdb-tmp/rocksdb_test/column_family_test/LOG | wc -l
    372

First version is before the change, second version is after the change.

Reviewers: dhruba, ljin, haobo, yhchiang, sdong

Reviewed By: sdong

Subscribers: leveldb

Differential Revision: https://reviews.facebook.net/D18855
1 parent 8cb7ad8
History
Tip revision: 19076c95aa2bcee55c26fcf0960cc844ad86ee9c authored by Levi Tamasi on 21 January 2021, 22:18:25 UTC
Update HISTORY.md for PR 7888 (#7890)
Tip revision: 19076c9
File Mode Size
build_tools
coverage
db
doc
examples
hdfs
helpers
include
java
linters
port
table
third-party
tools
util
utilities
.arcconfig -rw-r--r-- 246 bytes
.clang-format -rw-r--r-- 138 bytes
.gitignore -rw-r--r-- 331 bytes
.travis.yml -rw-r--r-- 1.0 KB
CONTRIBUTING.md -rw-r--r-- 759 bytes
HISTORY.md -rw-r--r-- 5.8 KB
INSTALL.md -rw-r--r-- 3.4 KB
LICENSE -rw-r--r-- 1.6 KB
Makefile -rw-r--r-- 20.3 KB
PATENTS -rw-r--r-- 1.4 KB
README.md -rw-r--r-- 1.3 KB
ROCKSDB_LITE.md -rw-r--r-- 1020 bytes

README.md

back to top