Revision 94b3dd0f7bb393d93e84a173b1df9b8b64c83ac4 authored by Greg Thelen on 04 June 2010, 21:15:03 UTC, committed by Linus Torvalds on 04 June 2010, 22:21:45 UTC
Child groups should have a greater depth than their parents. Prior to this change, the parent would incorrectly report zero memory usage for child cgroups when use_hierarchy is enabled. test script: mount -t cgroup none /cgroups -o memory cd /cgroups mkdir cg1 echo 1 > cg1/memory.use_hierarchy mkdir cg1/cg11 echo $$ > cg1/cg11/tasks dd if=/dev/zero of=/tmp/foo bs=1M count=1 echo echo CHILD grep cache cg1/cg11/memory.stat echo echo PARENT grep cache cg1/memory.stat echo $$ > tasks rmdir cg1/cg11 cg1 cd / umount /cgroups Using fae9c79, a recent patch that changed alloc_css_id() depth computation, the parent incorrectly reports zero usage: root@ubuntu:~# ./test 1+0 records in 1+0 records out 1048576 bytes (1.0 MB) copied, 0.0151844 s, 69.1 MB/s CHILD cache 1048576 total_cache 1048576 PARENT cache 0 total_cache 0 With this patch, the parent correctly includes child usage: root@ubuntu:~# ./test 1+0 records in 1+0 records out 1048576 bytes (1.0 MB) copied, 0.0136827 s, 76.6 MB/s CHILD cache 1052672 total_cache 1052672 PARENT cache 0 total_cache 1052672 Signed-off-by: Greg Thelen <gthelen@google.com> Acked-by: Paul Menage <menage@google.com> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Acked-by: Li Zefan <lizf@cn.fujitsu.com> Cc: <stable@kernel.org> [2.6.34.x] Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 007d086
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 2.5 KB |
Kconfig.iosched | -rw-r--r-- | 1.8 KB |
Makefile | -rw-r--r-- | 592 bytes |
blk-barrier.c | -rw-r--r-- | 8.6 KB |
blk-cgroup.c | -rw-r--r-- | 26.8 KB |
blk-cgroup.h | -rw-r--r-- | 8.0 KB |
blk-core.c | -rw-r--r-- | 67.8 KB |
blk-exec.c | -rw-r--r-- | 2.6 KB |
blk-integrity.c | -rw-r--r-- | 10.0 KB |
blk-ioc.c | -rw-r--r-- | 3.9 KB |
blk-iopoll.c | -rw-r--r-- | 5.9 KB |
blk-lib.c | -rw-r--r-- | 5.3 KB |
blk-map.c | -rw-r--r-- | 8.1 KB |
blk-merge.c | -rw-r--r-- | 10.6 KB |
blk-settings.c | -rw-r--r-- | 24.6 KB |
blk-softirq.c | -rw-r--r-- | 4.1 KB |
blk-sysfs.c | -rw-r--r-- | 13.8 KB |
blk-tag.c | -rw-r--r-- | 9.9 KB |
blk-timeout.c | -rw-r--r-- | 5.6 KB |
blk.h | -rw-r--r-- | 4.5 KB |
bsg.c | -rw-r--r-- | 23.5 KB |
cfq-iosched.c | -rw-r--r-- | 100.0 KB |
compat_ioctl.c | -rw-r--r-- | 22.1 KB |
deadline-iosched.c | -rw-r--r-- | 11.4 KB |
elevator.c | -rw-r--r-- | 24.8 KB |
genhd.c | -rw-r--r-- | 29.9 KB |
ioctl.c | -rw-r--r-- | 8.2 KB |
noop-iosched.c | -rw-r--r-- | 2.6 KB |
scsi_ioctl.c | -rw-r--r-- | 18.0 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...