Revision 9509b64e464e2a70e528a3baa8a59935b5d44226 authored by Manuel Rego Casasnovas on 14 March 2018, 14:48:14 UTC, committed by Chromium WPT Sync on 14 March 2018, 14:48:14 UTC
There was a crash in debug if you use calc()
mixing fixed and percentage values due to the wrong DCHECK
in GapLength constructor. The patch fixes this assert.
In addition LayoutGrid::GridGap() was also wrong and didn't consider
calc() either. The fix is again easy just using the proper check.
Regarding testing, the parsing tests have been updated to include
this combination of fixed and percentage values in calc().
At the same time, the patch actually uses "grid-" prefixed properties
in the tests that were supposed to test those.
Last, two new tests are added to verify the proper behavior of calc()
with mixed values on a grid layout container.
BUG=816300
TEST=external/wpt/css/css-align/gaps/column-gap-parsing-001.html
TEST=external/wpt/css/css-align/gaps/gap-parsing-001.html
TEST=external/wpt/css/css-align/gaps/grid-column-gap-parsing-001.html
TEST=external/wpt/css/css-align/gaps/grid-gap-parsing-001.html
TEST=external/wpt/css/css-align/gaps/grid-row-gap-parsing-001.html
TEST=external/wpt/css/css-align/gaps/row-gap-parsing-001.html
TEST=external/wpt/css/css-grid/alignment/grid-gutters-011.html
TEST=external/wpt/css/css-grid/alignment/grid-gutters-012.html
Change-Id: I4c9fe6b2525a253c6bb00cbda727c2bf1ae6e90b
Reviewed-on: https://chromium-review.googlesource.com/962148
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Reviewed-by: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#543079}
1 parent 3686c5f
| File | Mode | Size |
|---|---|---|
| OWNERS | -rw-r--r-- | 28 bytes |
| anim-gr.gif | -rw-r--r-- | 241 bytes |
| anim-gr.png | -rw-r--r-- | 460 bytes |
| anim-poster-gr.png | -rw-r--r-- | 422 bytes |
| apng.png | -rw-r--r-- | 259 bytes |
| background.png | -rw-r--r-- | 86 bytes |
| black-rectangle.png | -rw-r--r-- | 307 bytes |
| blue-area.png | -rw-r--r-- | 1.4 KB |
| blue-border.png | -rw-r--r-- | 1.8 KB |
| blue-png-cachable.py | -rw-r--r-- | 507 bytes |
| blue.png | -rw-r--r-- | 485 bytes |
| blue96x96.png | -rw-r--r-- | 1010 bytes |
| broken.png | -rw-r--r-- | 87 bytes |
| canvas-line.png | -rw-r--r-- | 502 bytes |
| colors.svg | -rw-r--r-- | 411 bytes |
| fail.gif | -rw-r--r-- | 23.9 KB |
| ggrr-256x256.png | -rw-r--r-- | 120 bytes |
| green-100x50.png | -rw-r--r-- | 218 bytes |
| green-16x16.png | -rw-r--r-- | 92 bytes |
| green-1x1.png | -rw-r--r-- | 82 bytes |
| green-256x256.png | -rw-r--r-- | 103 bytes |
| green-2x2.png | -rw-r--r-- | 118 bytes |
| green.png | -rw-r--r-- | 87 bytes |
| green.svg | -rw-r--r-- | 118 bytes |
| grgr-256x256.png | -rw-r--r-- | 130 bytes |
| movie_300_frame_0.png | -rw-r--r-- | 11.2 KB |
| pattern.mp4 | -rw-r--r-- | 1.5 KB |
| pattern.ogv | -rw-r--r-- | 6.5 KB |
| pattern.png | -rw-r--r-- | 123 bytes |
| pattern.svg | -rw-r--r-- | 319 bytes |
| red-16x16.png | -rw-r--r-- | 130 bytes |
| red-zeroheight.svg | -rw-r--r-- | 117 bytes |
| red-zerosize.svg | -rw-r--r-- | 115 bytes |
| red-zerowidth.svg | -rw-r--r-- | 117 bytes |
| red.png | -rw-r--r-- | 87 bytes |
| redtransparent.png | -rw-r--r-- | 109 bytes |
| rgrg-256x256.png | -rw-r--r-- | 131 bytes |
| rrgg-256x256.png | -rw-r--r-- | 120 bytes |
| smiley.png | -rw-r--r-- | 1.8 KB |
| smiley.png.headers | -rw-r--r-- | 23 bytes |
| threecolors.png | -rw-r--r-- | 242 bytes |
| transparent.png | -rw-r--r-- | 100 bytes |
| transparent50.png | -rw-r--r-- | 155 bytes |
| yellow.png | -rw-r--r-- | 95 bytes |
| yellow75.png | -rw-r--r-- | 150 bytes |
Computing file changes ...
