Revision 96ce0470a71be5464b912fa4be41f9a6b2dd405d authored by Cheng Chang on 22 July 2020, 20:52:45 UTC, committed by Facebook GitHub Bot on 22 July 2020, 20:54:01 UTC
Summary: `DBTest::SnapshotFiles` runs the tests in a `while` loop. Currently, the snapshot directory is not cleaned up in each loop, so previous snapshot files may remain in the next loop's snapshot. When I'm working on https://github.com/facebook/rocksdb/pull/7129, when checking the tracked WALs in MANIFEST, I find that this test always fails because it reads some unknown WAL. It turns out that the unknown WAL is left from previous loops. Pull Request resolved: https://github.com/facebook/rocksdb/pull/7156 Test Plan: make db_test && ./db_test --gtest_filters=*SnapshotFiles Reviewed By: siying Differential Revision: D22668360 Pulled By: cheng-chang fbshipit-source-id: 69d4aa3506038ba30e218e8ae966357935a99c6c
1 parent d44cbc5
| File | Mode | Size |
|---|---|---|
| cache.cc | -rw-r--r-- | 2.6 KB |
| cache_bench.cc | -rw-r--r-- | 11.0 KB |
| cache_test.cc | -rw-r--r-- | 23.1 KB |
| clock_cache.cc | -rw-r--r-- | 27.4 KB |
| clock_cache.h | -rw-r--r-- | 601 bytes |
| lru_cache.cc | -rw-r--r-- | 16.9 KB |
| lru_cache.h | -rw-r--r-- | 11.3 KB |
| lru_cache_test.cc | -rw-r--r-- | 6.0 KB |
| sharded_cache.cc | -rw-r--r-- | 5.0 KB |
| sharded_cache.h | -rw-r--r-- | 4.4 KB |
Computing file changes ...
