Revision 96ce0470a71be5464b912fa4be41f9a6b2dd405d authored by Cheng Chang on 22 July 2020, 20:52:45 UTC, committed by Facebook GitHub Bot on 22 July 2020, 20:54:01 UTC
Summary:
`DBTest::SnapshotFiles` runs the tests in a `while` loop.
Currently, the snapshot directory is not cleaned up in each loop, so previous snapshot files may remain in the next loop's snapshot.
When I'm working on https://github.com/facebook/rocksdb/pull/7129, when checking the tracked WALs in MANIFEST, I find that this test always fails because it reads some unknown WAL. It turns out that the unknown WAL is left from previous loops.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/7156

Test Plan: make db_test && ./db_test --gtest_filters=*SnapshotFiles

Reviewed By: siying

Differential Revision: D22668360

Pulled By: cheng-chang

fbshipit-source-id: 69d4aa3506038ba30e218e8ae966357935a99c6c
1 parent d44cbc5
History
File Mode Size
CMakeLists.txt -rw-r--r-- 414 bytes
batched_ops_stress.cc -rw-r--r-- 13.0 KB
cf_consistency_stress.cc -rw-r--r-- 22.1 KB
db_stress.cc -rw-r--r-- 763 bytes
db_stress_common.cc -rw-r--r-- 8.6 KB
db_stress_common.h -rw-r--r-- 18.8 KB
db_stress_compaction_filter.h -rw-r--r-- 2.6 KB
db_stress_driver.cc -rw-r--r-- 5.1 KB
db_stress_driver.h -rw-r--r-- 727 bytes
db_stress_env_wrapper.h -rw-r--r-- 1.3 KB
db_stress_gflags.cc -rw-r--r-- 30.2 KB
db_stress_listener.h -rw-r--r-- 6.5 KB
db_stress_shared_state.cc -rw-r--r-- 1023 bytes
db_stress_shared_state.h -rw-r--r-- 14.1 KB
db_stress_stat.h -rw-r--r-- 6.4 KB
db_stress_test_base.cc -rw-r--r-- 83.0 KB
db_stress_test_base.h -rw-r--r-- 9.0 KB
db_stress_tool.cc -rw-r--r-- 10.8 KB
no_batched_ops_stress.cc -rw-r--r-- 28.0 KB

back to top