Skip to main content

Browse the archive

https://github.com/torvalds/linux
05 April 2024, 19:05:47 UTC
Revision 9ab4ad295622a3481818856762471c1f8c830e18 authored by Nikita Kiryushin on 01 April 2024, 19:14:18 UTC, committed by Paolo Abeni on 04 April 2024, 08:16:50 UTC 
tg3: Remove residual error handling in tg3_suspend
 
As of now, tg3_power_down_prepare always ends with success, but
the error handling code from former tg3_set_power_state call is still here.

This code became unreachable in commit c866b7eac073 ("tg3: Do not use
legacy PCI power management").

Remove (now unreachable) error handling code for simplification and change
tg3_power_down_prepare to a void function as its result is no more checked.

Signed-off-by: Nikita Kiryushin <kiryushin@ancud.ru>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240401191418.361747-1-kiryushin@ancud.ru
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent c0de6ab
Raw File
Tip revision: 9ab4ad295622a3481818856762471c1f8c830e18 authored by Nikita Kiryushin on 01 April 2024, 19:14:18 UTC
tg3: Remove residual error handling in tg3_suspend
Tip revision: 9ab4ad2
.rustfmt.toml 
edition = "2021"
newline_style = "Unix"

# Unstable options that help catching some mistakes in formatting and that we may want to enable
# when they become stable.
#
# They are kept here since they are useful to run from time to time.
#format_code_in_doc_comments = true
#reorder_impl_items = true
#comment_width = 100
#wrap_comments = true
#normalize_comments = true
back to top