Skip to main content

Browse the archive

https://github.com/torvalds/linux
05 April 2024, 19:05:47 UTC
Revision 9ab4ad295622a3481818856762471c1f8c830e18 authored by Nikita Kiryushin on 01 April 2024, 19:14:18 UTC, committed by Paolo Abeni on 04 April 2024, 08:16:50 UTC 
tg3: Remove residual error handling in tg3_suspend
 
As of now, tg3_power_down_prepare always ends with success, but
the error handling code from former tg3_set_power_state call is still here.

This code became unreachable in commit c866b7eac073 ("tg3: Do not use
legacy PCI power management").

Remove (now unreachable) error handling code for simplification and change
tg3_power_down_prepare to a void function as its result is no more checked.

Signed-off-by: Nikita Kiryushin <kiryushin@ancud.ru>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240401191418.361747-1-kiryushin@ancud.ru
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent c0de6ab
History
Tip revision: 9ab4ad295622a3481818856762471c1f8c830e18 authored by Nikita Kiryushin on 01 April 2024, 19:14:18 UTC
tg3: Remove residual error handling in tg3_suspend
Tip revision: 9ab4ad2
File Mode Size
.gitignore -rw-r--r-- 58 bytes
Kconfig -rw-r--r-- 63.2 KB
Makefile -rw-r--r-- 1.9 KB
build-version -rwxr-xr-x 177 bytes
calibrate.c -rw-r--r-- 8.6 KB
do_mounts.c -rw-r--r-- 11.0 KB
do_mounts.h -rw-r--r-- 1.2 KB
do_mounts_initrd.c -rw-r--r-- 3.8 KB
do_mounts_rd.c -rw-r--r-- 7.7 KB
init_task.c -rw-r--r-- 6.1 KB
initramfs.c -rw-r--r-- 17.6 KB
main.c -rw-r--r-- 37.8 KB
noinitramfs.c -rw-r--r-- 862 bytes
version-timestamp.c -rw-r--r-- 762 bytes
version.c -rw-r--r-- 1.3 KB
back to top