Revision 9c1177b62a8c7f78fee5ede540825b844a1bf0c8 authored by Qian Cai on 15 August 2020, 00:31:47 UTC, committed by Linus Torvalds on 15 August 2020, 02:56:57 UTC
mm->tlb_flush_batched could be accessed concurrently as noticed by KCSAN, BUG: KCSAN: data-race in flush_tlb_batched_pending / try_to_unmap_one write to 0xffff93f754880bd0 of 1 bytes by task 822 on cpu 6: try_to_unmap_one+0x59a/0x1ab0 set_tlb_ubc_flush_pending at mm/rmap.c:635 (inlined by) try_to_unmap_one at mm/rmap.c:1538 rmap_walk_anon+0x296/0x650 rmap_walk+0xdf/0x100 try_to_unmap+0x18a/0x2f0 shrink_page_list+0xef6/0x2870 shrink_inactive_list+0x316/0x880 shrink_lruvec+0x8dc/0x1380 shrink_node+0x317/0xd80 balance_pgdat+0x652/0xd90 kswapd+0x396/0x8d0 kthread+0x1e0/0x200 ret_from_fork+0x27/0x50 read to 0xffff93f754880bd0 of 1 bytes by task 6364 on cpu 4: flush_tlb_batched_pending+0x29/0x90 flush_tlb_batched_pending at mm/rmap.c:682 change_p4d_range+0x5dd/0x1030 change_pte_range at mm/mprotect.c:44 (inlined by) change_pmd_range at mm/mprotect.c:212 (inlined by) change_pud_range at mm/mprotect.c:240 (inlined by) change_p4d_range at mm/mprotect.c:260 change_protection+0x222/0x310 change_prot_numa+0x3e/0x60 task_numa_work+0x219/0x350 task_work_run+0xed/0x140 prepare_exit_to_usermode+0x2cc/0x2e0 ret_from_intr+0x32/0x42 Reported by Kernel Concurrency Sanitizer on: CPU: 4 PID: 6364 Comm: mtest01 Tainted: G W L 5.5.0-next-20200210+ #5 Hardware name: HPE ProLiant DL385 Gen10/ProLiant DL385 Gen10, BIOS A40 07/10/2019 flush_tlb_batched_pending() is under PTL but the write is not, but mm->tlb_flush_batched is only a bool type, so the value is unlikely to be shattered. Thus, mark it as an intentional data race by using the data race macro. Signed-off-by: Qian Cai <cai@lca.pw> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Cc: Marco Elver <elver@google.com> Link: http://lkml.kernel.org/r/1581450783-8262-1-git-send-email-cai@lca.pw Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent abe1de4
| File | Mode | Size |
|---|---|---|
| asymmetric_keys | ||
| async_tx | ||
| 842.c | -rw-r--r-- | 3.7 KB |
| Kconfig | -rw-r--r-- | 54.8 KB |
| Makefile | -rw-r--r-- | 7.4 KB |
| acompress.c | -rw-r--r-- | 4.7 KB |
| adiantum.c | -rw-r--r-- | 19.4 KB |
| aead.c | -rw-r--r-- | 7.2 KB |
| aegis.h | -rw-r--r-- | 1.8 KB |
| aegis128-core.c | -rw-r--r-- | 13.1 KB |
| aegis128-neon-inner.c | -rw-r--r-- | 6.3 KB |
| aegis128-neon.c | -rw-r--r-- | 1.9 KB |
| aes_generic.c | -rw-r--r-- | 57.6 KB |
| aes_ti.c | -rw-r--r-- | 2.0 KB |
| af_alg.c | -rw-r--r-- | 25.7 KB |
| ahash.c | -rw-r--r-- | 16.2 KB |
| akcipher.c | -rw-r--r-- | 4.0 KB |
| algapi.c | -rw-r--r-- | 29.5 KB |
| algboss.c | -rw-r--r-- | 5.9 KB |
| algif_aead.c | -rw-r--r-- | 15.6 KB |
| algif_hash.c | -rw-r--r-- | 9.5 KB |
| algif_rng.c | -rw-r--r-- | 5.1 KB |
| algif_skcipher.c | -rw-r--r-- | 9.6 KB |
| ansi_cprng.c | -rw-r--r-- | 10.7 KB |
| anubis.c | -rw-r--r-- | 27.8 KB |
| api.c | -rw-r--r-- | 13.8 KB |
| arc4.c | -rw-r--r-- | 1.8 KB |
| authenc.c | -rw-r--r-- | 13.1 KB |
| authencesn.c | -rw-r--r-- | 14.2 KB |
| blake2b_generic.c | -rw-r--r-- | 9.3 KB |
| blake2s_generic.c | -rw-r--r-- | 5.0 KB |
| blowfish_common.c | -rw-r--r-- | 15.5 KB |
| blowfish_generic.c | -rw-r--r-- | 3.2 KB |
| camellia_generic.c | -rw-r--r-- | 34.2 KB |
| cast5_generic.c | -rw-r--r-- | 20.5 KB |
| cast6_generic.c | -rw-r--r-- | 9.1 KB |
| cast_common.c | -rw-r--r-- | 12.9 KB |
| cbc.c | -rw-r--r-- | 2.2 KB |
| ccm.c | -rw-r--r-- | 23.4 KB |
| cfb.c | -rw-r--r-- | 6.1 KB |
| chacha20poly1305.c | -rw-r--r-- | 17.7 KB |
| chacha_generic.c | -rw-r--r-- | 3.9 KB |
| cipher.c | -rw-r--r-- | 2.5 KB |
| cmac.c | -rw-r--r-- | 7.5 KB |
| compress.c | -rw-r--r-- | 921 bytes |
| crc32_generic.c | -rw-r--r-- | 3.7 KB |
| crc32c_generic.c | -rw-r--r-- | 4.1 KB |
| crct10dif_common.c | -rw-r--r-- | 3.6 KB |
| crct10dif_generic.c | -rw-r--r-- | 3.1 KB |
| cryptd.c | -rw-r--r-- | 28.6 KB |
| crypto_engine.c | -rw-r--r-- | 15.3 KB |
| crypto_null.c | -rw-r--r-- | 5.3 KB |
| crypto_user_base.c | -rw-r--r-- | 12.0 KB |
| crypto_user_stat.c | -rw-r--r-- | 9.6 KB |
| ctr.c | -rw-r--r-- | 9.5 KB |
| cts.c | -rw-r--r-- | 11.5 KB |
| curve25519-generic.c | -rw-r--r-- | 2.2 KB |
| deflate.c | -rw-r--r-- | 7.7 KB |
| des_generic.c | -rw-r--r-- | 3.3 KB |
| dh.c | -rw-r--r-- | 5.4 KB |
| dh_helper.c | -rw-r--r-- | 3.4 KB |
| drbg.c | -rw-r--r-- | 59.7 KB |
| ecb.c | -rw-r--r-- | 2.4 KB |
| ecc.c | -rw-r--r-- | 39.0 KB |
| ecc.h | -rw-r--r-- | 8.0 KB |
| ecc_curve_defs.h | -rw-r--r-- | 1.9 KB |
| ecdh.c | -rw-r--r-- | 3.9 KB |
| ecdh_helper.c | -rw-r--r-- | 2.1 KB |
| echainiv.c | -rw-r--r-- | 4.1 KB |
| ecrdsa.c | -rw-r--r-- | 8.3 KB |
| ecrdsa_defs.h | -rw-r--r-- | 7.2 KB |
| ecrdsa_params.asn1 | -rw-r--r-- | 142 bytes |
| ecrdsa_pub_key.asn1 | -rw-r--r-- | 57 bytes |
| essiv.c | -rw-r--r-- | 17.8 KB |
| fcrypt.c | -rw-r--r-- | 18.0 KB |
| fips.c | -rw-r--r-- | 1.7 KB |
| gcm.c | -rw-r--r-- | 30.0 KB |
| geniv.c | -rw-r--r-- | 3.8 KB |
| gf128mul.c | -rw-r--r-- | 12.5 KB |
| ghash-generic.c | -rw-r--r-- | 4.8 KB |
| hash_info.c | -rw-r--r-- | 1.9 KB |
| hmac.c | -rw-r--r-- | 6.4 KB |
| internal.h | -rw-r--r-- | 3.7 KB |
| jitterentropy-kcapi.c | -rw-r--r-- | 6.2 KB |
| jitterentropy.c | -rw-r--r-- | 25.2 KB |
| jitterentropy.h | -rw-r--r-- | 643 bytes |
| keywrap.c | -rw-r--r-- | 9.5 KB |
| khazad.c | -rw-r--r-- | 51.8 KB |
| kpp.c | -rw-r--r-- | 2.7 KB |
| lrw.c | -rw-r--r-- | 10.6 KB |
| lz4.c | -rw-r--r-- | 3.3 KB |
| lz4hc.c | -rw-r--r-- | 3.4 KB |
| lzo-rle.c | -rw-r--r-- | 3.4 KB |
| lzo.c | -rw-r--r-- | 3.3 KB |
| md4.c | -rw-r--r-- | 5.9 KB |
| md5.c | -rw-r--r-- | 7.4 KB |
| memneq.c | -rw-r--r-- | 6.1 KB |
| michael_mic.c | -rw-r--r-- | 3.5 KB |
| nhpoly1305.c | -rw-r--r-- | 7.8 KB |
| ofb.c | -rw-r--r-- | 2.4 KB |
| pcbc.c | -rw-r--r-- | 4.6 KB |
| pcrypt.c | -rw-r--r-- | 9.2 KB |
| poly1305_generic.c | -rw-r--r-- | 3.7 KB |
| proc.c | -rw-r--r-- | 2.5 KB |
| ripemd.h | -rw-r--r-- | 1013 bytes |
| rmd128.c | -rw-r--r-- | 10.0 KB |
| rmd160.c | -rw-r--r-- | 12.4 KB |
| rmd256.c | -rw-r--r-- | 10.3 KB |
| rmd320.c | -rw-r--r-- | 12.8 KB |
| rng.c | -rw-r--r-- | 4.8 KB |
| rsa-pkcs1pad.c | -rw-r--r-- | 17.2 KB |
| rsa.c | -rw-r--r-- | 5.3 KB |
| rsa_helper.c | -rw-r--r-- | 4.0 KB |
| rsaprivkey.asn1 | -rw-r--r-- | 316 bytes |
| rsapubkey.asn1 | -rw-r--r-- | 82 bytes |
| salsa20_generic.c | -rw-r--r-- | 6.0 KB |
| scatterwalk.c | -rw-r--r-- | 2.0 KB |
| scompress.c | -rw-r--r-- | 6.8 KB |
| seed.c | -rw-r--r-- | 17.2 KB |
| seqiv.c | -rw-r--r-- | 4.5 KB |
| serpent_generic.c | -rw-r--r-- | 21.5 KB |
| sha1_generic.c | -rw-r--r-- | 2.3 KB |
| sha256_generic.c | -rw-r--r-- | 3.3 KB |
| sha3_generic.c | -rw-r--r-- | 8.0 KB |
| sha512_generic.c | -rw-r--r-- | 7.8 KB |
| shash.c | -rw-r--r-- | 15.1 KB |
| simd.c | -rw-r--r-- | 13.5 KB |
| skcipher.c | -rw-r--r-- | 24.8 KB |
| sm3_generic.c | -rw-r--r-- | 4.1 KB |
| sm4_generic.c | -rw-r--r-- | 6.2 KB |
| streebog_generic.c | -rw-r--r-- | 57.6 KB |
| tcrypt.c | -rw-r--r-- | 78.7 KB |
| tcrypt.h | -rw-r--r-- | 4.2 KB |
| tea.c | -rw-r--r-- | 6.5 KB |
| testmgr.c | -rw-r--r-- | 144.9 KB |
| testmgr.h | -rw-r--r-- | 1.2 MB |
| tgr192.c | -rw-r--r-- | 30.3 KB |
| twofish_common.c | -rw-r--r-- | 37.1 KB |
| twofish_generic.c | -rw-r--r-- | 5.6 KB |
| vmac.c | -rw-r--r-- | 18.8 KB |
| wp512.c | -rw-r--r-- | 59.8 KB |
| xcbc.c | -rw-r--r-- | 6.7 KB |
| xor.c | -rw-r--r-- | 3.4 KB |
| xts.c | -rw-r--r-- | 11.7 KB |
| xxhash_generic.c | -rw-r--r-- | 2.4 KB |
| zstd.c | -rw-r--r-- | 5.0 KB |
Computing file changes ...
