Revision 9cc02ede696272c5271a401e4f27c262359bc2f6 authored by Duoming Zhou on 29 June 2022, 00:26:40 UTC, committed by Paolo Abeni on 30 June 2022, 09:07:30 UTC
There are UAF bugs in rose_heartbeat_expiry(), rose_timer_expiry()
and rose_idletimer_expiry(). The root cause is that del_timer()
could not stop the timer handler that is running and the refcount
of sock is not managed properly.
One of the UAF bugs is shown below:
(thread 1) | (thread 2)
| rose_bind
| rose_connect
| rose_start_heartbeat
rose_release | (wait a time)
case ROSE_STATE_0 |
rose_destroy_socket | rose_heartbeat_expiry
rose_stop_heartbeat |
sock_put(sk) | ...
sock_put(sk) // FREE |
| bh_lock_sock(sk) // USE
The sock is deallocated by sock_put() in rose_release() and
then used by bh_lock_sock() in rose_heartbeat_expiry().
Although rose_destroy_socket() calls rose_stop_heartbeat(),
it could not stop the timer that is running.
The KASAN report triggered by POC is shown below:
BUG: KASAN: use-after-free in _raw_spin_lock+0x5a/0x110
Write of size 4 at addr ffff88800ae59098 by task swapper/3/0
...
Call Trace:
<IRQ>
dump_stack_lvl+0xbf/0xee
print_address_description+0x7b/0x440
print_report+0x101/0x230
? irq_work_single+0xbb/0x140
? _raw_spin_lock+0x5a/0x110
kasan_report+0xed/0x120
? _raw_spin_lock+0x5a/0x110
kasan_check_range+0x2bd/0x2e0
_raw_spin_lock+0x5a/0x110
rose_heartbeat_expiry+0x39/0x370
? rose_start_heartbeat+0xb0/0xb0
call_timer_fn+0x2d/0x1c0
? rose_start_heartbeat+0xb0/0xb0
expire_timers+0x1f3/0x320
__run_timers+0x3ff/0x4d0
run_timer_softirq+0x41/0x80
__do_softirq+0x233/0x544
irq_exit_rcu+0x41/0xa0
sysvec_apic_timer_interrupt+0x8c/0xb0
</IRQ>
<TASK>
asm_sysvec_apic_timer_interrupt+0x1b/0x20
RIP: 0010:default_idle+0xb/0x10
RSP: 0018:ffffc9000012fea0 EFLAGS: 00000202
RAX: 000000000000bcae RBX: ffff888006660f00 RCX: 000000000000bcae
RDX: 0000000000000001 RSI: ffffffff843a11c0 RDI: ffffffff843a1180
RBP: dffffc0000000000 R08: dffffc0000000000 R09: ffffed100da36d46
R10: dfffe9100da36d47 R11: ffffffff83cf0950 R12: 0000000000000000
R13: 1ffff11000ccc1e0 R14: ffffffff8542af28 R15: dffffc0000000000
...
Allocated by task 146:
__kasan_kmalloc+0xc4/0xf0
sk_prot_alloc+0xdd/0x1a0
sk_alloc+0x2d/0x4e0
rose_create+0x7b/0x330
__sock_create+0x2dd/0x640
__sys_socket+0xc7/0x270
__x64_sys_socket+0x71/0x80
do_syscall_64+0x43/0x90
entry_SYSCALL_64_after_hwframe+0x46/0xb0
Freed by task 152:
kasan_set_track+0x4c/0x70
kasan_set_free_info+0x1f/0x40
____kasan_slab_free+0x124/0x190
kfree+0xd3/0x270
__sk_destruct+0x314/0x460
rose_release+0x2fa/0x3b0
sock_close+0xcb/0x230
__fput+0x2d9/0x650
task_work_run+0xd6/0x160
exit_to_user_mode_loop+0xc7/0xd0
exit_to_user_mode_prepare+0x4e/0x80
syscall_exit_to_user_mode+0x20/0x40
do_syscall_64+0x4f/0x90
entry_SYSCALL_64_after_hwframe+0x46/0xb0
This patch adds refcount of sock when we use functions
such as rose_start_heartbeat() and so on to start timer,
and decreases the refcount of sock when timer is finished
or deleted by functions such as rose_stop_heartbeat()
and so on. As a result, the UAF bugs could be mitigated.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
Tested-by: Duoming Zhou <duoming@zju.edu.cn>
Link: https://lore.kernel.org/r/20220629002640.5693-1-duoming@zju.edu.cn
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent f8ebb3a
| File | Mode | Size |
|---|---|---|
| 842 | ||
| crypto | ||
| dim | ||
| fonts | ||
| kunit | ||
| livepatch | ||
| lz4 | ||
| lzo | ||
| math | ||
| mpi | ||
| pldmfw | ||
| raid6 | ||
| reed_solomon | ||
| test_fortify | ||
| vdso | ||
| xz | ||
| zlib_deflate | ||
| zlib_dfltcc | ||
| zlib_inflate | ||
| zstd | ||
| .gitignore | -rw-r--r-- | 174 bytes |
| Kconfig | -rw-r--r-- | 16.5 KB |
| Kconfig.debug | -rw-r--r-- | 87.4 KB |
| Kconfig.kasan | -rw-r--r-- | 6.6 KB |
| Kconfig.kcsan | -rw-r--r-- | 10.0 KB |
| Kconfig.kfence | -rw-r--r-- | 3.6 KB |
| Kconfig.kgdb | -rw-r--r-- | 5.6 KB |
| Kconfig.ubsan | -rw-r--r-- | 5.3 KB |
| Makefile | -rw-r--r-- | 14.0 KB |
| argv_split.c | -rw-r--r-- | 2.1 KB |
| ashldi3.c | -rw-r--r-- | 541 bytes |
| ashrdi3.c | -rw-r--r-- | 565 bytes |
| asn1_decoder.c | -rw-r--r-- | 13.2 KB |
| asn1_encoder.c | -rw-r--r-- | 10.3 KB |
| assoc_array.c | -rw-r--r-- | 51.9 KB |
| atomic64.c | -rw-r--r-- | 4.5 KB |
| atomic64_test.c | -rw-r--r-- | 6.4 KB |
| audit.c | -rw-r--r-- | 1.9 KB |
| bcd.c | -rw-r--r-- | 297 bytes |
| bch.c | -rw-r--r-- | 38.3 KB |
| bitfield_kunit.c | -rw-r--r-- | 4.4 KB |
| bitmap.c | -rw-r--r-- | 46.9 KB |
| bitrev.c | -rw-r--r-- | 1.9 KB |
| bootconfig-data.S | -rw-r--r-- | 275 bytes |
| bootconfig.c | -rw-r--r-- | 21.5 KB |
| bsearch.c | -rw-r--r-- | 1.2 KB |
| btree.c | -rw-r--r-- | 19.2 KB |
| bucket_locks.c | -rw-r--r-- | 1.4 KB |
| bug.c | -rw-r--r-- | 5.9 KB |
| build_OID_registry | -rwxr-xr-x | 4.5 KB |
| buildid.c | -rw-r--r-- | 5.0 KB |
| bust_spinlocks.c | -rw-r--r-- | 676 bytes |
| check_signature.c | -rw-r--r-- | 635 bytes |
| checksum.c | -rw-r--r-- | 4.1 KB |
| clz_ctz.c | -rw-r--r-- | 1.2 KB |
| clz_tab.c | -rw-r--r-- | 891 bytes |
| cmdline.c | -rw-r--r-- | 5.8 KB |
| cmdline_kunit.c | -rw-r--r-- | 4.2 KB |
| cmpdi2.c | -rw-r--r-- | 501 bytes |
| compat_audit.c | -rw-r--r-- | 1002 bytes |
| cpu_rmap.c | -rw-r--r-- | 7.6 KB |
| cpumask.c | -rw-r--r-- | 7.1 KB |
| crc-ccitt.c | -rw-r--r-- | 5.6 KB |
| crc-itu-t.c | -rw-r--r-- | 2.7 KB |
| crc-t10dif.c | -rw-r--r-- | 3.2 KB |
| crc16.c | -rw-r--r-- | 2.7 KB |
| crc32.c | -rw-r--r-- | 9.3 KB |
| crc32defs.h | -rw-r--r-- | 1.6 KB |
| crc32test.c | -rw-r--r-- | 37.4 KB |
| crc4.c | -rw-r--r-- | 1003 bytes |
| crc64-rocksoft.c | -rw-r--r-- | 3.2 KB |
| crc64.c | -rw-r--r-- | 2.6 KB |
| crc7.c | -rw-r--r-- | 2.5 KB |
| crc8.c | -rw-r--r-- | 2.4 KB |
| ctype.c | -rw-r--r-- | 1.4 KB |
| debug_info.c | -rw-r--r-- | 782 bytes |
| debug_locks.c | -rw-r--r-- | 1.2 KB |
| debugobjects.c | -rw-r--r-- | 35.3 KB |
| dec_and_lock.c | -rw-r--r-- | 1.2 KB |
| decompress.c | -rw-r--r-- | 1.8 KB |
| decompress_bunzip2.c | -rw-r--r-- | 23.5 KB |
| decompress_inflate.c | -rw-r--r-- | 4.8 KB |
| decompress_unlz4.c | -rw-r--r-- | 4.2 KB |
| decompress_unlzma.c | -rw-r--r-- | 15.8 KB |
| decompress_unlzo.c | -rw-r--r-- | 6.4 KB |
| decompress_unxz.c | -rw-r--r-- | 10.9 KB |
| decompress_unzstd.c | -rw-r--r-- | 10.2 KB |
| devmem_is_allowed.c | -rw-r--r-- | 683 bytes |
| devres.c | -rw-r--r-- | 14.9 KB |
| digsig.c | -rw-r--r-- | 5.5 KB |
| dump_stack.c | -rw-r--r-- | 3.0 KB |
| dynamic_debug.c | -rw-r--r-- | 27.9 KB |
| dynamic_queue_limits.c | -rw-r--r-- | 4.3 KB |
| earlycpio.c | -rw-r--r-- | 3.6 KB |
| errname.c | -rw-r--r-- | 3.7 KB |
| error-inject.c | -rw-r--r-- | 5.5 KB |
| errseq.c | -rw-r--r-- | 6.6 KB |
| extable.c | -rw-r--r-- | 2.9 KB |
| fault-inject-usercopy.c | -rw-r--r-- | 823 bytes |
| fault-inject.c | -rw-r--r-- | 5.9 KB |
| fdt.c | -rw-r--r-- | 69 bytes |
| fdt_addresses.c | -rw-r--r-- | 79 bytes |
| fdt_empty_tree.c | -rw-r--r-- | 80 bytes |
| fdt_ro.c | -rw-r--r-- | 72 bytes |
| fdt_rw.c | -rw-r--r-- | 72 bytes |
| fdt_strerror.c | -rw-r--r-- | 78 bytes |
| fdt_sw.c | -rw-r--r-- | 72 bytes |
| fdt_wip.c | -rw-r--r-- | 73 bytes |
| find_bit.c | -rw-r--r-- | 3.7 KB |
| find_bit_benchmark.c | -rw-r--r-- | 4.5 KB |
| flex_proportions.c | -rw-r--r-- | 7.2 KB |
| gen_crc32table.c | -rw-r--r-- | 3.3 KB |
| gen_crc64table.c | -rw-r--r-- | 2.1 KB |
| genalloc.c | -rw-r--r-- | 26.4 KB |
| generic-radix-tree.c | -rw-r--r-- | 5.3 KB |
| glob.c | -rw-r--r-- | 3.5 KB |
| globtest.c | -rw-r--r-- | 4.2 KB |
| hexdump.c | -rw-r--r-- | 8.5 KB |
| hweight.c | -rw-r--r-- | 1.9 KB |
| idr.c | -rw-r--r-- | 17.5 KB |
| inflate.c | -rw-r--r-- | 38.7 KB |
| interval_tree.c | -rw-r--r-- | 540 bytes |
| interval_tree_test.c | -rw-r--r-- | 3.4 KB |
| iomap.c | -rw-r--r-- | 9.1 KB |
| iomap_copy.c | -rw-r--r-- | 2.2 KB |
| iommu-helper.c | -rw-r--r-- | 755 bytes |
| iov_iter.c | -rw-r--r-- | 49.2 KB |
| irq_poll.c | -rw-r--r-- | 5.6 KB |
| irq_regs.c | -rw-r--r-- | 394 bytes |
| is_single_threaded.c | -rw-r--r-- | 1.2 KB |
| kasprintf.c | -rw-r--r-- | 1.4 KB |
| kfifo.c | -rw-r--r-- | 12.1 KB |
| klist.c | -rw-r--r-- | 10.4 KB |
| kobject.c | -rw-r--r-- | 27.4 KB |
| kobject_uevent.c | -rw-r--r-- | 18.9 KB |
| kstrtox.c | -rw-r--r-- | 10.8 KB |
| kstrtox.h | -rw-r--r-- | 411 bytes |
| libcrc32c.c | -rw-r--r-- | 2.0 KB |
| linear_ranges.c | -rw-r--r-- | 8.1 KB |
| list-test.c | -rw-r--r-- | 28.0 KB |
| list_debug.c | -rw-r--r-- | 1.9 KB |
| list_sort.c | -rw-r--r-- | 8.2 KB |
| llist.c | -rw-r--r-- | 2.5 KB |
| locking-selftest-hardirq.h | -rw-r--r-- | 246 bytes |
| locking-selftest-mutex.h | -rw-r--r-- | 159 bytes |
| locking-selftest-rlock-hardirq.h | -rw-r--r-- | 74 bytes |
| locking-selftest-rlock-softirq.h | -rw-r--r-- | 74 bytes |
| locking-selftest-rlock.h | -rw-r--r-- | 197 bytes |
| locking-selftest-rsem.h | -rw-r--r-- | 202 bytes |
| locking-selftest-rtmutex.h | -rw-r--r-- | 162 bytes |
| locking-selftest-softirq.h | -rw-r--r-- | 246 bytes |
| locking-selftest-spin-hardirq.h | -rw-r--r-- | 73 bytes |
| locking-selftest-spin-softirq.h | -rw-r--r-- | 73 bytes |
| locking-selftest-spin.h | -rw-r--r-- | 157 bytes |
| locking-selftest-wlock-hardirq.h | -rw-r--r-- | 74 bytes |
| locking-selftest-wlock-softirq.h | -rw-r--r-- | 74 bytes |
| locking-selftest-wlock.h | -rw-r--r-- | 197 bytes |
| locking-selftest-wsem.h | -rw-r--r-- | 202 bytes |
| locking-selftest.c | -rw-r--r-- | 65.6 KB |
| lockref.c | -rw-r--r-- | 4.4 KB |
| logic_iomem.c | -rw-r--r-- | 7.2 KB |
| logic_pio.c | -rw-r--r-- | 8.5 KB |
| lru_cache.c | -rw-r--r-- | 18.8 KB |
| lshrdi3.c | -rw-r--r-- | 559 bytes |
| memcat_p.c | -rw-r--r-- | 753 bytes |
| memcpy_kunit.c | -rw-r--r-- | 8.0 KB |
| memneq.c | -rw-r--r-- | 6.4 KB |
| memory-notifier-error-inject.c | -rw-r--r-- | 1.1 KB |
| memregion.c | -rw-r--r-- | 429 bytes |
| memweight.c | -rw-r--r-- | 1.0 KB |
| muldi3.c | -rw-r--r-- | 1.7 KB |
| net_utils.c | -rw-r--r-- | 640 bytes |
| netdev-notifier-error-inject.c | -rw-r--r-- | 1.5 KB |
| nlattr.c | -rw-r--r-- | 26.9 KB |
| nmi_backtrace.c | -rw-r--r-- | 3.3 KB |
| nodemask.c | -rw-r--r-- | 671 bytes |
| notifier-error-inject.c | -rw-r--r-- | 2.5 KB |
| notifier-error-inject.h | -rw-r--r-- | 653 bytes |
| objagg.c | -rw-r--r-- | 28.2 KB |
| of-reconfig-notifier-error-inject.c | -rw-r--r-- | 1.3 KB |
| oid_registry.c | -rw-r--r-- | 4.4 KB |
| once.c | -rw-r--r-- | 1.5 KB |
| overflow_kunit.c | -rw-r--r-- | 25.1 KB |
| packing.c | -rw-r--r-- | 6.5 KB |
| parman.c | -rw-r--r-- | 10.6 KB |
| parser.c | -rw-r--r-- | 8.9 KB |
| pci_iomap.c | -rw-r--r-- | 5.7 KB |
| percpu-refcount.c | -rw-r--r-- | 15.3 KB |
| percpu_counter.c | -rw-r--r-- | 6.4 KB |
| percpu_test.c | -rw-r--r-- | 3.2 KB |
| plist.c | -rw-r--r-- | 5.9 KB |
| pm-notifier-error-inject.c | -rw-r--r-- | 1.2 KB |
| polynomial.c | -rw-r--r-- | 3.6 KB |
| radix-tree.c | -rw-r--r-- | 43.1 KB |
| random32.c | -rw-r--r-- | 9.1 KB |
| ratelimit.c | -rw-r--r-- | 1.6 KB |
| rbtree.c | -rw-r--r-- | 17.1 KB |
| rbtree_test.c | -rw-r--r-- | 9.4 KB |
| ref_tracker.c | -rw-r--r-- | 4.0 KB |
| refcount.c | -rw-r--r-- | 4.8 KB |
| rhashtable.c | -rw-r--r-- | 29.5 KB |
| sbitmap.c | -rw-r--r-- | 19.2 KB |
| scatterlist.c | -rw-r--r-- | 28.1 KB |
| seq_buf.c | -rw-r--r-- | 10.0 KB |
| sg_pool.c | -rw-r--r-- | 4.2 KB |
| sg_split.c | -rw-r--r-- | 5.0 KB |
| sha1.c | -rw-r--r-- | 4.4 KB |
| show_mem.c | -rw-r--r-- | 1.1 KB |
| siphash.c | -rw-r--r-- | 11.6 KB |
| slub_kunit.c | -rw-r--r-- | 3.4 KB |
| smp_processor_id.c | -rw-r--r-- | 1.4 KB |
| sort.c | -rw-r--r-- | 8.9 KB |
| stackdepot.c | -rw-r--r-- | 13.6 KB |
| stackinit_kunit.c | -rw-r--r-- | 13.9 KB |
| stmp_device.c | -rw-r--r-- | 1.9 KB |
| string.c | -rw-r--r-- | 20.8 KB |
| string_helpers.c | -rw-r--r-- | 23.0 KB |
| strncpy_from_user.c | -rw-r--r-- | 3.9 KB |
| strnlen_user.c | -rw-r--r-- | 3.4 KB |
| syscall.c | -rw-r--r-- | 2.7 KB |
| test-kstrtox.c | -rw-r--r-- | 17.3 KB |
| test-string_helpers.c | -rw-r--r-- | 14.9 KB |
| test_bitmap.c | -rw-r--r-- | 29.3 KB |
| test_bitops.c | -rw-r--r-- | 2.5 KB |
| test_bits.c | -rw-r--r-- | 1.8 KB |
| test_blackhole_dev.c | -rw-r--r-- | 2.5 KB |
| test_bpf.c | -rw-r--r-- | 356.3 KB |
| test_debug_virtual.c | -rw-r--r-- | 981 bytes |
| test_firmware.c | -rw-r--r-- | 36.5 KB |
| test_fprobe.c | -rw-r--r-- | 4.2 KB |
| test_fpu.c | -rw-r--r-- | 2.0 KB |
| test_free_pages.c | -rw-r--r-- | 995 bytes |
| test_hash.c | -rw-r--r-- | 6.5 KB |
| test_hexdump.c | -rw-r--r-- | 6.3 KB |
| test_hmm.c | -rw-r--r-- | 29.8 KB |
| test_hmm_uapi.h | -rw-r--r-- | 2.4 KB |
| test_ida.c | -rw-r--r-- | 4.3 KB |
| test_kasan.c | -rw-r--r-- | 37.3 KB |
| test_kasan_module.c | -rw-r--r-- | 3.3 KB |
| test_kmod.c | -rw-r--r-- | 29.9 KB |
| test_kprobes.c | -rw-r--r-- | 9.4 KB |
| test_linear_ranges.c | -rw-r--r-- | 7.5 KB |
| test_list_sort.c | -rw-r--r-- | 3.3 KB |
| test_lockup.c | -rw-r--r-- | 16.5 KB |
| test_memcat_p.c | -rw-r--r-- | 2.2 KB |
| test_meminit.c | -rw-r--r-- | 9.9 KB |
| test_min_heap.c | -rw-r--r-- | 4.3 KB |
| test_module.c | -rw-r--r-- | 794 bytes |
| test_objagg.c | -rw-r--r-- | 24.6 KB |
| test_parman.c | -rw-r--r-- | 11.2 KB |
| test_printf.c | -rw-r--r-- | 18.7 KB |
| test_ref_tracker.c | -rw-r--r-- | 3.1 KB |
| test_rhashtable.c | -rw-r--r-- | 20.0 KB |
| test_scanf.c | -rw-r--r-- | 28.9 KB |
| test_siphash.c | -rw-r--r-- | 7.5 KB |
| test_sort.c | -rw-r--r-- | 907 bytes |
| test_static_key_base.c | -rw-r--r-- | 1.6 KB |
| test_static_keys.c | -rw-r--r-- | 5.6 KB |
| test_string.c | -rw-r--r-- | 4.6 KB |
| test_strscpy.c | -rw-r--r-- | 4.0 KB |
| test_sysctl.c | -rw-r--r-- | 4.6 KB |
| test_ubsan.c | -rw-r--r-- | 2.4 KB |
| test_user_copy.c | -rw-r--r-- | 9.1 KB |
| test_uuid.c | -rw-r--r-- | 3.4 KB |
| test_vmalloc.c | -rw-r--r-- | 10.9 KB |
| test_xarray.c | -rw-r--r-- | 47.2 KB |
| textsearch.c | -rw-r--r-- | 9.3 KB |
| timerqueue.c | -rw-r--r-- | 2.3 KB |
| ts_bm.c | -rw-r--r-- | 5.1 KB |
| ts_fsm.c | -rw-r--r-- | 10.4 KB |
| ts_kmp.c | -rw-r--r-- | 4.1 KB |
| ubsan.c | -rw-r--r-- | 9.7 KB |
| ubsan.h | -rw-r--r-- | 1.8 KB |
| ucmpdi2.c | -rw-r--r-- | 568 bytes |
| ucs2_string.c | -rw-r--r-- | 2.5 KB |
| usercopy.c | -rw-r--r-- | 2.2 KB |
| uuid.c | -rw-r--r-- | 2.9 KB |
| vsprintf.c | -rw-r--r-- | 86.8 KB |
| win_minmax.c | -rw-r--r-- | 3.4 KB |
| xarray.c | -rw-r--r-- | 58.8 KB |
| xxhash.c | -rw-r--r-- | 12.7 KB |
Computing file changes ...
