Revision 9ecfe875c4f311618cc918aded716017dcd2ddf1 authored by Karicheri, Muralidharan on 19 February 2016, 17:58:42 UTC, committed by David S. Miller on 22 February 2016, 03:03:15 UTC
The commit 899077791403 ("netcp: try to reduce type confusion in
descriptors") introduces a regression in Kernel 4.5-rc1 and it breaks
get/set_pad_info() functionality.

The TI NETCP driver uses pad0 and pad1 fields of knav_dma_desc to
store DMA/MEM buffer pointer and buffer size respectively. And in both
cases for Keystone 2 the pointer type size is 32 bit regardless of
LAPE enabled or not, because CONFIG_ARCH_DMA_ADDR_T_64BIT originally
is not expected to be defined.

Unfortunately, above commit changed buffer's pointers save/restore
code (get/set_pad_info()) and added intermediate conversation to u64
which works incorrectly on 32bit Keystone 2 and causes TI NETCP driver
crash in RX/TX path due to "Unable to handle kernel NULL pointer"
exception. This issue was reported and discussed in [1].

Hence, fix it by partially reverting above commit and restoring
get/set_pad_info() functionality as it was before.

[1] https://www.mail-archive.com/netdev@vger.kernel.org/msg95361.html
Cc: Wingman Kwok <w-kwok2@ti.com>
Cc: Mugunthan V N <mugunthanvnm@ti.com>
CC: David Laight <David.Laight@ACULAB.COM>
CC: Arnd Bergmann <arnd@arndb.de>
Reported-by: Franklin S Cooper Jr <fcooper@ti.com>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 3301be3
History
File Mode Size
kasan
Kconfig -rw-r--r-- 22.4 KB
Kconfig.debug -rw-r--r-- 1.2 KB
Makefile -rw-r--r-- 2.7 KB
backing-dev.c -rw-r--r-- 26.4 KB
balloon_compaction.c -rw-r--r-- 6.6 KB
bootmem.c -rw-r--r-- 21.0 KB
cleancache.c -rw-r--r-- 9.9 KB
cma.c -rw-r--r-- 12.1 KB
cma.h -rw-r--r-- 515 bytes
cma_debug.c -rw-r--r-- 4.4 KB
compaction.c -rw-r--r-- 48.3 KB
debug-pagealloc.c -rw-r--r-- 2.6 KB
debug.c -rw-r--r-- 6.6 KB
dmapool.c -rw-r--r-- 13.9 KB
early_ioremap.c -rw-r--r-- 6.2 KB
fadvise.c -rw-r--r-- 3.7 KB
failslab.c -rw-r--r-- 1.3 KB
filemap.c -rw-r--r-- 74.1 KB
frame_vector.c -rw-r--r-- 6.2 KB
frontswap.c -rw-r--r-- 14.3 KB
gup.c -rw-r--r-- 41.1 KB
highmem.c -rw-r--r-- 11.8 KB
huge_memory.c -rw-r--r-- 92.8 KB
hugetlb.c -rw-r--r-- 117.8 KB
hugetlb_cgroup.c -rw-r--r-- 10.5 KB
hwpoison-inject.c -rw-r--r-- 3.2 KB
init-mm.c -rw-r--r-- 619 bytes
internal.h -rw-r--r-- 14.4 KB
interval_tree.c -rw-r--r-- 3.1 KB
kmemcheck.c -rw-r--r-- 2.9 KB
kmemleak-test.c -rw-r--r-- 3.2 KB
kmemleak.c -rw-r--r-- 54.5 KB
ksm.c -rw-r--r-- 62.9 KB
list_lru.c -rw-r--r-- 12.6 KB
maccess.c -rw-r--r-- 3.1 KB
madvise.c -rw-r--r-- 18.5 KB
memblock.c -rw-r--r-- 48.6 KB
memcontrol.c -rw-r--r-- 151.7 KB
memory-failure.c -rw-r--r-- 48.9 KB
memory.c -rw-r--r-- 105.4 KB
memory_hotplug.c -rw-r--r-- 53.2 KB
mempolicy.c -rw-r--r-- 71.2 KB
mempool.c -rw-r--r-- 14.0 KB
memtest.c -rw-r--r-- 2.7 KB
migrate.c -rw-r--r-- 47.7 KB
mincore.c -rw-r--r-- 6.7 KB
mlock.c -rw-r--r-- 21.0 KB
mm_init.c -rw-r--r-- 4.9 KB
mmap.c -rw-r--r-- 91.5 KB
mmu_context.c -rw-r--r-- 1.3 KB
mmu_notifier.c -rw-r--r-- 11.7 KB
mmzone.c -rw-r--r-- 2.4 KB
mprotect.c -rw-r--r-- 11.0 KB
mremap.c -rw-r--r-- 15.2 KB
msync.c -rw-r--r-- 2.6 KB
nobootmem.c -rw-r--r-- 11.1 KB
nommu.c -rw-r--r-- 51.9 KB
oom_kill.c -rw-r--r-- 20.8 KB
page-writeback.c -rw-r--r-- 84.0 KB
page_alloc.c -rw-r--r-- 189.7 KB
page_counter.c -rw-r--r-- 4.8 KB
page_ext.c -rw-r--r-- 10.4 KB
page_idle.c -rw-r--r-- 5.4 KB
page_io.c -rw-r--r-- 9.2 KB
page_isolation.c -rw-r--r-- 8.4 KB
page_owner.c -rw-r--r-- 7.1 KB
pagewalk.c -rw-r--r-- 7.5 KB
percpu-km.c -rw-r--r-- 2.8 KB
percpu-vm.c -rw-r--r-- 10.0 KB
percpu.c -rw-r--r-- 65.9 KB
pgtable-generic.c -rw-r--r-- 5.3 KB
process_vm_access.c -rw-r--r-- 9.8 KB
quicklist.c -rw-r--r-- 2.4 KB
readahead.c -rw-r--r-- 15.3 KB
rmap.c -rw-r--r-- 49.9 KB
shmem.c -rw-r--r-- 90.9 KB
slab.c -rw-r--r-- 107.4 KB
slab.h -rw-r--r-- 10.5 KB
slab_common.c -rw-r--r-- 30.0 KB
slob.c -rw-r--r-- 16.0 KB
slub.c -rw-r--r-- 133.0 KB
sparse-vmemmap.c -rw-r--r-- 7.8 KB
sparse.c -rw-r--r-- 20.9 KB
swap.c -rw-r--r-- 26.2 KB
swap_cgroup.c -rw-r--r-- 4.6 KB
swap_state.c -rw-r--r-- 13.1 KB
swapfile.c -rw-r--r-- 77.3 KB
truncate.c -rw-r--r-- 23.9 KB
userfaultfd.c -rw-r--r-- 7.2 KB
util.c -rw-r--r-- 11.4 KB
vmacache.c -rw-r--r-- 3.1 KB
vmalloc.c -rw-r--r-- 68.0 KB
vmpressure.c -rw-r--r-- 12.5 KB
vmscan.c -rw-r--r-- 112.0 KB
vmstat.c -rw-r--r-- 42.4 KB
workingset.c -rw-r--r-- 13.6 KB
zbud.c -rw-r--r-- 18.2 KB
zpool.c -rw-r--r-- 10.0 KB
zsmalloc.c -rw-r--r-- 48.2 KB
zswap.c -rw-r--r-- 32.0 KB

back to top