Revision a0c7b4d526ce592ca241cb78b3bb148a9cfd62cc authored by Yanqin Jin on 18 May 2018, 14:58:59 UTC, committed by Facebook Github Bot on 18 May 2018, 15:11:55 UTC
Summary:
In the past, the default value of max_manifest_file_size is uint64_t::MAX,
allowing a long running RocksDB process to grow its MANIFEST file to take up
the entire disk, as reported in [issue 3851](https://github.com/facebook/rocksdb/issues/3851). It is reasonable and common to provide a default non-max value for this option. Therefore, I set the value to 1GB.

siying miasantreble Please let me know whether this looks good to you. Thanks!
Closes https://github.com/facebook/rocksdb/pull/3867

Differential Revision: D8051524

Pulled By: riversand963

fbshipit-source-id: 50251f0804b1fa933a19a30d19d261ea8b9d2b72
1 parent 17af09f
History
File Mode Size
file_read_sample.h -rw-r--r-- 801 bytes
histogram.cc -rw-r--r-- 9.2 KB
histogram.h -rw-r--r-- 4.4 KB
histogram_test.cc -rw-r--r-- 7.1 KB
histogram_windowing.cc -rw-r--r-- 6.3 KB
histogram_windowing.h -rw-r--r-- 2.8 KB
instrumented_mutex.cc -rw-r--r-- 2.0 KB
instrumented_mutex.h -rw-r--r-- 2.3 KB
iostats_context.cc -rw-r--r-- 1.6 KB
iostats_context_imp.h -rw-r--r-- 1.7 KB
iostats_context_test.cc -rw-r--r-- 979 bytes
perf_context.cc -rw-r--r-- 6.4 KB
perf_context_imp.h -rw-r--r-- 2.1 KB
perf_level.cc -rw-r--r-- 683 bytes
perf_level_imp.h -rw-r--r-- 496 bytes
perf_step_timer.h -rw-r--r-- 1.8 KB
statistics.cc -rw-r--r-- 6.0 KB
statistics.h -rw-r--r-- 3.8 KB
statistics_test.cc -rw-r--r-- 1.0 KB
thread_status_impl.cc -rw-r--r-- 4.8 KB
thread_status_updater.cc -rw-r--r-- 11.0 KB
thread_status_updater.h -rw-r--r-- 8.5 KB
thread_status_updater_debug.cc -rw-r--r-- 1.3 KB
thread_status_util.cc -rw-r--r-- 7.1 KB
thread_status_util.h -rw-r--r-- 5.1 KB
thread_status_util_debug.cc -rw-r--r-- 966 bytes

back to top