Skip to main content

Browse the archive

Revision a0c7b4d526ce592ca241cb78b3bb148a9cfd62cc authored by Yanqin Jin on 18 May 2018, 14:58:59 UTC, committed by Facebook Github Bot on 18 May 2018, 15:11:55 UTC 
Set the default value of max_manifest_file_size.
 
Summary:
In the past, the default value of max_manifest_file_size is uint64_t::MAX,
allowing a long running RocksDB process to grow its MANIFEST file to take up
the entire disk, as reported in [issue 3851](https://github.com/facebook/rocksdb/issues/3851). It is reasonable and common to provide a default non-max value for this option. Therefore, I set the value to 1GB.

siying miasantreble Please let me know whether this looks good to you. Thanks!
Closes https://github.com/facebook/rocksdb/pull/3867

Differential Revision: D8051524

Pulled By: riversand963

fbshipit-source-id: 50251f0804b1fa933a19a30d19d261ea8b9d2b72
1 parent 17af09f
History
File Mode Size
backupable
blob_db
cassandra
checkpoint
compaction_filters
convenience
date_tiered
document
geodb
leveldb_options
lua
memory
merge_operators
option_change_migration
options
persistent_cache
redis
simulator_cache
spatialdb
table_properties_collectors
transactions
ttl
write_batch_with_index
col_buf_decoder.cc -rw-r--r-- 6.6 KB
col_buf_decoder.h -rw-r--r-- 3.7 KB
col_buf_encoder.cc -rw-r--r-- 5.9 KB
col_buf_encoder.h -rw-r--r-- 7.8 KB
column_aware_encoding_exp.cc -rw-r--r-- 6.2 KB
column_aware_encoding_test.cc -rw-r--r-- 8.7 KB
column_aware_encoding_util.cc -rw-r--r-- 17.9 KB
column_aware_encoding_util.h -rw-r--r-- 2.8 KB
debug.cc -rw-r--r-- 1.7 KB
env_librados.cc -rw-r--r-- 36.1 KB
env_librados.md -rw-r--r-- 4.6 KB
env_librados_test.cc -rw-r--r-- 34.4 KB
env_mirror.cc -rw-r--r-- 7.7 KB
env_mirror_test.cc -rw-r--r-- 7.0 KB
env_timed.cc -rw-r--r-- 5.4 KB
env_timed_test.cc -rw-r--r-- 1.2 KB
merge_operators.h -rw-r--r-- 1.8 KB
object_registry_test.cc -rw-r--r-- 2.1 KB
util_merge_operators_test.cc -rw-r--r-- 3.2 KB
back to top