Revision a0e9ee5965dc773bd92f5b3fffd1a0c602ec135c authored by Igor Canadi on 15 May 2014, 23:07:05 UTC, committed by Igor Canadi on 15 May 2014, 23:07:05 UTC
Summary:
This diff adds rapidjson (https://code.google.com/p/rapidjson/) to RocksDB repository. First step to adding JSON is to add a JSON parser :)

I'm not sure if rapidjson is the right choice. I only considered folly as an alternative. Using folly JSON parser has serious downsides. I tried extracting folly::json from the folly library. However, it depends on folly::dynamic, which basically depends on everything else. I would prefer to avoid adding complete folly library as RocksDB dependency. Folly has a lot of its own dependencies (https://github.com/facebook/folly) and also looks like open source world has some trouble installing it (https://groups.google.com/forum/#!forum/facebook-folly -- 60% of the posts are compile errors). We can discuss this if you think otherwise.

RapidJSON does not have any dependencies whatsoever. No boost, no STL. We don't need to compile it since it's all header files. The performance results are also impressive: https://code.google.com/p/rapidjson/wiki/Performance. However, I'll make sure to write code in a way that we can easily switch JSON implementations going forward. Quora thread has some alternatives: http://www.quora.com/What-is-the-best-C-JSON-library

Test Plan: none

Reviewers: dhruba, haobo, yhchiang, sdong, jamesgpearce

Reviewed By: haobo

CC: leveldb

Differential Revision: https://reviews.facebook.net/D18729
1 parent 0b3d03d
History
File Mode Size
doc.css -rw-r--r-- 1.1 KB
index.html -rw-r--r-- 35.1 KB
log_format.txt -rw-r--r-- 2.7 KB
rockslogo.jpg -rw-r--r-- 134.0 KB
rockslogo.png -rw-r--r-- 60.3 KB

back to top