swh:1:snp:5115096b921df712aeb2a08114fede57fb3331fb
Revision a0e9ee5965dc773bd92f5b3fffd1a0c602ec135c authored by Igor Canadi on 15 May 2014, 23:07:05 UTC, committed by Igor Canadi on 15 May 2014, 23:07:05 UTC
Summary:
This diff adds rapidjson (https://code.google.com/p/rapidjson/) to RocksDB repository. First step to adding JSON is to add a JSON parser :)

I'm not sure if rapidjson is the right choice. I only considered folly as an alternative. Using folly JSON parser has serious downsides. I tried extracting folly::json from the folly library. However, it depends on folly::dynamic, which basically depends on everything else. I would prefer to avoid adding complete folly library as RocksDB dependency. Folly has a lot of its own dependencies (https://github.com/facebook/folly) and also looks like open source world has some trouble installing it (https://groups.google.com/forum/#!forum/facebook-folly -- 60% of the posts are compile errors). We can discuss this if you think otherwise.

RapidJSON does not have any dependencies whatsoever. No boost, no STL. We don't need to compile it since it's all header files. The performance results are also impressive: https://code.google.com/p/rapidjson/wiki/Performance. However, I'll make sure to write code in a way that we can easily switch JSON implementations going forward. Quora thread has some alternatives: http://www.quora.com/What-is-the-best-C-JSON-library

Test Plan: none

Reviewers: dhruba, haobo, yhchiang, sdong, jamesgpearce

Reviewed By: haobo

CC: leveldb

Differential Revision: https://reviews.facebook.net/D18729
1 parent 0b3d03d
History
Tip revision: 19076c95aa2bcee55c26fcf0960cc844ad86ee9c authored by Levi Tamasi on 21 January 2021, 22:18:25 UTC
Update HISTORY.md for PR 7888 (#7890)
Tip revision: 19076c9
File Mode Size
build_tools
coverage
db
doc
examples
hdfs
helpers
include
java
linters
port
table
third-party
tools
util
utilities
.arcconfig -rw-r--r-- 246 bytes
.clang-format -rw-r--r-- 138 bytes
.gitignore -rw-r--r-- 325 bytes
.travis.yml -rw-r--r-- 1.0 KB
CONTRIBUTING.md -rw-r--r-- 759 bytes
HISTORY.md -rw-r--r-- 5.8 KB
INSTALL.md -rw-r--r-- 3.4 KB
LICENSE -rw-r--r-- 1.6 KB
Makefile -rw-r--r-- 20.3 KB
PATENTS -rw-r--r-- 1.4 KB
README.md -rw-r--r-- 1.3 KB
ROCKSDB_LITE.md -rw-r--r-- 1020 bytes

README.md

back to top