https://github.com/torvalds/linux
Revision a4412fdd49dc011bcc2c0d81ac4cab7457092650 authored by Steven Rostedt (Google) on 21 November 2022, 15:44:03 UTC, committed by Linus Torvalds on 01 December 2022, 21:14:21 UTC
The config to be able to inject error codes into any function annotated
with ALLOW_ERROR_INJECTION() is enabled when FUNCTION_ERROR_INJECTION is
enabled.  But unfortunately, this is always enabled on x86 when KPROBES
is enabled, and there's no way to turn it off.

As kprobes is useful for observability of the kernel, it is useful to
have it enabled in production environments.  But error injection should
be avoided.  Add a prompt to the config to allow it to be disabled even
when kprobes is enabled, and get rid of the "def_bool y".

This is a kernel debug feature (it's in Kconfig.debug), and should have
never been something enabled by default.

Cc: stable@vger.kernel.org
Fixes: 540adea3809f6 ("error-injection: Separate error-injection from kprobe")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 355479c
History
Tip revision: a4412fdd49dc011bcc2c0d81ac4cab7457092650 authored by Steven Rostedt (Google) on 21 November 2022, 15:44:03 UTC
error-injection: Add prompt for function error injection
Tip revision: a4412fd
File Mode Size
6fire
bcd2000
caiaq
hiface
line6
misc
usx2y
Kconfig -rw-r--r-- 4.7 KB
Makefile -rw-r--r-- 817 bytes
card.c -rw-r--r-- 32.6 KB
card.h -rw-r--r-- 8.2 KB
clock.c -rw-r--r-- 16.1 KB
clock.h -rw-r--r-- 474 bytes
endpoint.c -rw-r--r-- 48.1 KB
endpoint.h -rw-r--r-- 2.3 KB
format.c -rw-r--r-- 21.4 KB
format.h -rw-r--r-- 489 bytes
helper.c -rw-r--r-- 2.8 KB
helper.h -rw-r--r-- 1.3 KB
implicit.c -rw-r--r-- 14.6 KB
implicit.h -rw-r--r-- 478 bytes
media.c -rw-r--r-- 8.1 KB
media.h -rw-r--r-- 2.4 KB
midi.c -rw-r--r-- 72.3 KB
midi.h -rw-r--r-- 2.0 KB
mixer.c -rw-r--r-- 97.9 KB
mixer.h -rw-r--r-- 3.7 KB
mixer_maps.c -rw-r--r-- 21.1 KB
mixer_quirks.c -rw-r--r-- 95.5 KB
mixer_quirks.h -rw-r--r-- 631 bytes
mixer_s1810c.c -rw-r--r-- 15.3 KB
mixer_s1810c.h -rw-r--r-- 210 bytes
mixer_scarlett.c -rw-r--r-- 28.1 KB
mixer_scarlett.h -rw-r--r-- 208 bytes
mixer_scarlett_gen2.c -rw-r--r-- 113.6 KB
mixer_scarlett_gen2.h -rw-r--r-- 217 bytes
mixer_us16x08.c -rw-r--r-- 37.3 KB
mixer_us16x08.h -rw-r--r-- 4.0 KB
pcm.c -rw-r--r-- 46.2 KB
pcm.h -rw-r--r-- 540 bytes
power.c -rw-r--r-- 2.5 KB
power.h -rw-r--r-- 743 bytes
proc.c -rw-r--r-- 7.3 KB
proc.h -rw-r--r-- 250 bytes
quirks-table.h -rw-r--r-- 103.5 KB
quirks.c -rw-r--r-- 68.9 KB
quirks.h -rw-r--r-- 1.6 KB
stream.c -rw-r--r-- 32.1 KB
stream.h -rw-r--r-- 325 bytes
usbaudio.h -rw-r--r-- 6.2 KB
validate.c -rw-r--r-- 10.0 KB

back to top