Revision a5739435b5a3b8c449f8844ecd71a3b1e89f0a33 authored by Al Viro on 05 December 2017, 23:27:57 UTC, committed by David S. Miller on 05 December 2017, 23:39:28 UTC
1) it's fput() or sock_release(), not both
2) don't do fd_install() until the last failure exit.
3) not a bug per se, but... don't attach socket to struct file
   until it's set up.

Take reserving descriptor into the caller, move fd_install() to the
caller, sanitize failure exits and calling conventions.

Cc: stable@vger.kernel.org # v4.6+
Acked-by: Tom Herbert <tom@herbertland.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 69c6486
History

back to top