Revision a6a6d3b1f867d34ba5bd61aa7bb056b48ca67cff authored by Arnd Bergmann on 12 July 2019, 09:12:30 UTC, committed by Paolo Bonzini on 15 July 2019, 10:50:30 UTC
clang finds a contruct suspicious that converts an unsigned
character to a signed integer and back, causing an overflow:
arch/x86/kvm/mmu.c:4605:39: error: implicit conversion from 'int' to 'u8' (aka 'unsigned char') changes value from -205 to 51 [-Werror,-Wconstant-conversion]
u8 wf = (pfec & PFERR_WRITE_MASK) ? ~w : 0;
~~ ^~
arch/x86/kvm/mmu.c:4607:38: error: implicit conversion from 'int' to 'u8' (aka 'unsigned char') changes value from -241 to 15 [-Werror,-Wconstant-conversion]
u8 uf = (pfec & PFERR_USER_MASK) ? ~u : 0;
~~ ^~
arch/x86/kvm/mmu.c:4609:39: error: implicit conversion from 'int' to 'u8' (aka 'unsigned char') changes value from -171 to 85 [-Werror,-Wconstant-conversion]
u8 ff = (pfec & PFERR_FETCH_MASK) ? ~x : 0;
~~ ^~
Add an explicit cast to tell clang that everything works as
intended here.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://github.com/ClangBuiltLinux/linux/issues/95
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
1 parent f4e4805
| File | Mode | Size |
|---|---|---|
| apparmor | ||
| integrity | ||
| keys | ||
| loadpin | ||
| safesetid | ||
| selinux | ||
| smack | ||
| tomoyo | ||
| yama | ||
| Kconfig | -rw-r--r-- | 10.6 KB |
| Kconfig.hardening | -rw-r--r-- | 7.6 KB |
| Makefile | -rw-r--r-- | 1.1 KB |
| commoncap.c | -rw-r--r-- | 38.9 KB |
| device_cgroup.c | -rw-r--r-- | 20.5 KB |
| inode.c | -rw-r--r-- | 10.4 KB |
| lsm_audit.c | -rw-r--r-- | 10.6 KB |
| min_addr.c | -rw-r--r-- | 1.3 KB |
| security.c | -rw-r--r-- | 58.0 KB |
Computing file changes ...
