Skip to main content

Browse the archive

https://github.com/torvalds/linux
23 October 2021, 00:29:24 UTC
Revision a6f74333548f56afb413fc928ae1aefc4fe7608f authored by Dmytro Linkin on 25 August 2021, 14:51:26 UTC, committed by Saeed Mahameed on 20 October 2021, 17:42:49 UTC 
net/mlx5: E-switch, Return correct error code on group creation failure
 
Dan Carpenter report:
The patch f47e04eb96e0: "net/mlx5: E-switch, Allow setting share/max
tx rate limits of rate groups" from May 31, 2021, leads to the
following Smatch static checker warning:

	drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:483 esw_qos_create_rate_group()
	warn: passing zero to 'ERR_PTR'

If min rate normalization failed then error code may be overwritten to 0
if scheduling element destruction succeed. Ignore this value and always
return initial one.

Fixes: f47e04eb96e0 ("net/mlx5: E-switch, Allow setting share/max tx rate limits of rate groups")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dmytro Linkin <dlinkin@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
1 parent 14fe247
History
Tip revision: a6f74333548f56afb413fc928ae1aefc4fe7608f authored by Dmytro Linkin on 25 August 2021, 14:51:26 UTC
net/mlx5: E-switch, Return correct error code on group creation failure
Tip revision: a6f7433
File Mode Size
Kconfig -rw-r--r-- 76.0 KB
Makefile -rw-r--r-- 1.1 KB
calibrate.c -rw-r--r-- 8.6 KB
do_mounts.c -rw-r--r-- 15.6 KB
do_mounts.h -rw-r--r-- 908 bytes
do_mounts_initrd.c -rw-r--r-- 3.4 KB
do_mounts_rd.c -rw-r--r-- 7.7 KB
init_task.c -rw-r--r-- 6.2 KB
initramfs.c -rw-r--r-- 16.3 KB
main.c -rw-r--r-- 39.5 KB
noinitramfs.c -rw-r--r-- 862 bytes
version.c -rw-r--r-- 1.1 KB
back to top