Skip to main content

Browse the archive

https://github.com/torvalds/linux
23 October 2021, 00:29:24 UTC
Revision aac27c7a0d76683f7f4bdf41cec174db2819f635 authored by Russell King on 25 August 2015, 08:49:53 UTC, committed by David S. Miller on 25 August 2015, 23:33:16 UTC 
net: fec: use reinit_completion() in mdio accessor functions
 
Rather than re-initialising the entire completion on every mdio access,
use reinit_completion() which only resets the completion count.  This
avoids possible reinitialisation of the contained spinlock and waitqueue
while they may be in use (eg, mid-completion.)

Such an event could occur if there's a long delay in interrupt handling
causing the mdio accessor to time out, then a second access comes in
while the interrupt handler on a different CPU has called complete().
Another scenario where this has been observed is while locking has
been missing at the phy layer, allowing concurrent attempts to access
the MDIO bus.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 05a7f58
History
Tip revision: aac27c7a0d76683f7f4bdf41cec174db2819f635 authored by Russell King on 25 August 2015, 08:49:53 UTC
net: fec: use reinit_completion() in mdio accessor functions
Tip revision: aac27c7
File Mode Size
alpha
arc
arm
arm64
avr32
blackfin
c6x
cris
frv
h8300
hexagon
ia64
m32r
m68k
metag
microblaze
mips
mn10300
nios2
openrisc
parisc
powerpc
s390
score
sh
sparc
tile
um
unicore32
x86
xtensa
.gitignore -rw-r--r-- 12 bytes
Kconfig -rw-r--r-- 16.3 KB
back to top