Revision aba91192ae39cd1a2f79e7ed91e966df3cfe10b7 authored by Carlos Rica on 09 September 2007, 00:39:29 UTC, committed by Junio C Hamano on 10 September 2007, 04:30:54 UTC
Most of this patch code and message was written by Shawn O. Pearce. I made some tests to know what the problem was, and then I changed the code related with the SIGPIPE signal. If the user has misconfigured `user.signingkey` in their .git/config or just doesn't have any secret keys on their keyring and they ask for a signed tag with `git tag -s` we better make sure the resulting tag was actually signed by gpg. Prior versions of builtin git-tag allowed this failure to slip by without error as they were not checking the return value of the finish_command() so they did not notice when gpg exited with an error exit status. They also did not fail if gpg produced an empty output or if read_in_full received an error from the read system call while trying to read the pipe back from gpg. Finally, we did not actually honor any return value from the do_sign function as it returns ssize_t but was being stored into an unsigned long. This caused the compiler to optimize out the die condition, allowing git-tag to continue along and create the tag object. However, when gpg gets a wrong username, it exits before any read was done and then the writing process receives SIGPIPE and program is terminated. By ignoring this signal, anyway, the function write_or_die gets EPIPE from write_in_full and exits returning 0 to the system without a message. Here we better call to write_in_full directly so we can fail printing a message and return safely to the caller. With these issues fixed `git-tag -s` will now fail to create the tag and will report a non-zero exit status to its caller, thereby allowing automated helper scripts to detect (and recover from) failure if gpg is not working properly. Proposed-by: Shawn O. Pearce <spearce@spearce.org> Signed-off-by: Carlos Rica <jasampler@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 7b02b85
File | Mode | Size |
---|---|---|
hstrerror.c | -rw-r--r-- | 513 bytes |
inet_ntop.c | -rw-r--r-- | 5.0 KB |
inet_pton.c | -rw-r--r-- | 6.9 KB |
mmap.c | -rw-r--r-- | 747 bytes |
pread.c | -rw-r--r-- | 433 bytes |
setenv.c | -rw-r--r-- | 786 bytes |
strcasestr.c | -rw-r--r-- | 431 bytes |
strlcpy.c | -rw-r--r-- | 247 bytes |
strtoumax.c | -rw-r--r-- | 217 bytes |
unsetenv.c | -rw-r--r-- | 558 bytes |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...