Revision ac06c06770bb8761b1f1f9bdf2f5420fa6d3e9fa authored by Clemens Ladisch on 21 December 2009, 23:36:44 UTC, committed by Greg Kroah-Hartman on 23 December 2009, 19:34:11 UTC
While converting emi62 to use request_firmware(), the driver was also
changed to use the ihex helper functions.  However, this broke the loading
of the FPGA firmware because the code tries to access the addr field of
the EOF record which works with a plain array that has an empty last
record but not with the ihex helper functions where the end of the data is
signaled with a NULL record pointer, resulting in:

BUG: unable to handle kernel NULL pointer dereference at (null)
IP: [<f80d248c>] emi62_load_firmware+0x33c/0x740 [emi62]

This can be fixed by changing the loop condition to test the return value
of ihex_next_binrec() directly (like in emi26.c).

Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Reported-and-tested-by: Der Mickster <retroeffective@gmail.com>
Acked-by: David Woodhouse <David.Woodhouse@intel.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1 parent 27f1281
History
File Mode Size
basic
dtc
genksyms
kconfig
ksymoops
mod
package
rt-tester
selinux
tracing
.gitignore -rw-r--r-- 85 bytes
Kbuild.include -rw-r--r-- 9.5 KB
Lindent -rwxr-xr-x 460 bytes
Makefile -rw-r--r-- 934 bytes
Makefile.build -rw-r--r-- 11.9 KB
Makefile.clean -rw-r--r-- 3.2 KB
Makefile.fwinst -rw-r--r-- 2.0 KB
Makefile.headersinst -rw-r--r-- 3.3 KB
Makefile.host -rw-r--r-- 6.5 KB
Makefile.lib -rw-r--r-- 8.8 KB
Makefile.modbuiltin -rw-r--r-- 1.7 KB
Makefile.modinst -rw-r--r-- 1.0 KB
Makefile.modpost -rw-r--r-- 5.0 KB
bin2c.c -rw-r--r-- 702 bytes
binoffset.c -rw-r--r-- 3.9 KB
bloat-o-meter -rwxr-xr-x 1.7 KB
bootgraph.pl -rw-r--r-- 5.6 KB
checkincludes.pl -rwxr-xr-x 1.7 KB
checkkconfigsymbols.sh -rwxr-xr-x 1.8 KB
checkpatch.pl -rwxr-xr-x 72.0 KB
checkstack.pl -rwxr-xr-x 5.2 KB
checksyscalls.sh -rwxr-xr-x 5.5 KB
checkversion.pl -rwxr-xr-x 1.8 KB
cleanfile -rwxr-xr-x 3.4 KB
cleanpatch -rwxr-xr-x 5.0 KB
config -rwxr-xr-x 2.6 KB
conmakehash.c -rw-r--r-- 6.0 KB
decodecode -rwxr-xr-x 1.7 KB
diffconfig -rwxr-xr-x 3.6 KB
export_report.pl -rw-r--r-- 4.2 KB
extract-ikconfig -rwxr-xr-x 1.9 KB
gcc-version.sh -rw-r--r-- 819 bytes
gcc-x86_32-has-stack-protector.sh -rw-r--r-- 183 bytes
gcc-x86_64-has-stack-protector.sh -rw-r--r-- 199 bytes
gen_initramfs_list.sh -rw-r--r-- 7.0 KB
get_maintainer.pl -rwxr-xr-x 29.2 KB
gfp-translate -rw-r--r-- 1.5 KB
headerdep.pl -rwxr-xr-x 3.5 KB
headers.sh -rwxr-xr-x 512 bytes
headers_check.pl -rw-r--r-- 2.7 KB
headers_install.pl -rw-r--r-- 1.5 KB
kallsyms.c -rw-r--r-- 15.1 KB
kernel-doc -rwxr-xr-x 61.1 KB
makelst -rwxr-xr-x 773 bytes
markup_oops.pl -rw-r--r-- 7.5 KB
mkcompile_h -rwxr-xr-x 2.6 KB
mkmakefile -rw-r--r-- 1.1 KB
mksysmap -rw-r--r-- 1.3 KB
mkuboot.sh -rwxr-xr-x 379 bytes
mkversion -rw-r--r-- 74 bytes
module-common.lds -rw-r--r-- 210 bytes
namespace.pl -rwxr-xr-x 13.1 KB
patch-kernel -rwxr-xr-x 9.8 KB
pnmtologo.c -rw-r--r-- 11.7 KB
profile2linkerlist.pl -rw-r--r-- 378 bytes
recordmcount.pl -rwxr-xr-x 17.1 KB
setlocalversion -rwxr-xr-x 2.0 KB
show_delta -rwxr-xr-x 3.0 KB
tags.sh -rwxr-xr-x 4.2 KB
unifdef.c -rw-r--r-- 31.6 KB
ver_linux -rwxr-xr-x 3.1 KB

back to top