Revision ae1e206b806ccc490dadff59af8a7a2477b32884 authored by Josef Bacik on 07 August 2012, 20:00:32 UTC, committed by Chris Mason on 28 August 2012, 20:53:38 UTC
Daniel Blueman reported a bug with fio+balance on a ramdisk setup.
Basically what happens is the balance relocates a tree block which will drop
the implicit refs for all of its children and adds a full backref.  Once the
block is relocated we have to add the implicit refs back, so when we cow the
block again we add the implicit refs for its children back.  The problem
comes when the original drop ref doesn't get run before we add the implicit
refs back.  The delayed ref stuff will specifically prefer ADD operations
over DROP to keep us from freeing up an extent that will have references to
it, so we try to add the implicit ref before it is actually removed and we
panic.  This worked fine before because the add would have just canceled the
drop out and we would have been fine.  But the backref walking work needs to
be able to freeze the delayed ref stuff in time so we have this ever
increasing sequence number that gets attached to all new delayed ref updates
which makes us not merge refs and we run into this issue.

So to fix this we need to merge delayed refs.  So everytime we run a
clustered ref we need to try and merge all of its delayed refs.  The backref
walking stuff locks the delayed ref head before processing, so if we have it
locked we are safe to merge any refs inside of the sequence number.  If
there is no sequence number we can merge all refs.  Doing this not only
fixes our bug but keeps the delayed ref code from adding and removing
useless refs and batching together multiple refs into one search instead of
one search per delayed ref, which will really help our commit times.  I ran
this with Daniels test and 276 and I haven't seen any problems.  Thanks,

Reported-by: Daniel J Blueman <daniel@quora.org>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
1 parent 5a24e84
History
File Mode Size
9p
adfs
affs
afs
autofs4
befs
bfs
btrfs
cachefiles
ceph
cifs
coda
configfs
cramfs
debugfs
devpts
dlm
ecryptfs
efs
exofs
exportfs
ext2
ext3
ext4
fat
freevxfs
fscache
fuse
gfs2
hfs
hfsplus
hostfs
hpfs
hppfs
hugetlbfs
isofs
jbd
jbd2
jffs2
jfs
lockd
logfs
minix
ncpfs
nfs
nfs_common
nfsd
nilfs2
nls
notify
ntfs
ocfs2
omfs
openpromfs
proc
pstore
qnx4
qnx6
quota
ramfs
reiserfs
romfs
squashfs
sysfs
sysv
ubifs
udf
ufs
xfs
Kconfig -rw-r--r-- 6.2 KB
Kconfig.binfmt -rw-r--r-- 6.4 KB
Makefile -rw-r--r-- 4.0 KB
aio.c -rw-r--r-- 47.5 KB
anon_inodes.c -rw-r--r-- 6.4 KB
attr.c -rw-r--r-- 6.9 KB
bad_inode.c -rw-r--r-- 7.7 KB
binfmt_aout.c -rw-r--r-- 11.7 KB
binfmt_elf.c -rw-r--r-- 54.7 KB
binfmt_elf_fdpic.c -rw-r--r-- 48.5 KB
binfmt_em86.c -rw-r--r-- 2.8 KB
binfmt_flat.c -rw-r--r-- 26.7 KB
binfmt_misc.c -rw-r--r-- 15.1 KB
binfmt_script.c -rw-r--r-- 2.8 KB
binfmt_som.c -rw-r--r-- 7.1 KB
bio-integrity.c -rw-r--r-- 21.2 KB
bio.c -rw-r--r-- 40.9 KB
block_dev.c -rw-r--r-- 41.7 KB
buffer.c -rw-r--r-- 85.5 KB
char_dev.c -rw-r--r-- 13.8 KB
compat.c -rw-r--r-- 44.5 KB
compat_binfmt_elf.c -rw-r--r-- 3.5 KB
compat_ioctl.c -rw-r--r-- 45.2 KB
dcache.c -rw-r--r-- 80.2 KB
dcookies.c -rw-r--r-- 6.8 KB
direct-io.c -rw-r--r-- 37.2 KB
drop_caches.c -rw-r--r-- 1.5 KB
eventfd.c -rw-r--r-- 10.9 KB
eventpoll.c -rw-r--r-- 53.4 KB
exec.c -rw-r--r-- 53.2 KB
fcntl.c -rw-r--r-- 18.8 KB
fhandle.c -rw-r--r-- 6.5 KB
fifo.c -rw-r--r-- 3.2 KB
file.c -rw-r--r-- 11.8 KB
file_table.c -rw-r--r-- 12.6 KB
filesystems.c -rw-r--r-- 6.3 KB
fs-writeback.c -rw-r--r-- 39.4 KB
fs_struct.c -rw-r--r-- 3.9 KB
generic_acl.c -rw-r--r-- 3.8 KB
inode.c -rw-r--r-- 48.4 KB
internal.h -rw-r--r-- 2.9 KB
ioctl.c -rw-r--r-- 15.7 KB
ioprio.c -rw-r--r-- 5.0 KB
libfs.c -rw-r--r-- 25.8 KB
locks.c -rw-r--r-- 59.0 KB
mbcache.c -rw-r--r-- 16.4 KB
mount.h -rw-r--r-- 2.0 KB
mpage.c -rw-r--r-- 20.0 KB
namei.c -rw-r--r-- 86.1 KB
namespace.c -rw-r--r-- 63.3 KB
no-block.c -rw-r--r-- 688 bytes
open.c -rw-r--r-- 27.3 KB
pipe.c -rw-r--r-- 29.0 KB
pnode.c -rw-r--r-- 8.8 KB
pnode.h -rw-r--r-- 1.4 KB
posix_acl.c -rw-r--r-- 9.2 KB
proc_namespace.c -rw-r--r-- 7.5 KB
read_write.c -rw-r--r-- 22.4 KB
read_write.h -rw-r--r-- 542 bytes
readdir.c -rw-r--r-- 7.0 KB
select.c -rw-r--r-- 24.1 KB
seq_file.c -rw-r--r-- 19.4 KB
signalfd.c -rw-r--r-- 8.1 KB
splice.c -rw-r--r-- 46.5 KB
stack.c -rw-r--r-- 2.5 KB
stat.c -rw-r--r-- 11.0 KB
statfs.c -rw-r--r-- 5.2 KB
super.c -rw-r--r-- 29.9 KB
sync.c -rw-r--r-- 9.9 KB
timerfd.c -rw-r--r-- 8.6 KB
utimes.c -rw-r--r-- 5.7 KB
xattr.c -rw-r--r-- 17.9 KB
xattr_acl.c -rw-r--r-- 2.3 KB

back to top