https://github.com/torvalds/linux
Revision aeaac098bd58349d7415acd998089309fd798190 authored by Dan Carpenter on 03 September 2014, 11:44:37 UTC, committed by Darren Hart on 03 September 2014, 17:45:12 UTC
The current code just returns -EINVAL because mode can't be equal to both 1 and 2. Also this function is messy so I have cleaned it up: 1) Remove initializers like "int time = -1". Initializing variables to garbage values turns off GCC's uninitialized variable warnings so it can lead to bugs. 2) Use kstrtoint() instead of sscanf(). 3) Use SCI_KBD_MODE_FNZ and SCI_KBD_MODE_AUTO instead of magic numbers 1 and 2. 4) Don't check for "mode == -1" because that can't happen. 5) Preserve the error code from toshiba_kbd_illum_status_set(). Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
1 parent e7fdb76
Tip revision: aeaac098bd58349d7415acd998089309fd798190 authored by Dan Carpenter on 03 September 2014, 11:44:37 UTC
toshiba_acpi: fix and cleanup toshiba_kbd_bl_mode_store()
toshiba_acpi: fix and cleanup toshiba_kbd_bl_mode_store()
Tip revision: aeaac09
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 20.8 KB |
| Kconfig.debug | -rw-r--r-- | 1015 bytes |
| Makefile | -rw-r--r-- | 2.2 KB |
| backing-dev.c | -rw-r--r-- | 16.7 KB |
| balloon_compaction.c | -rw-r--r-- | 9.7 KB |
| bootmem.c | -rw-r--r-- | 20.8 KB |
| cleancache.c | -rw-r--r-- | 12.7 KB |
| cma.c | -rw-r--r-- | 8.7 KB |
| compaction.c | -rw-r--r-- | 34.8 KB |
| debug-pagealloc.c | -rw-r--r-- | 2.1 KB |
| dmapool.c | -rw-r--r-- | 13.0 KB |
| early_ioremap.c | -rw-r--r-- | 5.4 KB |
| fadvise.c | -rw-r--r-- | 3.6 KB |
| failslab.c | -rw-r--r-- | 1.3 KB |
| filemap.c | -rw-r--r-- | 70.4 KB |
| filemap_xip.c | -rw-r--r-- | 11.3 KB |
| fremap.c | -rw-r--r-- | 7.3 KB |
| frontswap.c | -rw-r--r-- | 13.4 KB |
| gup.c | -rw-r--r-- | 20.6 KB |
| highmem.c | -rw-r--r-- | 11.8 KB |
| huge_memory.c | -rw-r--r-- | 78.2 KB |
| hugetlb.c | -rw-r--r-- | 98.0 KB |
| hugetlb_cgroup.c | -rw-r--r-- | 10.3 KB |
| hwpoison-inject.c | -rw-r--r-- | 3.3 KB |
| init-mm.c | -rw-r--r-- | 619 bytes |
| internal.h | -rw-r--r-- | 11.4 KB |
| interval_tree.c | -rw-r--r-- | 3.2 KB |
| iov_iter.c | -rw-r--r-- | 16.6 KB |
| kmemcheck.c | -rw-r--r-- | 2.8 KB |
| kmemleak-test.c | -rw-r--r-- | 3.2 KB |
| kmemleak.c | -rw-r--r-- | 53.2 KB |
| ksm.c | -rw-r--r-- | 63.3 KB |
| list_lru.c | -rw-r--r-- | 3.4 KB |
| maccess.c | -rw-r--r-- | 1.6 KB |
| madvise.c | -rw-r--r-- | 14.1 KB |
| memblock.c | -rw-r--r-- | 44.6 KB |
| memcontrol.c | -rw-r--r-- | 175.5 KB |
| memory-failure.c | -rw-r--r-- | 47.8 KB |
| memory.c | -rw-r--r-- | 102.2 KB |
| memory_hotplug.c | -rw-r--r-- | 50.8 KB |
| mempolicy.c | -rw-r--r-- | 71.5 KB |
| mempool.c | -rw-r--r-- | 10.7 KB |
| migrate.c | -rw-r--r-- | 49.1 KB |
| mincore.c | -rw-r--r-- | 7.8 KB |
| mlock.c | -rw-r--r-- | 22.8 KB |
| mm_init.c | -rw-r--r-- | 5.0 KB |
| mmap.c | -rw-r--r-- | 88.1 KB |
| mmu_context.c | -rw-r--r-- | 1.3 KB |
| mmu_notifier.c | -rw-r--r-- | 10.5 KB |
| mmzone.c | -rw-r--r-- | 2.4 KB |
| mprotect.c | -rw-r--r-- | 10.7 KB |
| mremap.c | -rw-r--r-- | 15.0 KB |
| msync.c | -rw-r--r-- | 2.7 KB |
| nobootmem.c | -rw-r--r-- | 10.7 KB |
| nommu.c | -rw-r--r-- | 53.4 KB |
| oom_kill.c | -rw-r--r-- | 19.7 KB |
| page-writeback.c | -rw-r--r-- | 74.5 KB |
| page_alloc.c | -rw-r--r-- | 184.4 KB |
| page_cgroup.c | -rw-r--r-- | 12.0 KB |
| page_io.c | -rw-r--r-- | 9.5 KB |
| page_isolation.c | -rw-r--r-- | 7.5 KB |
| pagewalk.c | -rw-r--r-- | 5.9 KB |
| percpu-km.c | -rw-r--r-- | 2.8 KB |
| percpu-vm.c | -rw-r--r-- | 12.9 KB |
| percpu.c | -rw-r--r-- | 56.9 KB |
| pgtable-generic.c | -rw-r--r-- | 5.2 KB |
| process_vm_access.c | -rw-r--r-- | 10.2 KB |
| quicklist.c | -rw-r--r-- | 2.4 KB |
| readahead.c | -rw-r--r-- | 15.6 KB |
| rmap.c | -rw-r--r-- | 48.3 KB |
| shmem.c | -rw-r--r-- | 88.8 KB |
| slab.c | -rw-r--r-- | 109.3 KB |
| slab.h | -rw-r--r-- | 8.5 KB |
| slab_common.c | -rw-r--r-- | 20.3 KB |
| slob.c | -rw-r--r-- | 15.7 KB |
| slub.c | -rw-r--r-- | 126.2 KB |
| sparse-vmemmap.c | -rw-r--r-- | 6.0 KB |
| sparse.c | -rw-r--r-- | 20.9 KB |
| swap.c | -rw-r--r-- | 31.7 KB |
| swap_state.c | -rw-r--r-- | 12.9 KB |
| swapfile.c | -rw-r--r-- | 77.0 KB |
| truncate.c | -rw-r--r-- | 22.5 KB |
| util.c | -rw-r--r-- | 9.4 KB |
| vmacache.c | -rw-r--r-- | 3.1 KB |
| vmalloc.c | -rw-r--r-- | 68.3 KB |
| vmpressure.c | -rw-r--r-- | 11.4 KB |
| vmscan.c | -rw-r--r-- | 110.1 KB |
| vmstat.c | -rw-r--r-- | 35.4 KB |
| workingset.c | -rw-r--r-- | 13.6 KB |
| zbud.c | -rw-r--r-- | 17.7 KB |
| zpool.c | -rw-r--r-- | 9.5 KB |
| zsmalloc.c | -rw-r--r-- | 30.2 KB |
| zswap.c | -rw-r--r-- | 24.9 KB |
Computing file changes ...
