Revision b121186ab1b12e2a96a945d88eae0735b4542158 authored by Alex Shi on 21 August 2012, 23:16:08 UTC, committed by Linus Torvalds on 21 August 2012, 23:45:03 UTC
Commit cfd19c5a9ecf ("mm: only set page->pfmemalloc when
ALLOC_NO_WATERMARKS was used") tried to narrow down page->pfmemalloc
setting, but it missed some places the pfmemalloc should be set.
So, in __slab_alloc, the unalignment pfmemalloc and ALLOC_NO_WATERMARKS
cause incorrect deactivate_slab() on our core2 server:
64.73% fio [kernel.kallsyms] [k] _raw_spin_lock
|
--- _raw_spin_lock
|
|---0.34%-- deactivate_slab
| __slab_alloc
| kmem_cache_alloc
| |
That causes our fio sync write performance to have a 40% regression.
Move the checking in get_page_from_freelist() which resolves this issue.
Signed-off-by: Alex Shi <alex.shi@intel.com>
Acked-by: Mel Gorman <mgorman@suse.de>
Cc: David Miller <davem@davemloft.net
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Tested-by: Eric Dumazet <eric.dumazet@gmail.com>
Tested-by: Sage Weil <sage@inktank.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 5ed12f1
| File | Mode | Size |
|---|---|---|
| 9p | ||
| adfs | ||
| affs | ||
| afs | ||
| autofs4 | ||
| befs | ||
| bfs | ||
| btrfs | ||
| cachefiles | ||
| ceph | ||
| cifs | ||
| coda | ||
| configfs | ||
| cramfs | ||
| debugfs | ||
| devpts | ||
| dlm | ||
| ecryptfs | ||
| efs | ||
| exofs | ||
| exportfs | ||
| ext2 | ||
| ext3 | ||
| ext4 | ||
| fat | ||
| freevxfs | ||
| fscache | ||
| fuse | ||
| gfs2 | ||
| hfs | ||
| hfsplus | ||
| hostfs | ||
| hpfs | ||
| hppfs | ||
| hugetlbfs | ||
| isofs | ||
| jbd | ||
| jbd2 | ||
| jffs2 | ||
| jfs | ||
| lockd | ||
| logfs | ||
| minix | ||
| ncpfs | ||
| nfs | ||
| nfs_common | ||
| nfsd | ||
| nilfs2 | ||
| nls | ||
| notify | ||
| ntfs | ||
| ocfs2 | ||
| omfs | ||
| openpromfs | ||
| proc | ||
| pstore | ||
| qnx4 | ||
| qnx6 | ||
| quota | ||
| ramfs | ||
| reiserfs | ||
| romfs | ||
| squashfs | ||
| sysfs | ||
| sysv | ||
| ubifs | ||
| udf | ||
| ufs | ||
| xfs | ||
| Kconfig | -rw-r--r-- | 6.2 KB |
| Kconfig.binfmt | -rw-r--r-- | 6.4 KB |
| Makefile | -rw-r--r-- | 4.0 KB |
| aio.c | -rw-r--r-- | 45.7 KB |
| anon_inodes.c | -rw-r--r-- | 6.4 KB |
| attr.c | -rw-r--r-- | 6.9 KB |
| bad_inode.c | -rw-r--r-- | 7.7 KB |
| binfmt_aout.c | -rw-r--r-- | 11.7 KB |
| binfmt_elf.c | -rw-r--r-- | 54.7 KB |
| binfmt_elf_fdpic.c | -rw-r--r-- | 48.5 KB |
| binfmt_em86.c | -rw-r--r-- | 2.8 KB |
| binfmt_flat.c | -rw-r--r-- | 26.7 KB |
| binfmt_misc.c | -rw-r--r-- | 15.1 KB |
| binfmt_script.c | -rw-r--r-- | 2.8 KB |
| binfmt_som.c | -rw-r--r-- | 7.1 KB |
| bio-integrity.c | -rw-r--r-- | 21.2 KB |
| bio.c | -rw-r--r-- | 40.9 KB |
| block_dev.c | -rw-r--r-- | 42.7 KB |
| buffer.c | -rw-r--r-- | 85.2 KB |
| char_dev.c | -rw-r--r-- | 13.8 KB |
| compat.c | -rw-r--r-- | 44.6 KB |
| compat_binfmt_elf.c | -rw-r--r-- | 3.5 KB |
| compat_ioctl.c | -rw-r--r-- | 45.2 KB |
| dcache.c | -rw-r--r-- | 80.4 KB |
| dcookies.c | -rw-r--r-- | 6.8 KB |
| direct-io.c | -rw-r--r-- | 37.2 KB |
| drop_caches.c | -rw-r--r-- | 1.5 KB |
| eventfd.c | -rw-r--r-- | 10.9 KB |
| eventpoll.c | -rw-r--r-- | 53.4 KB |
| exec.c | -rw-r--r-- | 53.5 KB |
| fcntl.c | -rw-r--r-- | 19.4 KB |
| fhandle.c | -rw-r--r-- | 6.5 KB |
| fifo.c | -rw-r--r-- | 3.2 KB |
| file.c | -rw-r--r-- | 11.8 KB |
| file_table.c | -rw-r--r-- | 14.6 KB |
| filesystems.c | -rw-r--r-- | 6.3 KB |
| fs-writeback.c | -rw-r--r-- | 39.4 KB |
| fs_struct.c | -rw-r--r-- | 3.6 KB |
| generic_acl.c | -rw-r--r-- | 3.8 KB |
| inode.c | -rw-r--r-- | 48.5 KB |
| internal.h | -rw-r--r-- | 2.9 KB |
| ioctl.c | -rw-r--r-- | 15.7 KB |
| ioprio.c | -rw-r--r-- | 5.0 KB |
| libfs.c | -rw-r--r-- | 25.8 KB |
| locks.c | -rw-r--r-- | 58.8 KB |
| mbcache.c | -rw-r--r-- | 16.4 KB |
| mount.h | -rw-r--r-- | 2.2 KB |
| mpage.c | -rw-r--r-- | 20.0 KB |
| namei.c | -rw-r--r-- | 97.1 KB |
| namespace.c | -rw-r--r-- | 64.5 KB |
| no-block.c | -rw-r--r-- | 688 bytes |
| open.c | -rw-r--r-- | 25.4 KB |
| pipe.c | -rw-r--r-- | 28.6 KB |
| pnode.c | -rw-r--r-- | 8.8 KB |
| pnode.h | -rw-r--r-- | 1.4 KB |
| posix_acl.c | -rw-r--r-- | 9.2 KB |
| proc_namespace.c | -rw-r--r-- | 7.5 KB |
| read_write.c | -rw-r--r-- | 22.5 KB |
| read_write.h | -rw-r--r-- | 542 bytes |
| readdir.c | -rw-r--r-- | 7.0 KB |
| select.c | -rw-r--r-- | 24.1 KB |
| seq_file.c | -rw-r--r-- | 19.5 KB |
| signalfd.c | -rw-r--r-- | 8.1 KB |
| splice.c | -rw-r--r-- | 46.5 KB |
| stack.c | -rw-r--r-- | 2.5 KB |
| stat.c | -rw-r--r-- | 11.0 KB |
| statfs.c | -rw-r--r-- | 5.2 KB |
| super.c | -rw-r--r-- | 35.3 KB |
| sync.c | -rw-r--r-- | 10.8 KB |
| timerfd.c | -rw-r--r-- | 8.6 KB |
| utimes.c | -rw-r--r-- | 5.7 KB |
| xattr.c | -rw-r--r-- | 18.0 KB |
| xattr_acl.c | -rw-r--r-- | 2.3 KB |
Computing file changes ...
